diff options
| author |   Temoc Rodriguez <cr056n@att.com> | 2017-11-28 09:59:02 -0800 |
|---|---|---|
| committer | Temoc Rodriguez <cr056n@att.com> | 2017-12-05 09:36:31 -0800 |
| commit | 39672906602cbd5b734b8c9889234653e4beaf26 (patch) | |
| tree | 257e1da810bcb41f1a95f4072af03d686675be50 /integrity-audit/src/main/java/org/onap/policy/common/ia/AuditThread.java | |
| parent | 496a8e0a4d4b53136a8612ad4e3369a3c6562674 (diff) | |
Fix technical debt in common integrity-audit
Address technical debt in policy/common integrity-audit submodule.
Implementation for empty constructors, remove useless assignment,
use <> on constructor, use @Override. Not all technical debt
addressed, only the ones specified by Pam in POLICY-336, except
the use Set instead of HashSet where a method signature would
change.
Issue-ID: POLICY-456
Change-Id: If8f9f4151503bdd22c8c405485538f8be779cabd
Signed-off-by: Temoc Rodriguez <cr056n@att.com>
Diffstat (limited to 'integrity-audit/src/main/java/org/onap/policy/common/ia/AuditThread.java')
| -rw-r--r-- | integrity-audit/src/main/java/org/onap/policy/common/ia/AuditThread.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/integrity-audit/src/main/java/org/onap/policy/common/ia/AuditThread.java b/integrity-audit/src/main/java/org/onap/policy/common/ia/AuditThread.java index 2e15da5f..e3cada9d 100644 --- a/integrity-audit/src/main/java/org/onap/policy/common/ia/AuditThread.java +++ b/integrity-audit/src/main/java/org/onap/policy/common/ia/AuditThread.java @@ -132,6 +132,7 @@ public class AuditThread extends Thread { } + @Override public void run() { logger.info("AuditThread.run: Entering"); @@ -327,7 +328,7 @@ public class AuditThread extends Thread { + integrityAuditEntityList.size()); } - IntegrityAuditEntity designationCandidate = null; + IntegrityAuditEntity designationCandidate; IntegrityAuditEntity thisEntity = null; int designatedEntityIndex = -1; @@ -552,8 +553,7 @@ public class AuditThread extends Thread { * Sorted list of entities for a particular nodeType and * persistenceUnit. */ - List<IntegrityAuditEntity> integrityAuditEntityList = new ArrayList<IntegrityAuditEntity>(); - integrityAuditEntityList = dbDAO.getIntegrityAuditEntities( + List<IntegrityAuditEntity> integrityAuditEntityList = dbDAO.getIntegrityAuditEntities( this.persistenceUnit, this.nodeType); int listSize = integrityAuditEntityList.size(); if (logger.isDebugEnabled()) { |