From 39672906602cbd5b734b8c9889234653e4beaf26 Mon Sep 17 00:00:00 2001 From: Temoc Rodriguez Date: Tue, 28 Nov 2017 09:59:02 -0800 Subject: Fix technical debt in common integrity-audit Address technical debt in policy/common integrity-audit submodule. Implementation for empty constructors, remove useless assignment, use <> on constructor, use @Override. Not all technical debt addressed, only the ones specified by Pam in POLICY-336, except the use Set instead of HashSet where a method signature would change. Issue-ID: POLICY-456 Change-Id: If8f9f4151503bdd22c8c405485538f8be779cabd Signed-off-by: Temoc Rodriguez --- .../src/main/java/org/onap/policy/common/ia/AuditThread.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'integrity-audit/src/main/java/org/onap/policy/common/ia/AuditThread.java') diff --git a/integrity-audit/src/main/java/org/onap/policy/common/ia/AuditThread.java b/integrity-audit/src/main/java/org/onap/policy/common/ia/AuditThread.java index 2e15da5f..e3cada9d 100644 --- a/integrity-audit/src/main/java/org/onap/policy/common/ia/AuditThread.java +++ b/integrity-audit/src/main/java/org/onap/policy/common/ia/AuditThread.java @@ -132,6 +132,7 @@ public class AuditThread extends Thread { } + @Override public void run() { logger.info("AuditThread.run: Entering"); @@ -327,7 +328,7 @@ public class AuditThread extends Thread { + integrityAuditEntityList.size()); } - IntegrityAuditEntity designationCandidate = null; + IntegrityAuditEntity designationCandidate; IntegrityAuditEntity thisEntity = null; int designatedEntityIndex = -1; @@ -552,8 +553,7 @@ public class AuditThread extends Thread { * Sorted list of entities for a particular nodeType and * persistenceUnit. */ - List integrityAuditEntityList = new ArrayList(); - integrityAuditEntityList = dbDAO.getIntegrityAuditEntities( + List integrityAuditEntityList = dbDAO.getIntegrityAuditEntities( this.persistenceUnit, this.nodeType); int listSize = integrityAuditEntityList.size(); if (logger.isDebugEnabled()) { -- cgit 1.2.3-korg