diff options
| author |   Jim Hahn <jrh3@att.com> | 2019-06-12 14:32:25 -0400 |
|---|---|---|
| committer | Jim Hahn <jrh3@att.com> | 2019-06-12 17:36:59 -0400 |
| commit | ea262e6da52fd4da0733f02998f87aebaf502ddb (patch) | |
| tree | a7cded567521f0141f31d9f8c185eccdaf2a8979 /policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicParamsTest.java | |
| parent | e671e9fa5d09ec696cb24aeefaf10ddbc7c705d7 (diff) | |
Apply simple sonar fixes
Note: A number of these were identified, by SonarLint, in the Test
classes, which are not typically scanned by Sonar.
Removed unnecessary imports.
Removed unneeded "throws Xxx".
Replaced lambda with method references.
Replaced duplicate strings with constants.
Replaced try-fail-catch with assert-j methods to eliminate sonar
complaints about duplicate failure messages.
Added missing @Override annotations.
Use map.computeIfAbsent() where appropriate.
Also fixed some minor checkstyle issues.
Removed unneeded "volatile" declarations.
Replaced some if-else constructs with "?:" construct, per sonar.
Replaced Object.wait() with CountDownLatch.await(); according to sonar
(and javadocs), Object.wait() can return due to "spurious wakeups".
Fixed issue whereby CryptoUtilsTest wouldn't run in my Eclipse.
Change-Id: Ib6b71ed65662cfd6209400dac57ed69279bf29ec
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>
Diffstat (limited to 'policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicParamsTest.java')
| -rw-r--r-- | policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicParamsTest.java | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicParamsTest.java b/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicParamsTest.java index 8d1c6343..54531c56 100644 --- a/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicParamsTest.java +++ b/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicParamsTest.java @@ -35,6 +35,7 @@ import org.onap.policy.common.endpoints.event.comm.bus.internal.BusTopicParams.T public class BusTopicParamsTest extends TopicTestBase { @Before + @Override public void setUp() { super.setUp(); } @@ -123,7 +124,7 @@ public class BusTopicParamsTest extends TopicTestBase { * Tests the boolean methods by applying a function, once with {@code false} and once * with {@code true}. Verifies that all of the boolean methods return the correct * value by concatenating them. - * + * * @param expectedTrue the string that is expected when {@code true} is passed to the * method * @param function function to be applied to the builder |