diff options
author | Jim Hahn <jrh3@att.com> | 2020-04-03 09:44:26 -0400 |
---|---|---|
committer | Jim Hahn <jrh3@att.com> | 2020-04-06 09:41:59 -0400 |
commit | a56d3929f2387252525577fb36f9e03933064b8f (patch) | |
tree | 4b671549b5f1c0513c31d77baa19821e422f41e7 /policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusConsumerTest.java | |
parent | 7da3ddfa40de2f683a2d423d62b78a8d001108eb (diff) |
Address sonar issues in common
Addressed the following sonar issues:
- missing assertion in junit test case
- disable sonars about setAccessible() as it's required for jackson
emulation
- sleep in junit
- don't use wild-cards (e.g., "*") with java.util Pattern
- use re2j instead of java.util Pattern
- use String methods (e.g., startsWith())
- duplicate method bodies
- duplicate code in Coder classes
- string concatenation in logger calls
- UTF-8 encoding
- return primitive instead of boxed primitive
- add assertion to tests
- renamed support methods from doTestXxx to verifyXxx
- cognitive complexity
- use AtomicRef instead of volatile
- use specific Functionals (e.g., IntConsumer)
- function always returns the same value
- serializable vs transient
Issue-ID: POLICY-2305
Change-Id: I08eb7aa495a80bdc1d26827ba17a7946c83b9828
Signed-off-by: Jim Hahn <jrh3@att.com>
Diffstat (limited to 'policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusConsumerTest.java')
-rw-r--r-- | policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusConsumerTest.java | 23 |
1 files changed, 15 insertions, 8 deletions
diff --git a/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusConsumerTest.java b/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusConsumerTest.java index 0255c100..5264b2f4 100644 --- a/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusConsumerTest.java +++ b/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusConsumerTest.java @@ -2,7 +2,7 @@ * ============LICENSE_START======================================================= * policy-endpoints * ================================================================================ - * Copyright (C) 2018-2019 AT&T Intellectual Property. All rights reserved. + * Copyright (C) 2018-2020 AT&T Intellectual Property. All rights reserved. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -20,6 +20,7 @@ package org.onap.policy.common.endpoints.event.comm.bus.internal; +import static org.assertj.core.api.Assertions.assertThatCode; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; @@ -65,7 +66,9 @@ public class BusConsumerTest extends TopicTestBase { new CambriaConsumerWrapper(makeBuilder().apiKey(null).apiSecret(null).build()); new CambriaConsumerWrapper(makeBuilder().userName(null).build()); new CambriaConsumerWrapper(makeBuilder().password(null).build()); - new CambriaConsumerWrapper(makeBuilder().userName(null).password(null).build()); + + assertThatCode(() -> new CambriaConsumerWrapper(makeBuilder().userName(null).password(null).build())) + .doesNotThrowAnyException(); } @Test @@ -101,7 +104,8 @@ public class BusConsumerTest extends TopicTestBase { // set filter several times to cause different branches of close() to be executed for (int count = 0; count < 3; ++count) { cons.close(); - cons.setFilter("close=" + count); + final int count2 = count; + assertThatCode(() -> cons.setFilter("close=" + count2)).doesNotThrowAnyException(); } } @@ -110,7 +114,8 @@ public class BusConsumerTest extends TopicTestBase { // set filter several times to cause different branches to be executed CambriaConsumerWrapper cons = new CambriaConsumerWrapper(builder.build()); for (int count = 0; count < 3; ++count) { - cons.setFilter("set-filter=" + count); + final int count2 = count; + assertThatCode(() -> cons.setFilter("set-filter=" + count2)).doesNotThrowAnyException(); } } @@ -122,7 +127,7 @@ public class BusConsumerTest extends TopicTestBase { @Test public void testDmaapConsumerWrapper() throws Exception { // verify that different wrappers can be built - new DmaapAafConsumerWrapper(makeBuilder().build()); + assertThatCode(() -> new DmaapAafConsumerWrapper(makeBuilder().build())).doesNotThrowAnyException(); } @Test(expected = IllegalArgumentException.class) @@ -167,7 +172,7 @@ public class BusConsumerTest extends TopicTestBase { @Test public void testDmaapConsumerWrapperClose() throws Exception { - new DmaapAafConsumerWrapper(makeBuilder().build()).close(); + assertThatCode(() -> new DmaapAafConsumerWrapper(makeBuilder().build()).close()).doesNotThrowAnyException(); } @Test @@ -179,7 +184,8 @@ public class BusConsumerTest extends TopicTestBase { public void testDmaapAafConsumerWrapper() throws Exception { // verify that different wrappers can be built new DmaapAafConsumerWrapper(makeBuilder().useHttps(true).build()); - new DmaapAafConsumerWrapper(makeBuilder().useHttps(false).build()); + assertThatCode(() -> new DmaapAafConsumerWrapper(makeBuilder().useHttps(false).build())) + .doesNotThrowAnyException(); } @Test(expected = IllegalArgumentException.class) @@ -207,7 +213,8 @@ public class BusConsumerTest extends TopicTestBase { addProps.put(ROUTE_PROP, MY_ROUTE); new DmaapDmeConsumerWrapper(makeBuilder().build()); - new DmaapDmeConsumerWrapper(makeBuilder().partner(null).build()); + assertThatCode(() -> new DmaapDmeConsumerWrapper(makeBuilder().partner(null).build())) + .doesNotThrowAnyException(); } @Test(expected = IllegalArgumentException.class) |