Adding NOOP sources support

In addition, Noop* classes have been refactored to
increase code reuse and clean some checkstyle issues.
Additional Junits have been added for existing functionality.

Change-Id: I072f9ff2f415630ac82eca949a8360249f73da86
Issue-ID: POLICY-1397
Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>

1 files changed, 12 insertions, 81 deletions

diff --git a/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/NoopTopicSinkTest.java b/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/NoopTopicSinkTest.java
index 8a5b7b2e..02478367 100644
--- a/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/NoopTopicSinkTest.java
+++ b/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/NoopTopicSinkTest.java
@@ -1,8 +1,8 @@
 /*
  * ============LICENSE_START=======================================================
- * policy-endpoints
+ * ONAP
  * ================================================================================
- * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,50 +20,30 @@
 
 package org.onap.policy.common.endpoints.event.comm.bus;
 
-import static org.junit.Assert.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.verify;
 
-import java.util.Arrays;
-import org.junit.Before;
 import org.junit.Test;
-import org.onap.policy.common.endpoints.event.comm.Topic.CommInfrastructure;
-import org.onap.policy.common.endpoints.event.comm.TopicListener;
 
-public class NoopTopicSinkTest extends TopicTestBase {
+public class NoopTopicSinkTest extends NoopTopicEndpointTest<NoopTopicSinkFactory, NoopTopicSink> {
 
-    private NoopTopicSink sink;
-
-    /**
-     * Creates the object to be tested.
-     */
-    @Before
-    public void setUp() {
-        super.setUp();
+    public NoopTopicSinkTest() {
+        super(new NoopTopicSinkFactory());
+    }
 
-        sink = new NoopTopicSink(servers, MY_TOPIC);
+    @Override
+    protected boolean io(String message) {
+        return endpoint.send(message);
     }
 
     @Test
     public void testToString() {
-        assertTrue(sink.toString().startsWith("NoopTopicSink ["));
+        assertThat(endpoint.toString()).startsWith("NoopTopicSink");
     }
 
     @Test
     public void testSend() {
-        TopicListener listener = mock(TopicListener.class);
-        sink.register(listener);
-        sink.start();
-
-        assertTrue(sink.send(MY_MESSAGE));
-
-        assertEquals(Arrays.asList(MY_MESSAGE), Arrays.asList(sink.getRecentEvents()));
-        verify(listener).onTopicEvent(CommInfrastructure.NOOP, MY_TOPIC, MY_MESSAGE);
-
-        // generate exception during broadcast
-        sink = new NoopTopicSink(servers, MY_TOPIC) {
+        NoopTopicSink sink = new NoopTopicSink(servers, MY_TOPIC) {
             @Override
             protected boolean broadcast(String message) {
                 throw new RuntimeException(EXPECTED);
@@ -74,53 +54,4 @@ public class NoopTopicSinkTest extends TopicTestBase {
         sink.start();
         assertFalse(sink.send(MY_MESSAGE));
     }
-
-    @Test(expected = IllegalArgumentException.class)
-    public void testSend_NullMessage() {
-        sink.send(null);
-    }
-
-    @Test(expected = IllegalArgumentException.class)
-    public void testSend_EmptyMessage() {
-        sink.send("");
-    }
-
-    @Test(expected = IllegalStateException.class)
-    public void testSend_NotStarted() {
-        sink.send(MY_MESSAGE);
-    }
-
-    @Test
-    public void testGetTopicCommInfrastructure() {
-        assertEquals(CommInfrastructure.NOOP, sink.getTopicCommInfrastructure());
-    }
-
-    @Test
-    public void testStart_testStop_testShutdown() {
-        sink.start();
-        assertTrue(sink.isAlive());
-
-        // start again
-        sink.start();
-        assertTrue(sink.isAlive());
-
-        // stop
-        sink.stop();
-        assertFalse(sink.isAlive());
-
-        // re-start again
-        sink.start();
-        assertTrue(sink.isAlive());
-
-        // shutdown
-        sink.shutdown();
-        assertFalse(sink.isAlive());
-    }
-
-    @Test(expected = IllegalStateException.class)
-    public void testStart_Locked() {
-        sink.lock();
-        sink.start();
-    }
-
 }