Adding NOOP sources support

In addition, Noop* classes have been refactored to
increase code reuse and clean some checkstyle issues.
Additional Junits have been added for existing functionality.

Change-Id: I072f9ff2f415630ac82eca949a8360249f73da86
Issue-ID: POLICY-1397
Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>

1 files changed, 224 insertions, 0 deletions

diff --git a/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/NoopTopicFactoryTest.java b/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/NoopTopicFactoryTest.java
new file mode 100644
index 00000000..16d9e539
--- /dev/null
+++ b/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/bus/NoopTopicFactoryTest.java
@@ -0,0 +1,224 @@
+/*
+ * ============LICENSE_START=======================================================
+ * ONAP
+ * ================================================================================
+ * Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.policy.common.endpoints.event.comm.bus;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNotSame;
+import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertTrue;
+import static org.onap.policy.common.endpoints.properties.PolicyEndPointProperties.PROPERTY_MANAGED_SUFFIX;
+import static org.onap.policy.common.endpoints.properties.PolicyEndPointProperties.PROPERTY_TOPIC_SERVERS_SUFFIX;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import java.util.Properties;
+import org.apache.commons.lang3.RandomStringUtils;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.onap.policy.common.endpoints.event.comm.Topic.CommInfrastructure;
+
+public abstract class NoopTopicFactoryTest<F extends NoopTopicFactory<T>, T extends NoopTopicEndpoint>
+    extends TopicFactoryTestBase<T> {
+
+    private static final List<String> NOOP_SERVERS = Arrays.asList(CommInfrastructure.NOOP.toString());
+    private F factory = null;
+
+    protected abstract F buildFactory();
+
+    /**
+     * Creates the object to be tested.
+     */
+    @Before
+    public void setUp() {
+        super.setUp();
+        initFactory();
+    }
+
+    @After
+    public void tearDown() {
+        factory.destroy();
+    }
+
+    @Test
+    public void testBuildListOfStringStringBoolean() {
+        initFactory();
+
+        T item1 = buildTopic(servers, MY_TOPIC, true);
+        assertNotNull(item1);
+
+        assertEquals(servers, item1.getServers());
+        assertEquals(MY_TOPIC, item1.getTopic());
+
+        // managed topic - should not build a new one
+        assertEquals(item1, buildTopic(servers, MY_TOPIC, true));
+
+        T item2 = buildTopic(servers, TOPIC2, true);
+        assertNotNull(item2);
+        assertNotSame(item1, item2);
+
+        // duplicate - should be the same, as these topics are managed
+        List<String> randomServers = new ArrayList<>();
+        randomServers.add(RandomStringUtils.randomAlphanumeric(8));
+        T item3 = buildTopic(randomServers, TOPIC2, true);
+        assertSame(item2, item3);
+
+        T item4 = buildTopic(Collections.emptyList(), TOPIC2, true);
+        assertSame(item3, item4);
+
+        // null server list
+        initFactory();
+        assertEquals(NOOP_SERVERS, buildTopic(null, MY_TOPIC, true).getServers());
+
+        // empty server list
+        initFactory();
+        assertEquals(NOOP_SERVERS, buildTopic(Collections.emptyList(), MY_TOPIC, true).getServers());
+
+        // unmanaged topic
+        initFactory();
+        item1 = buildTopic(servers, MY_TOPIC, false);
+        assertNotSame(item1, buildTopic(servers, MY_TOPIC, false));
+    }
+
+    @Test(expected = IllegalArgumentException.class)
+    public void testBuildListOfStringStringBoolean_NullTopic() {
+        buildTopic(servers, null, true);
+    }
+
+    @Test(expected = IllegalArgumentException.class)
+    public void testBuildListOfStringStringBoolean_EmptyTopic() {
+        buildTopic(servers, "", true);
+    }
+
+    @Test
+    public void testBuildProperties() {
+        // managed topic
+        initFactory();
+        assertEquals(1, buildTopics(makePropBuilder().makeTopic(MY_TOPIC).build()).size());
+        assertNotNull(factory.get(MY_TOPIC));
+
+        // unmanaged topic - get() will throw an exception
+        initFactory();
+        assertEquals(1, buildTopics(makePropBuilder().makeTopic(MY_TOPIC)
+                        .setTopicProperty(PROPERTY_MANAGED_SUFFIX, "false").build()).size());
+        assertThatThrownBy(() -> factory.get(MY_TOPIC));
+
+        // managed undefined - default to true
+        initFactory();
+        assertEquals(1, buildTopics(
+                        makePropBuilder().makeTopic(MY_TOPIC).removeTopicProperty(PROPERTY_MANAGED_SUFFIX).build())
+                                        .size());
+        assertNotNull(factory.get(MY_TOPIC));
+
+        // managed empty - default to true
+        initFactory();
+        assertEquals(1, buildTopics(
+                        makePropBuilder().makeTopic(MY_TOPIC).setTopicProperty(PROPERTY_MANAGED_SUFFIX, "").build())
+                                        .size());
+        assertNotNull(factory.get(MY_TOPIC));
+
+        initFactory();
+
+        // null topic list
+        assertTrue(buildTopics(makePropBuilder().build()).isEmpty());
+
+        // empty topic list
+        assertTrue(buildTopics(makePropBuilder().addTopic("").build()).isEmpty());
+
+        // null server list
+        initFactory();
+        T endpoint = buildTopics(makePropBuilder().makeTopic(MY_TOPIC)
+                        .removeTopicProperty(PROPERTY_TOPIC_SERVERS_SUFFIX).build()).get(0);
+        assertEquals(NOOP_SERVERS, endpoint.getServers());
+
+        // empty server list
+        initFactory();
+        endpoint = buildTopics(makePropBuilder().makeTopic(MY_TOPIC).setTopicProperty(PROPERTY_TOPIC_SERVERS_SUFFIX, "")
+                        .build()).get(0);
+        assertEquals(NOOP_SERVERS, endpoint.getServers());
+
+        // test other options
+        super.testBuildProperties_Multiple();
+    }
+
+    @Test
+    public void testDestroyString_testGet_testInventory() {
+        super.testDestroyString_testGet_testInventory();
+        super.testDestroyString_Ex();
+    }
+
+    @Test
+    public void testDestroy() {
+        super.testDestroy();
+    }
+
+    @Test
+    public void testGet() {
+        super.testGet_Ex();
+    }
+
+    @Override
+    protected void initFactory() {
+        if (factory != null) {
+            factory.destroy();
+        }
+
+        factory = buildFactory();
+    }
+
+    @Override
+    protected List<T> buildTopics(Properties properties) {
+        return factory.build(properties);
+    }
+
+    protected T buildTopic(List<String> servers, String topic, boolean managed) {
+        return factory.build(servers, topic, managed);
+    }
+
+    @Override
+    protected void destroyFactory() {
+        factory.destroy();
+    }
+
+    @Override
+    protected void destroyTopic(String topic) {
+        factory.destroy(topic);
+    }
+
+    @Override
+    protected List<T> getInventory() {
+        return factory.inventory();
+    }
+
+    @Override
+    protected T getTopic(String topic) {
+        return factory.get(topic);
+    }
+
+    @Override
+    protected TopicPropertyBuilder makePropBuilder() {
+        return new NoopTopicPropertyBuilder(factory.getTopicsPropertyName());
+    }
+}