Use builder for http and jersey client

Sonar issue with more than 7 params in a method. Use builder object
instead of params. Rework2 for fixing review comments.
Add modifications copyright

Issue-ID: POLICY-1017
Change-Id: Ib0fa692f8da770dcba06158d6e6cafbed2969c27
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>

1 files changed, 9 insertions, 8 deletions

diff --git a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusPublisher.java b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusPublisher.java
index 2d1d8257..aaf0cfb5 100644
--- a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusPublisher.java
+++ b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusPublisher.java
@@ -3,7 +3,7 @@
  * policy-endpoints
  * ================================================================================
  * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved.
- * Modified Copyright (C) 2018 Samsung Electronics Co., Ltd.
+ * Modifications Copyright (C) 2018 Samsung Electronics Co., Ltd.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -38,6 +38,7 @@ import java.util.Map;
 import java.util.Properties;
 import java.util.concurrent.TimeUnit;
 
+import org.apache.commons.lang3.StringUtils;
 import org.onap.policy.common.endpoints.event.comm.bus.DmaapTopicSinkFactory;
 import org.onap.policy.common.endpoints.properties.PolicyEndPointProperties;
 import org.slf4j.Logger;
@@ -176,7 +177,7 @@ public interface BusPublisher {
                 String username, String password, boolean useHttps) {
 
 
-            if (topic == null || topic.isEmpty()) {
+            if (StringUtils.isBlank(topic)) {
                 throw new IllegalArgumentException("No topic for DMaaP");
             }
 
@@ -313,25 +314,25 @@ public interface BusPublisher {
                         DmaapTopicSinkFactory.DME2_ROUTE_OFFER_PROPERTY);
             }
 
-            if (busTopicParams.isEnvironmentNullOrEmpty()) {
+            if (busTopicParams.isEnvironmentInvalid()) {
                 throw parmException(busTopicParams.getTopic(),
                         PolicyEndPointProperties.PROPERTY_DMAAP_DME2_ENVIRONMENT_SUFFIX);
             }
-            if (busTopicParams.isAftEnvironmentNullOrEmpty()) {
+            if (busTopicParams.isAftEnvironmentInvalid()) {
                 throw parmException(busTopicParams.getTopic(),
                         PolicyEndPointProperties.PROPERTY_DMAAP_DME2_AFT_ENVIRONMENT_SUFFIX);
             }
-            if (busTopicParams.isLatitudeNullOrEmpty()) {
+            if (busTopicParams.isLatitudeInvalid()) {
                 throw parmException(busTopicParams.getTopic(),
                         PolicyEndPointProperties.PROPERTY_DMAAP_DME2_LATITUDE_SUFFIX);
             }
-            if (busTopicParams.isLongitudeNullOrEmpty()) {
+            if (busTopicParams.isLongitudeInvalid()) {
                 throw parmException(busTopicParams.getTopic(),
                         PolicyEndPointProperties.PROPERTY_DMAAP_DME2_LONGITUDE_SUFFIX);
             }
 
-            if ((busTopicParams.isPartnerNullOrEmpty())
-                    && (dme2RouteOffer == null || dme2RouteOffer.trim().isEmpty())) {
+            if ((busTopicParams.isPartnerInvalid())
+                    && StringUtils.isBlank(dme2RouteOffer)) {
                 throw new IllegalArgumentException(
                         "Must provide at least " + PolicyEndPointProperties.PROPERTY_DMAAP_SOURCE_TOPICS + "."
                                 + busTopicParams.getTopic()