More sonar issues cleanup

Either log or rethrow
Use boolean expression
Add at least one test
Remove commented out code

Issue-ID: POLICY-2204
Change-Id: I4fdf31aea75303e4f49d25198eb3b12341995bfe
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

1 files changed, 0 insertions, 2 deletions

diff --git a/integrity-monitor/src/main/java/org/onap/policy/common/im/StateManagement.java b/integrity-monitor/src/main/java/org/onap/policy/common/im/StateManagement.java
index 7a018ef9..65ebf2d2 100644
--- a/integrity-monitor/src/main/java/org/onap/policy/common/im/StateManagement.java
+++ b/integrity-monitor/src/main/java/org/onap/policy/common/im/StateManagement.java
@@ -174,7 +174,6 @@ public class StateManagement {
                 logger.debug("StateManagement: {}() operation completed, resourceName = {}",
                                 methodName, resourceName);
             } catch (final Exception ex) {
-                logger.error("StateManagement.{}() caught unexpected exception: ", methodName, ex);
                 throw new StateManagementException("StateManagement." + methodName + "() Exception: " + ex);
             }
         }
@@ -476,7 +475,6 @@ public class StateManagement {
             }
         } catch (final Exception ex) {
             final String message = "findStateManagementEntity exception";
-            logger.error("{}: {}", message, ex.toString(), ex);
             throw new EntityRetrievalException(message, ex);
         }
     }