diff options
author | liamfallon <liam.fallon@ericsson.com> | 2018-08-03 13:33:44 +0100 |
---|---|---|
committer | liamfallon <liam.fallon@ericsson.com> | 2018-08-03 13:34:02 +0100 |
commit | 33eb63bbb70140630ecefae9d92c2c8f7d23fc63 (patch) | |
tree | c8b68e21cb6e3fd0eb65032fa4bce10424094757 /common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses | |
parent | 6d662cb19aa858b743ab7e01d02a2a173abebcad (diff) |
Fix pom and checkstyle warnings in common
Some dependency versions are now managed in the master POM
Checkstyle showed up some warnings in paramters and capabilities.
Change-Id: Ifebd8a076bdb3fda626b5b1fda9324801bf58643
Issue-ID: POLICY-716
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Diffstat (limited to 'common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses')
11 files changed, 21 insertions, 17 deletions
diff --git a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/EmptyParameterGroup.java b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/EmptyParameterGroup.java index f545ce65..681eb693 100644 --- a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/EmptyParameterGroup.java +++ b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/EmptyParameterGroup.java @@ -20,8 +20,8 @@ package org.onap.policy.common.parameters.testclasses; -import org.onap.policy.common.parameters.ParameterGroup; import org.onap.policy.common.parameters.GroupValidationResult; +import org.onap.policy.common.parameters.ParameterGroup; public class EmptyParameterGroup implements ParameterGroup { private String name; diff --git a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithArray.java b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithArray.java index cdab1272..fcb2bb1b 100644 --- a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithArray.java +++ b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithArray.java @@ -20,8 +20,8 @@ package org.onap.policy.common.parameters.testclasses; -import org.onap.policy.common.parameters.ParameterGroup; import org.onap.policy.common.parameters.GroupValidationResult; +import org.onap.policy.common.parameters.ParameterGroup; public class ParameterGroupWithArray implements ParameterGroup { private String name; diff --git a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithCollection.java b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithCollection.java index 0f993099..75ae45b8 100644 --- a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithCollection.java +++ b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithCollection.java @@ -23,8 +23,8 @@ package org.onap.policy.common.parameters.testclasses; import java.util.ArrayList; import java.util.List; -import org.onap.policy.common.parameters.ParameterGroup; import org.onap.policy.common.parameters.GroupValidationResult; +import org.onap.policy.common.parameters.ParameterGroup; public class ParameterGroupWithCollection implements ParameterGroup { private String name; @@ -32,11 +32,12 @@ public class ParameterGroupWithCollection implements ParameterGroup { /** * Create a test parameter group. + * * @param name the parameter group name */ public ParameterGroupWithCollection(final String name) { this.name = name; - + intArrayList.add(1); intArrayList.add(2); intArrayList.add(3); @@ -45,12 +46,12 @@ public class ParameterGroupWithCollection implements ParameterGroup { public List<Integer> getIntArrayList() { return intArrayList; } - + @Override public String getName() { return name; } - + @Override public GroupValidationResult validate() { return new GroupValidationResult(this); diff --git a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithIllegalMapKey.java b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithIllegalMapKey.java index 3de3270e..ca441060 100644 --- a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithIllegalMapKey.java +++ b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithIllegalMapKey.java @@ -23,8 +23,8 @@ package org.onap.policy.common.parameters.testclasses; import java.util.LinkedHashMap; import java.util.Map; -import org.onap.policy.common.parameters.ParameterGroup; import org.onap.policy.common.parameters.GroupValidationResult; +import org.onap.policy.common.parameters.ParameterGroup; public class ParameterGroupWithIllegalMapKey implements ParameterGroup { private String name; diff --git a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithIllegalMapValue.java b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithIllegalMapValue.java index 8eb697a4..9253f158 100644 --- a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithIllegalMapValue.java +++ b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithIllegalMapValue.java @@ -23,8 +23,8 @@ package org.onap.policy.common.parameters.testclasses; import java.util.LinkedHashMap; import java.util.Map; -import org.onap.policy.common.parameters.ParameterGroup; import org.onap.policy.common.parameters.GroupValidationResult; +import org.onap.policy.common.parameters.ParameterGroup; public class ParameterGroupWithIllegalMapValue implements ParameterGroup { private String name; diff --git a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithNullCollection.java b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithNullCollection.java index 37399da3..0d113dc6 100644 --- a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithNullCollection.java +++ b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithNullCollection.java @@ -22,8 +22,8 @@ package org.onap.policy.common.parameters.testclasses; import java.util.List; -import org.onap.policy.common.parameters.ParameterGroup; import org.onap.policy.common.parameters.GroupValidationResult; +import org.onap.policy.common.parameters.ParameterGroup; public class ParameterGroupWithNullCollection implements ParameterGroup { private String name; diff --git a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithNullMapValue.java b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithNullMapValue.java index 80f55355..9e1601c3 100644 --- a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithNullMapValue.java +++ b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithNullMapValue.java @@ -22,8 +22,8 @@ package org.onap.policy.common.parameters.testclasses; import java.util.Map; -import org.onap.policy.common.parameters.ParameterGroup; import org.onap.policy.common.parameters.GroupValidationResult; +import org.onap.policy.common.parameters.ParameterGroup; public class ParameterGroupWithNullMapValue implements ParameterGroup { private String name; diff --git a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithParameterGroupCollection.java b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithParameterGroupCollection.java index e7d1de75..5ece07b4 100644 --- a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithParameterGroupCollection.java +++ b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/ParameterGroupWithParameterGroupCollection.java @@ -23,8 +23,8 @@ package org.onap.policy.common.parameters.testclasses; import java.util.ArrayList; import java.util.List; -import org.onap.policy.common.parameters.ParameterGroup; import org.onap.policy.common.parameters.GroupValidationResult; +import org.onap.policy.common.parameters.ParameterGroup; public class ParameterGroupWithParameterGroupCollection implements ParameterGroup { private String name; diff --git a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersL00.java b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersL00.java index 6b8460cd..6cd65603 100644 --- a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersL00.java +++ b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersL00.java @@ -24,9 +24,9 @@ import java.util.LinkedHashMap; import java.util.Map; import java.util.Map.Entry; -import org.onap.policy.common.parameters.ParameterGroup; import org.onap.policy.common.parameters.GroupValidationResult; import org.onap.policy.common.parameters.ParameterConstants; +import org.onap.policy.common.parameters.ParameterGroup; import org.onap.policy.common.parameters.ValidationStatus; public class TestParametersL00 implements ParameterGroup { @@ -38,9 +38,10 @@ public class TestParametersL00 implements ParameterGroup { private Map<String, TestParametersLGeneric> l00LGenericNestedMap = new LinkedHashMap<>(); /** - * Default constructor + * Default constructor. */ public TestParametersL00() { + // Default Cnstructor } /** diff --git a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersL10.java b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersL10.java index 94a67ec7..6efddac0 100644 --- a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersL10.java +++ b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersL10.java @@ -24,9 +24,9 @@ import java.util.LinkedHashMap; import java.util.Map; import java.util.Map.Entry; -import org.onap.policy.common.parameters.ParameterGroup; import org.onap.policy.common.parameters.GroupValidationResult; import org.onap.policy.common.parameters.ParameterConstants; +import org.onap.policy.common.parameters.ParameterGroup; import org.onap.policy.common.parameters.ValidationStatus; public class TestParametersL10 implements ParameterGroup { @@ -38,9 +38,10 @@ public class TestParametersL10 implements ParameterGroup { private Map<String, TestParametersLGeneric> l10LGenericNestedMap = new LinkedHashMap<>(); /** - * Default constructor + * Default constructor. */ public TestParametersL10() { + // Default Constructor } /** diff --git a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersLGeneric.java b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersLGeneric.java index ce368bac..2e678da0 100644 --- a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersLGeneric.java +++ b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersLGeneric.java @@ -20,9 +20,9 @@ package org.onap.policy.common.parameters.testclasses; -import org.onap.policy.common.parameters.ParameterGroup; import org.onap.policy.common.parameters.GroupValidationResult; import org.onap.policy.common.parameters.ParameterConstants; +import org.onap.policy.common.parameters.ParameterGroup; import org.onap.policy.common.parameters.ValidationStatus; public class TestParametersLGeneric implements ParameterGroup { @@ -31,9 +31,10 @@ public class TestParametersLGeneric implements ParameterGroup { private String lgenericStringField = "Legal " + this.getClass().getCanonicalName(); /** - * Default constructor + * Default constructor. */ public TestParametersLGeneric() { + // Default Constructor } /** |