Remove GroupValidationResult

Removed GroupValidationResult, replacing it with BeanValidationResult.
Modified the ParameterGroup subclasses to use BeanValidator, adding
annotations where needed to trigger the validations that had been
automatically performed by GroupValidationResult.
Added Size annotation, used to verify minimum lengths of maps and
collections.
Added ClassName annotation, used to verify that a property contains the
name of a class that is actually in the classpath.
Added another addResult() method to make it easier when replacing calls
to GroupValidationResult setResult() method with BeanValidationResult.

Issue-ID: POLICY-2059
Change-Id: Id4da24886908723006624c5d53edeb034102299d
Signed-off-by: Jim Hahn <jrh3@att.com>

1 files changed, 0 insertions, 129 deletions

diff --git a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersLGeneric.java b/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersLGeneric.java
deleted file mode 100644
index f9d6cdc4..00000000
--- a/common-parameters/src/test/java/org/onap/policy/common/parameters/testclasses/TestParametersLGeneric.java
+++ /dev/null
@@ -1,129 +0,0 @@
-/*
- * ============LICENSE_START=======================================================
- *  Copyright (C) 2018 Ericsson. All rights reserved.
- *  Modifications Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
- * ================================================================================
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- * SPDX-License-Identifier: Apache-2.0
- * ============LICENSE_END=========================================================
- */
-
-package org.onap.policy.common.parameters.testclasses;
-
-import org.onap.policy.common.parameters.GroupValidationResult;
-import org.onap.policy.common.parameters.ParameterGroupImpl;
-import org.onap.policy.common.parameters.ValidationStatus;
-import org.onap.policy.common.parameters.annotations.NotBlank;
-import org.onap.policy.common.parameters.annotations.NotNull;
-
-public class TestParametersLGeneric extends ParameterGroupImpl {
-    private static final String LGENERIC_INT_FIELD = "lgenericIntField";
-    private static final String LGENERIC_STRING_FIELD = "lgenericStringField";
-
-    private int lgenericIntField = 0;
-
-    @NotNull @NotBlank
-    private String lgenericStringField = "Legal " + this.getClass().getName();
-
-    /**
-     * Default constructor.
-     */
-    public TestParametersLGeneric() {
-        // Default Constructor
-    }
-
-    /**
-     * Create a test parameter group.
-     *
-     * @param name the parameter group name
-     */
-    public TestParametersLGeneric(final String name) {
-        super(name);
-    }
-
-    public int getLgenericIntField() {
-        return lgenericIntField;
-    }
-
-    public String getLgenericStringField() {
-        return lgenericStringField;
-    }
-
-    public void setLgenericIntField(int lgenericIntField) {
-        this.lgenericIntField = lgenericIntField;
-    }
-
-    public void setLgenericStringField(String lgenericStringField) {
-        this.lgenericStringField = lgenericStringField;
-    }
-
-    /**
-     * Trigger a validation message.
-     *
-     * @param level Number of levels to recurse before stopping
-     */
-    public void triggerValidationStatus(final ValidationStatus triggerStatus, int level) {
-        if (level == 0) {
-            return;
-        }
-
-        switch (triggerStatus) {
-            case CLEAN:
-                lgenericStringField = "Legal " + this.getClass().getName();
-                lgenericIntField = 0;
-                break;
-            case OBSERVATION:
-                lgenericStringField = "aString";
-                lgenericIntField = 2;
-                break;
-            case WARNING:
-                lgenericStringField = LGENERIC_STRING_FIELD;
-                lgenericIntField = 3;
-                break;
-            case INVALID:
-                lgenericStringField = "";
-                lgenericIntField = -1;
-                break;
-            default:
-                break;
-        }
-
-    }
-
-    @Override
-    public GroupValidationResult validate() {
-        GroupValidationResult validationResult = super.validate();
-
-        if (LGENERIC_STRING_FIELD.equals(lgenericStringField)) {
-            validationResult.setResult(LGENERIC_STRING_FIELD, ValidationStatus.WARNING,
-                            "using the field name for the parameter value is dangerous");
-        } else if ("aString".equals(lgenericStringField)) {
-            validationResult.setResult(LGENERIC_STRING_FIELD, ValidationStatus.OBSERVATION,
-                            "this value for name is unhelpful");
-        }
-
-        if (lgenericIntField < 0) {
-            validationResult.setResult(LGENERIC_INT_FIELD, ValidationStatus.INVALID,
-                            "lgenericIntField must be a positive integer");
-        } else if (lgenericIntField > 2) {
-            validationResult.setResult(LGENERIC_INT_FIELD, ValidationStatus.WARNING,
-                            "values greater than 2 are not recommended");
-        } else if (lgenericIntField == 2) {
-            validationResult.setResult(LGENERIC_INT_FIELD, ValidationStatus.OBSERVATION,
-                            "this field has been set to 2");
-        }
-
-        return validationResult;
-    }
-}