diff options
author | Jim Hahn <jrh3@att.com> | 2020-04-06 12:17:11 -0400 |
---|---|---|
committer | Jim Hahn <jrh3@att.com> | 2020-04-06 13:00:04 -0400 |
commit | 9f9131575d2e2b1002a3e108f7793a97fa7652ab (patch) | |
tree | 68400e6ac1fb32f01f8338803a7d72bdb41215b1 /common-logging/src/test/java/org/onap/policy/common/logging/eelf/PolicyLoggerTest.java | |
parent | a56d3929f2387252525577fb36f9e03933064b8f (diff) |
Address sonar issues in ONAP-logging
Addressed the following sonar issues in ONAP-logging:
- use Map instead of ConcurrentHashMap
- remove unusued fields
- use Map.computeIfAbsent() instead of get()/put() pair
- readObject is unsafe
- use try-with-resources
- junit should assert something
Also removed some unused imports.
Issue-ID: POLICY-2305
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I3480a55da4d0e771f8083c97770a6c9707d871f7
Signed-off-by: Jim Hahn <jrh3@att.com>
Diffstat (limited to 'common-logging/src/test/java/org/onap/policy/common/logging/eelf/PolicyLoggerTest.java')
-rw-r--r-- | common-logging/src/test/java/org/onap/policy/common/logging/eelf/PolicyLoggerTest.java | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/common-logging/src/test/java/org/onap/policy/common/logging/eelf/PolicyLoggerTest.java b/common-logging/src/test/java/org/onap/policy/common/logging/eelf/PolicyLoggerTest.java index 6af3632a..db4eb786 100644 --- a/common-logging/src/test/java/org/onap/policy/common/logging/eelf/PolicyLoggerTest.java +++ b/common-logging/src/test/java/org/onap/policy/common/logging/eelf/PolicyLoggerTest.java @@ -30,6 +30,7 @@ import static com.att.eelf.configuration.Configuration.MDC_SERVER_FQDN; import static com.att.eelf.configuration.Configuration.MDC_SERVER_IP_ADDRESS; import static com.att.eelf.configuration.Configuration.MDC_SERVICE_INSTANCE_ID; import static com.att.eelf.configuration.Configuration.MDC_SERVICE_NAME; +import static org.assertj.core.api.Assertions.assertThatCode; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; @@ -613,7 +614,7 @@ public class PolicyLoggerTest { @Test public void testInitNullProperties() { - PolicyLogger.init(null); + assertThatCode(() -> PolicyLogger.init(null)).doesNotThrowAnyException(); } @Test @@ -630,7 +631,7 @@ public class PolicyLoggerTest { properties.setProperty("stop.check.point", "0"); properties.setProperty("logger.property", "LOG4J"); - PolicyLogger.init(properties); + assertThatCode(() -> PolicyLogger.init(properties)).doesNotThrowAnyException(); } @Test |