Cleanup various sonar issues in policy-common

Addressed the following issues:
- unused imports
- unused method parameters
- use assertEquals, assertSame instead of assertTrue
- provide the parametrized type for this generic

Also fixed some checkstyle issues:
- removed blank lines between "import" groups

Issue-ID: POLICY-2650
Change-Id: I004bb650ac10c49ccd0fc405f6959896fec39f9b
Signed-off-by: Jim Hahn <jrh3@att.com>

1 files changed, 2 insertions, 6 deletions

diff --git a/common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/FlexLogger.java b/common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/FlexLogger.java
index 62459bcc..eb6daee9 100644
--- a/common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/FlexLogger.java
+++ b/common-logging/src/main/java/org/onap/policy/common/logging/flexlogger/FlexLogger.java
@@ -29,7 +29,6 @@ import java.util.Date;
 import java.util.Properties;
 import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
-
 import org.onap.policy.common.logging.eelf.PolicyLogger;
 import org.onap.policy.common.logging.flexlogger.PropertyUtil.Listener;
 
@@ -73,10 +72,8 @@ public class FlexLogger extends SecurityManager {
 
     /**
      * Returns an instance of Logger.
-     *
-     * @param name the name of the logger
      */
-    public static Logger getLogger(String name) {
+    public static Logger getLogger() {
         Logger logger = null;
         displayMessage(GET_LOGGER_PREFIX + loggerType);
         switch (loggerType) {
@@ -121,10 +118,9 @@ public class FlexLogger extends SecurityManager {
     /**
      * Returns an instance of Logger.
      *
-     * @param name the name of the logger
      * @param isNewTransaction is a new transaction
      */
-    public static Logger getLogger(String name, boolean isNewTransaction) {
+    public static Logger getLogger(boolean isNewTransaction) {
         Logger logger = null;
         displayMessage(GET_LOGGER_PREFIX + loggerType);
         switch (loggerType) {