diff options
author | Joanna Jeremicz <joanna.jeremicz@nokia.com> | 2021-02-25 15:24:34 +0100 |
---|---|---|
committer | Joanna Jeremicz <joanna.jeremicz@nokia.com> | 2021-03-02 12:53:02 +0100 |
commit | 72c2d38329865afa6692454b4fb90ab6f8a70638 (patch) | |
tree | 3aaaddd2d37fee4e2fa41a8c790a6f3ae975ec35 /mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/InfoService.java | |
parent | 87f19cde0f6532f5138822fa6f188b763a123235 (diff) |
Fix sonar issues
- Use Map instead of LinkedHashMap when possible
- Rename some constants
- Remove some commented lines
- Add logger
- Other minor improvements and refactor
Issue-ID: DCAEGEN2-2636
Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
Change-Id: I7a03cee453b3d254c4ff0fdf51c60a0ae4a61c42
Diffstat (limited to 'mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/InfoService.java')
-rw-r--r-- | mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/InfoService.java | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/InfoService.java b/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/InfoService.java index 66f71da..70ba504 100644 --- a/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/InfoService.java +++ b/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/InfoService.java @@ -4,6 +4,7 @@ * * org.onap.dcae * * ================================================================================ * * Copyright (c) 2020 AT&T Intellectual Property. All rights reserved. + * * Copyright (c) 2021 Nokia. All rights reserved. * * ================================================================================ * * Licensed under the Apache License, Version 2.0 (the "License"); * * you may not use this file except in compliance with the License. @@ -53,12 +54,12 @@ public class InfoService { * @return */ public Map<String, Object> createMessageRouterInfo( - Map<String, LinkedHashMap<String, Object>> inputs, String config, char type) { + Map<String, Map<String, Object>> inputs, String config, char type) { Map<String, Object> response = new HashMap<>(); Info info = new Info(); - LinkedHashMap<String, Object> stringType = new LinkedHashMap<>(); + Map<String, Object> stringType = new LinkedHashMap<>(); stringType.put("type", "string"); config = config.replaceAll("-", "_"); @@ -87,12 +88,12 @@ public class InfoService { * @return */ public Map<String, Object> createDataRouterInfo( - Map<String, LinkedHashMap<String, Object>> inputs, String config) { + Map<String, Map<String, Object>> inputs, String config) { Map<String, Object> response = new HashMap<>(); Info info = new Info(); - LinkedHashMap<String, Object> stringType = new LinkedHashMap<>(); + Map<String, Object> stringType = new LinkedHashMap<>(); stringType.put("type", "string"); String userNameInputName = blueprintHelperService.joinUnderscore(config, "username"); |