From 72c2d38329865afa6692454b4fb90ab6f8a70638 Mon Sep 17 00:00:00 2001 From: Joanna Jeremicz Date: Thu, 25 Feb 2021 15:24:34 +0100 Subject: Fix sonar issues - Use Map instead of LinkedHashMap when possible - Rename some constants - Remove some commented lines - Add logger - Other minor improvements and refactor Issue-ID: DCAEGEN2-2636 Signed-off-by: Joanna Jeremicz Change-Id: I7a03cee453b3d254c4ff0fdf51c60a0ae4a61c42 --- .../java/org/onap/blueprintgenerator/service/InfoService.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/InfoService.java') diff --git a/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/InfoService.java b/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/InfoService.java index 66f71da..70ba504 100644 --- a/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/InfoService.java +++ b/mod/bpgenerator/onap/src/main/java/org/onap/blueprintgenerator/service/InfoService.java @@ -4,6 +4,7 @@ * * org.onap.dcae * * ================================================================================ * * Copyright (c) 2020 AT&T Intellectual Property. All rights reserved. + * * Copyright (c) 2021 Nokia. All rights reserved. * * ================================================================================ * * Licensed under the Apache License, Version 2.0 (the "License"); * * you may not use this file except in compliance with the License. @@ -53,12 +54,12 @@ public class InfoService { * @return */ public Map createMessageRouterInfo( - Map> inputs, String config, char type) { + Map> inputs, String config, char type) { Map response = new HashMap<>(); Info info = new Info(); - LinkedHashMap stringType = new LinkedHashMap<>(); + Map stringType = new LinkedHashMap<>(); stringType.put("type", "string"); config = config.replaceAll("-", "_"); @@ -87,12 +88,12 @@ public class InfoService { * @return */ public Map createDataRouterInfo( - Map> inputs, String config) { + Map> inputs, String config) { Map response = new HashMap<>(); Info info = new Info(); - LinkedHashMap stringType = new LinkedHashMap<>(); + Map stringType = new LinkedHashMap<>(); stringType.put("type", "string"); String userNameInputName = blueprintHelperService.joinUnderscore(config, "username"); -- cgit 1.2.3-korg