Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
Issue-ID: CPS-2370
Change-Id: I0ca3a1df232ad9fd9f76695cd6ea21d36919130d
Signed-off-by: seanbeirne <sean.beirne@est.tech>
|
|
- added support for alternate id when retreiving cmhandle details by id
- Note : The performance for alternate id fetching will be taken care as
part of a separate story.
Issue-ID: CPS-2385
Change-Id: I019b85d128e4b0a1f1d61623c92e1a2381c406c0
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
|
|
Issue-ID: CPS-2379
Change-Id: Idd180c5792575522ceaaa094b94c8f5b36790186
Signed-off-by: seanbeirne <sean.beirne@est.tech>
|
|
- added alternate id support for the existing endpoint
- Incorporated previous comments on the indendation
- Added new component cmHandleReferenceInPath in openapi docs to depict
the correct example
Issue-ID: CPS-2378
Change-Id: I63e752fbb6cb0bde49d1ced53f063743d904d74e
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
|
|
Current trust level should factor in both CM-handle
and DMI trust levels (effective trust level).
Issue-ID: CPS-2375
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ib531633a0e79af2bf9cf73d2b0b02d7a58777458
|
|
|
|
- Execute Policy Executor REST request
- Act (and log) on response from Policy Executor
- Add dispatcher(mock) in integration test FWK
- Add integration test for allow/non allowed and no authorization use cases
- disabled PolicyExecution feature by default (only enabled for testware)
Issue-ID: CPS-2247
Change-Id: I111ba9ba89cc91649b63b20f88414aa33721dbeb
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
|
|
- Added support for alternate id for the composite state API for
CPS-E05#15
Issue-ID: CPS-2377
Change-Id: I1af41efb8cec762be68250cae7c1e98fbc61a4f5
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
|
|
- handle removal of device trust levels from the cache when
cm handles deleted
- handle initial dmi registration inside trust level manager
Issue-ID: CPS-2315
Change-Id: I605ed78f164d7534069de8352dc3b0a81a4ce22c
Signed-off-by: halil.cakal <halil.cakal@est.tech>
|
|
This reverts commit 77b8e25e14e698c853334ef57459c21d7813911a.
Reason for revert: Performance degredation
Change-Id: Ibd88e626189d821680568c63952b95e7d1e05dc4
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
|
|
- handle removal of device trust levels from the cache when
cm handles deleted
- handle initial dmi registration inside trust level manager
- add get effective trust level function to trust level manager
for get and query cm handle APIs (to set trust level on the return
object)
Issue-ID: CPS-2315
Change-Id: I8daa4a2ad8310de10e35fdc50351deb85fd3ffd0
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Signed-off-by: halil.cakal <halil.cakal@est.tech>
|
|
- added DataJobResult interface
- extended the DmiRestClient to retrieve status
- added mock response to DmiDispatcher
Issue-ID: CPS-2296
Change-Id: I551afd827cccd91c5f9837bd4923b30320865d55
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
|
|
|
|
-modified writejob & status endpoints
Issue-ID: CPS-2360
Change-Id: I87647f59493886593825f5175c6ed708e55b3e30
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
|
|
- Supports Alternate Ids for getResourceDataForCmHandle
Issue-Id: CPS-2279
Change-Id: I1f145308cec5b545fab2d5c96efbc00fc3a110f4
Signed-off-by: seanbeirne <sean.beirne@est.tech>
|
|
|
|
- added auth header to the interface & updated testware
Issue-ID: CPS-2330
Change-Id: I091fc5c3c3fa323024f55055129cc7240732479a
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
|
|
- added java interface
- extended DmiRestClient to get data job status
- added testware
Issue-ID: CPS-2296
Change-Id: If9006bba06397724c15bdc3bdf1bd52a0188f002
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
|
|
- added Stub controller
- created integration test for writeDataJob
Issue-ID: CPS-2236
Change-Id: I067a11dc5bfe629d50128cf303b2a81abc75a348
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
|
|
-Introduced org.onap.cps.ncmp.config for all config type classes like http, kafka etc.
-Introduced org.onap.cps.ncmp.impl.dmi for dmi specif classes like DmiRestClient etc.
-Moved most exception classes to org.onap.cps.ncmp.api.exceptions
(only two were 'internal' i.e. NOT used in REST so left in org.onap.cps.ncmp.exceptions)
-Deleted unused DateNodeHelper class (and related testware)
-Moved some classes to org.onap.cps.ncmp.impl.utils
-Moved messaging test base classes to org.onap.cps.ncmp.impl.utils.events
-All imports were reorganised automatically by IntelliJ
-did NOT update any copyright dates (seems incorrect to me anyway)
Issue-ID: CPS-2257
Change-Id: Ie28b1777ea278064b46c6a1c3a28f4d0696565e2
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
|
|
- Moved cmsubscription to the impl package instead of api.
- Below packages are renamed or newly created for code and tests
- moved ..api.cmsubsription to ..impl.cmsubscription
- renamed ..api.cmsubscription.mappers to ..impl.cmsubscription.ncmp
or dmi as per the functionality
- renamed ..api.cmsubscription.model to ..impl.cmsubscription.models
- removed ..api.cmsubscription.producer/consumer and classes moved to ..impl.cmsubscription.ncmp/dmi
- new package ..impl.cmsubscription.cache to hold cache config and
cache operations
- new package ..impl.cmsubscription.avc to hold the CmAvcEventConsumer
for the notifications emitted as a result of the subscriptions
- Removed the prefix CmNotificationSubscription for majority of the classes , not removed for Config and model classes
- Renamed the schemas and package structure as per the code refactoring
Note: *EventsFacade and *MappersFacade to be removed in the next
patchset
Issue-ID: CPS-2298
Change-Id: I1d788ab745d65965570e28beaefa511cbe4a8547
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
|
|
- Used autoconfigured web client builder for http_client_requests_* prometheus metrics.
- Refactored dmi service url builder to create url template and its
variables.
- Web client is modified to use uri(urlTemplate, urlvars) version.
- Deleted InvalidDmiResourceUrlException that no longer needed.
- Used DmiServiceUrlBuilder to build dmi health check service url.
- Created a new pkg url.builder into utils to have all related classes
and record.
Issue-ID: CPS-2121
Change-Id: Id67e0f0d4e640bb8f9eea0b6c2db1dba3468e1d7
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
|
|
- MOve to API package
- Handle in REST Controller to return BAD REQUEST
Issue-ID: CPS-2256
Change-Id: I4f96519aaf2e7f781729c8b8671ea02630a2e0a8
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
|
|
- moved relevant classes into these (new) packages:
api.data.exceptions
api.data.models
impl.data
impl.data.async
impl.data.exceptions
impl.data.models
impl.data.utils
utils.events
- removed old unused event class
- moves some missed inventory related class to the right place
Issue-ID: CPS-2256
Change-Id: I75563e063acc0054769d8f2b13146e6c1d1c6054
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
|
|
-moved api.impl.events.lcm to impl.inventory.sync.lcm
-moved most api.impl.events class to utils.events
(remaining classes in api.impl.events belong to cmsubscrption and Priyank wil take care of those)
Issue-ID: CPS-2258
Change-Id: I1818194e708aa0d9c713b470e878997c2f26fb13
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
|
|
-Moved TrustLevel impl from Controller to Inventory Facade
-Applied new package name convention using impl\inventory\trustlevel for this (sub)feature
-Renamed some trustlevel related classes to better describe their role
-Disabled failing architecture test (agreed this is tech. debt and created CPS-2293)
-Refactored YangDataConverter method names and signatures (moved Spec to correct place)
-Cleaned up names and javadoc of class now called DeviceTrustLevelMessageConsumer
-Applied conventions to modified test methods
Issue-ID: CPS-2255
Change-Id: Iccd20541488e6b61444bb2c7406c90e61a34124d
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
|
|
- decided that cm handle queries is part of 'inventory' feature
- a lot of files (~100 total) have changes because of some files have been moved.
- The reviewers should probably just focus on the MOVED/renamed (~30) files
- New packages (top level only):
-- org.onap.cps.ncmp.api.inventory
-- org.onap.cps.ncmp.impl.inventory
-- org.onap.cps.ncmp.impl.models (common models NOT used in API, this was unforeseen)
-- org.onap.cps.ncmp.impl.utils
- I am NOT updating copyright years as part of this commit since there are no real code changes and it is simply NOT worth the effort
TODO:
- extend scope to 'TrustLevel' as an 'internal feature' (TBD)
Issue-ID: CPS-2255
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I40b4efc8326068ab9ae1f31b77f46b2fe8579431
|
|
|
|
|
|
- NetworkCmProxyDataService was polluted with many non-data operations
- it is now split into:
1) NetworkCmProxyFacade, a single thin facade for the (main) controler to redirect calls to the correct services
2) CmHandleRegistrationService(Impl), methods related to registration only
- introduced NetworkCmProxyInventoryFacade for the invenoty controller
- renamed some services for consitency and clarification
- Use facade to acces ncmp data request handlers (instead of direct from controller)
- remove unnecesarry wrappings between request handlers and facade
- split facades according to names: data & inventory
(the REST controllers are not split properly so I think one rest controller will end up needing both facades)
Issue-ID: CPS-2263
Change-Id: I250732aa16ec28b43ff642d2adf10ba36f67290e
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
|
|
- algorithm for create sub-job requests
- added new method to DmiServiceUrlBuilder to get the write job url
- created WriteOperationExaminer, DmiSubJobClient & testware
Issue-ID: CPS-2142
Change-Id: I258d334ef346cd388341a1deb4078d24d8bdb7cc
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
|
|
- Added pendingAcquireMaxCount property into appliaction.yml.
- Added findbugs google annotations dependency.
- Supressed "BC_UNCONFIRMED_CAST_OF_RETURN_VALUE" spotbugs low error for
reactor.netty.resources.ConnectionProvider.
Issue-ID: CPS-2262
Change-Id: Ie755e40282473933f2052fbe7654e7090bb9b337
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
|
|
- Simplified NCMP Rest Request Handlers
- Moved responsEntity wrapping to Controller so most handler methods can have clear return types
- Moved NCMP Rest Request Handlers to Service Layer
- Moved related exceptions and utils to Service Layer
- Used Lombok for constructors
- Improved related testware
Issue-ID: CPS-2266
Change-Id: I0025fab1c92e0d613825093b6e4b43dae044c01a
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
|
|
- Code change is done to use async web client for single cm handle
read data operation.
- CpsNcmpTaskExecutor class and groovy test code is removed.
- Use of supplier code is removed from cm handle Query service.
Issue-ID:CPS-2259
Change-Id: I2b7a36e8a151a9224937afd876fceb30be6a24ce
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
|
|
- Exposed async version of post method into dmi rest client.
- Code change is done to use async web client for batch data
operation.
- Use of CpsNcmpTaskExecutor code is removed.
Issue-ID: CPS-2174
Change-Id: I7840fd8c6d9debe42e50c860f9cf39d64274df72
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
|
|
services
- Switched web client instance based on dmi service type (like data or model)
- 3 diff. beans are configured for data, model and health dmi service.
- Added configurable properties for data and model.
- Hard coded properties are assigned for health service.
Issue-ID: CPS-2231
Change-Id: I39fb739c07c41430dae43509fe29ece5306b7d71
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
|
|
Issue-ID: CPS-2071
Change-Id: Ibe7f59fbfcbb03703626132c6d5c2afde0e7ab4b
Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
|
|
|
|
|
|
|
|
Change-Id: I192fa53e293ea43cdff92ebd44d0382eb290bb76
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2172
|
|
Issue-ID: CPS-2241
Change-Id: I218c46e9c16cc78025450494f5019bde1f351a40
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
|
|
Issue-ID: CPS-2241
Change-Id: Idd074ff4d29cf11f45f1c69200788b2f39b49e74
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
|
|
- updated the cm subscription schemas with proper case as agreed before
for the events
- fixed the tests to reflect the camelCase change
Issue-ID: CPS-2245
Change-Id: I64fb8b27a5f64280dfa19d86ae310e6b5309de39
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
|
|
- Bug analysis showed some unclear and complicated code for building URLs
- This patch is to clean up the related code and show more clearly what is encoded and what is not
- Use SPringBoot provided builder to apply correct encoding of all URI parts
- DmiOperations base class no longer need as no common code model and data operations anymore
- Converted builder to POJO (client needs to provide the only dmi properties upon build)
- Added some missing test (in affected code) to increase coverage percntage
(as the production code has significantly reduced in size the overal coverage was inadvertently reduced below the treshold)
- Added more unit test. Now impl.operations' package has 100%
- removed the test fro Dmi Exception that was incorrectly callign the handleException methdod directly instead of mocking an exception
it was really a dupclicate of a test I added but I was able to re-use the event checkign in my test
Issue-ID: CPS-2246
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I1ff196cd03bbb95f5877ee590c321febeb672800
|
|
passthrough calls"
|
|
passthrough calls
Change-Id: I9c807d2ef5b3712bf3f8ee5db7663d9628eef3bb
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2187
|
|
- restructured already existing classes
- added testware for AlternateIdMatcher
Issue-ID: CPS 2240
Change-Id: I5691ed99627353903689cd2929163f77ed8c4eca
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
|
|
- Removing the unused NcmpRespnseStatus internal codes and messages
- Introducing statusCode 1 for ACCEPTED and 104 for REJECTED of
CmSubscription
- Added check for status code and message both in the flow
Issue-ID: CPS-2238
Change-Id: Id99f099a398392dbef1504f9d7c658665d163902
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
|