aboutsummaryrefslogtreecommitdiffstats
path: root/cps-ncmp-service
AgeCommit message (Collapse)AuthorFilesLines
6 daysUpdate docs related to lockHEADmastermpriyank1-2/+2
- added the distributed lock in the documentation as well - updated the log level to debug to refrain printing every iteration of the scheduler Issue-ID: CPS-2479 Change-Id: Ieeeff46168d70aca6f423e82bda15a12d6c405a5 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
6 daysMerge "Add schema to persist notification subscription information"Priyank Maheshwari7-420/+4
6 daysMerge "Remove check before removing from hazelcast cache"Toine Siebelink4-24/+5
6 daysAdd schema to persist notification subscription informationrajesh.kumar7-420/+4
Add required schema to persist notification subscription information. It should contain - Schema yang file - New Dataspace, Anchors or any other database entity - Refactore duplicate code in NCMP Issue-ID:CPS-2427 Change-Id: I56c34400dc73c71b936a51260efd300924ababdc Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
7 daysCps and Ncmp distributed lock for various use casesmpriyank4-37/+73
- introduced cpsAndNcmpLock to be used for any use case needing coordination. Since it can be used for any use case hence placing the class accordingly. - currently lock is being used for populating workQueue. - Removed FencedLock as it was part of CPSubsystem which is moved to hazelcast-enterprise in 5.5.* version onwards. - added info level logging statement to verify just one thread at a time in the critical section - Note : integration test to be part of a separate patch. Issue-ID: CPS-2479 Change-Id: I0f33c7232786c517383e5093fda91fd9a1839021 Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
7 daysRemove check before removing from hazelcast cacheemaclee4-24/+5
Issue-ID: CPS-2420 Change-Id: I2299d5790792f7c2b2b1a6aa371b5ea43c6a9ee8 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
7 daysHazelcast related code updateemaclee8-22/+13
- this patch answers comments from 'Hazelcast Optimization' patch that was merged Issue-ID: CPS-2420 Change-Id: Ic5cf005730f2a45eba553a7f6d32e9af6676821d Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
14 daysMerge "Increase Test coverage for cps-ncmp-service"Toine Siebelink2-19/+46
2024-12-11Increase Test coverage for cps-ncmp-serviceseanbeirne2-19/+46
Issue-ID: CPS-475 Change-Id: I35f127540e0fe5d412a9f855b647fef30f47159f Signed-off-by: seanbeirne <sean.beirne@est.tech>
2024-12-11Merge "Policy Executor API Review Board Comments"Lee Anjella Macabuhay2-39/+38
2024-12-10Policy Executor API Review Board CommentsToineSiebelink2-39/+38
- Implemented Guild review comments in API - Updated Stub to reflect new API and 'support' all operations - Updated production code to use new API - Updated Semi-Integration Tests Issue-ID: CPS-2479 Change-Id: Ibe307b0d859312b534009a384e9f71e1ea2affe0 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-12-10Separated inventoryFacade to Interface and Implleventecsanyi3-117/+192
- created NetworkCmProxyInventoryFacade IF Issue-ID: CPS-2513 Change-Id: Ibda2d7899514ee22d4b04cad971e107bfccce2df Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-12-09Hazelcast Optimisationemaclee13-54/+89
Issue-ID: CPS-2420 Change-Id: I707e0fbbddeb4ddc7c573a2b3ebd8fbca08126a6 Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2024-12-06[Module Sync] Store CM-handle IDs in work queuedanielhanrahan11-128/+121
This fixes bug CPS-2474, handling various edge cases, such as CM handles being deleted during module sync. - Change moduleSyncWorkQueue to store CmHandleId instead of DataNode. - Freshly fetch Cm Handles in module sync task, so latest CM-handle state is used, and only process ADVISED CM handles in module sync. Issue-ID: CPS-2474 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I53d5796c56014a2bfbe5b1c3f17d3991e4feef53
2024-12-05Moved common classes under the api package under apileventecsanyi56-131/+129
- moved common classes under the api package - moved Spec files Issue-ID: CPS-2512 Change-Id: I88046280ce359ce8cc488ad37d4e6f85406b0dbf Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2024-12-04Inventory Persistance returns YangModelCmHandles for alternate Idsseanbeirne9-65/+84
-Remove getCmHandleDataNodeByAlternateId(s) methods and replace with Yang Model methods Issue-ID: CPS-2486 Change-Id: I2c9c96f033b3b1eefadb7eff14c91f9a936630e6 Signed-off-by: seanbeirne <sean.beirne@est.tech>
2024-12-04[BUG] Effective trust factors in DMI trust leveldanielhanrahan7-30/+131
Effective trust of a CM handle should be the trust level of the handle or the DMI, whichever is lower. Currently, effective trust level of a CM handle is not reported correctly when the DMI is down, as DMI trust level is not considered. - Add DMI service names to NcmpServiceCmHandle - Introduce new DmiServiceNameResolver class - Correctly calculate effective trust level Issue-ID: CPS-2375 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Iaded0fadad58d960eb76c69f79a308df8329e534
2024-12-03Improve test coverage trustlevel managerToineSiebelink1-6/+9
Issue-ID: CPS-475 Change-Id: I572227b4f6c61bd2286d8cb3fb85c3dc21142a47 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-12-03Merge "Faster CM-handle searches using Hazelcast optimization"Toine Siebelink8-65/+146
2024-12-02Update the minor version of CPSmpriyank1-1/+1
- Update the minor version of cps. - New version being 3.6.0-SNAPSHOT now. Issue-ID: CPS-2488 Change-Id: I87fb29fe45dc942b258bc1d45e09a3351739539b Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-12-02Faster CM-handle searches using Hazelcast optimizationdanielhanrahan8-65/+146
This uses IMap::getAll(setOfKeys) to bulk read trust levels. This reduces CM-handle search time by a third. Issue-ID: CPS-2420 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ie63b45a76bee146def537b749074ecbb7715e6fc
2024-11-29Bump CPS to 3.5.6-SNAPSHOTegernug1-1/+1
Issue-ID: CPS-2488 Change-Id: Ib17e4283de959ec4aab3c68bb3ba8018a10a10b2 Signed-off-by: egernug <gerard.nugent@est.tech>
2024-11-27Merge "Catch data validation exception in dmi data operation"Daniel Hanrahan2-7/+12
2024-11-25Catch data validation exception in dmi data operationseanbeirne2-7/+12
Issue-ID: CPS-2510 Change-Id: I4093459c824c202dc8dec4b869e338d4b80fbac8 Signed-off-by: seanbeirne <sean.beirne@est.tech>
2024-11-25Registration Optimization remaining Code CommentsToineSiebelink3-6/+3
Issue-ID: CPS-2478 Change-Id: I0aa3804225f053ff99176056fe71322a23cff31c Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-11-21Merge "Prioritize cm handle ids over alternate ids in data operations"Daniel Hanrahan5-8/+43
2024-11-21Prioritize cm handle ids over alternate ids in data operationsToineSiebelink5-8/+43
Issue-ID: CPS-2510 Change-Id: I7068d0de45cc2c2e5d8815f0e78c260369f3551e Signed-off-by: seanbeirne <sean.beirne@est.tech> Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-11-21[BUG] Fix for module endpoints using alternate IDdanielhanrahan1-7/+21
The endpoints for fetching modules and module definitions previously returned empty result if a CM handle was not found or not ready. Recent changes for alternate ID have changed the behaviour so it returns an error instead. This restores original behaviour by swallowing the exception. Change-Id: I63091d04d171e6f4ac6ad1c44b359b9a0c4b8f65 Issue-ID: CPS-2509 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
2024-11-20Update error response for ncmp endpointsseanbeirne12-29/+68
Issue-ID: CPS-2386 Change-Id: I0d1f09cff202e055be255b365fc2271a5ee43b37 Signed-off-by: seanbeirne <sean.beirne@est.tech>
2024-11-20Revert "Update error response for ncmp endpoints"ToineSiebelink10-64/+25
This reverts commit 7e6fee9321e4f13cc4a0d81f83fc3693309cb5d7. Reason for revert: This patch is causing blocking issues at ESH see CPS-2509 Issue-ID: CPS-2509 Change-Id: Ie1bd26ccca4abcac09faf35e2b97491dab32b14d Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-11-19Merge "Test to highlight ModuleSetTag Inefficiencies"Sourabh Sourabh9-26/+175
2024-11-18Update error response for ncmp endpointsseanbeirne10-25/+64
Issue-ID: CPS-2386 Change-Id: Ib4f37858f5f107e350a13e4bf7ed93493864ce60 Signed-off-by: seanbeirne <sean.beirne@est.tech>
2024-11-18Test to highlight ModuleSetTag InefficienciesToineSiebelink9-26/+175
- Add (micrometer) instrumentation to expose inefficiencies - Add test config for micrometer - Add setup methods in base to create many cm handles - Set module sync parallelism to 2 for testing - Add clean up methods for hazelcast related tests - added test to show inefficiencies - POC 1 use hazelcast set to prevent multiple threads working on same ModuleSetTag - POC 2 'cache' module set tags per thread to prevent DB looks ups - Main inefficiency left: create schemaset for EACH cm Handled even if same tag. No easy PoC... Change-Id: Idf46b44c475a24727dd7084bb613459f4c29be55 Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2024-11-15Merge "Support alternate Id interface for ncmp inventory /ch/cmhandles endpoint"Priyank Maheshwari13-80/+108
2024-11-13Merge "Hashmark support in 3gpp objects"Toine Siebelink2-7/+12
2024-11-13Support alternate Id interface for ncmp inventory /ch/cmhandles endpointseanbeirne13-80/+108
Issue-ID: CPS-2481 Change-Id: I8a200495be1afb9a4f256127f886bed78c77f653 Signed-off-by: seanbeirne <sean.beirne@est.tech>
2024-11-12Hashmark support in 3gpp objectsegernug2-7/+12
NCMP should cut off the part after the # of an alternateid and use only the first part in CPS match check, but send the complete request to the DMI plugin. Issue-ID: CPS-2485 Change-Id: Icc1442f2be9545036619043692c3559ffadecb0d Signed-off-by: egernug <gerard.nugent@est.tech>
2024-11-11Merge "Support Alternate-Id for CPS-E05 data batch interface"Priyank Maheshwari12-56/+130
2024-11-07Merge "Cm Avc Event to have same key"Toine Siebelink2-7/+12
2024-11-07Merge "Removing ONAP O-Parent as parent from CPS"Toine Siebelink1-1/+1
2024-11-06Merge "Change the dmi address source from dmi-service-name to ↵Sourabh Sourabh2-10/+28
dmi-data-service-name for writeDataJob"
2024-11-05Change the dmi address source from dmi-service-name to dmi-data-service-name ↵egernug2-10/+28
for writeDataJob -Change implementation to convert datanode to yang model -Change to resolve service name consistent with other implementations Issue-ID: CPS-2455 Change-Id: I9cbe494b8c37eb963c42abee1ac5f04a3f695d07 Signed-off-by: egernug <gerard.nugent@est.tech>
2024-11-05Support Alternate-Id for CPS-E05 data batch interfaceseanbeirne12-56/+130
Issue-ID: CPS-2274 Change-Id: I75163bc7943fca5cbbe8c24601a2dfc184a9e6cc Signed-off-by: seanbeirne <sean.beirne@est.tech>
2024-11-05Removing ONAP O-Parent as parent from CPSsourabh_sourabh1-1/+1
- Fixed checkstyle and license validation. - Updated checkstyle configuration (`onap-java-style.xml` and `check-license.xml`) to ensure compatibility with Maven Checkstyle Plugin version 3.3.1 - Removed obsolete properties causing build failures. - Improved code style rules to meet ONAP Java guidelines. - Vulnerabilities scan are now configured on parent pom.xml - Fixed all code style. Issue-ID: CPS-2470 Change-Id: I1e72af604415aa7587cbe1dff471ed0323e29aa3 Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2024-11-04Refactor module synch taskhalil.cakal1-26/+29
- improve readablity of ModuleSyncTasks Issue-ID: CPS-2474 Change-Id: Ib0342e8fad00b431a293c5095fe54f4917f7a51b Signed-off-by: halil.cakal <halil.cakal@est.tech>
2024-11-04Cm Avc Event to have same keympriyank2-7/+12
- incoming Cm Avc Event from DMI Plugin is consumed and forwarded to target topic - the key from source topic to be used in the target topic while forwarding - with same key the ordering of the message will be preserved - NOTE: the RTD related changes will be a separate patchset Issue-ID: CPS-2436 Change-Id: Ie692663706b378022ec0d621d92ca5054bad8d1b Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2024-11-04[Module Sync] Always update states at end of batchdanielhanrahan1-5/+5
This commit moves the state update code into the 'finally' block, so that state updates are always sent for the handles that finished syncing, even if an exception occurred. This commit also fixes a typo in cmHandleStatePerCmHandle. Issue-ID: CPS-2474 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: Ic25608a5772c0873fe0d0f8aca8d70bcda51d94a
2024-11-01[Module Sync] Log state changes after persistencedanielhanrahan7-153/+151
Currently, module sync will output messages such as: "cm-handle-1 is now in READY state" before the state change is persisted to the DB. If an exception occurs, the new state may not be persisted, which makes debugging hard due to misleading log entries. This commit moves the logging to the LCM state handler immediately after the change is persisted. - Move logging of state changes to LcmEventsCmHandleStateHandler. - Remove unused code in LcmEventsCmHandleStateHandler. - Add tests of state change logging. - Update the main test showing the bug to instead show expected behaviour, but disable test for now using @Ignore. Issue-ID: CPS-2474 Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech> Change-Id: I58646af6df95e07e69ca525744713a7c01c25e41
2024-10-29Merge "Fix failing CSIT and add unit test proving the bug"Toine Siebelink2-3/+24
2024-10-29Merge "Support Alternate-Id for CPS-E05 id-searches and searchCmHandleIds"Daniel Hanrahan13-136/+257