1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
|
# -*- coding: utf8 -*-
# ============LICENSE_START=======================================================
# org.onap.vvp/validation-scripts
# ===================================================================
# Copyright © 2019 AT&T Intellectual Property. All rights reserved.
# ===================================================================
#
# Unless otherwise specified, all software contained herein is licensed
# under the Apache License, Version 2.0 (the "License");
# you may not use this software except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
#
#
# Unless otherwise specified, all documentation contained herein is licensed
# under the Creative Commons License, Attribution 4.0 Intl. (the "License");
# you may not use this documentation except in compliance with the License.
# You may obtain a copy of the License at
#
# https://creativecommons.org/licenses/by/4.0/
#
# Unless required by applicable law or agreed to in writing, documentation
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# ============LICENSE_END============================================
#
#
import re
import pytest
from tests import cached_yaml as yaml
from .helpers import validates
from .utils.network_roles import (
get_network_role_from_port,
get_network_type_from_port,
property_uses_get_resource,
)
from .utils.vm_types import get_vm_type_for_nova_server
@validates("R-20453", "R-26351", "R-26506", "R-681859")
def test_port_resource_ids(yaml_file):
"""
Check that all resource ids for ports follow the right
naming convention to include the {vm_type} of the
nova server it is associated to and also contains the
{network_role} of the network it is associated with
"""
with open(yaml_file) as fh:
yml = yaml.load(fh)
# skip if resources are not defined
if "resources" not in yml:
pytest.skip("No resources specified in the heat template")
resources = yml["resources"]
invalid_ports = []
for k, v in resources.items():
if not isinstance(v, dict):
continue
if "type" not in v:
continue
if v["type"] not in "OS::Nova::Server":
continue
if "properties" not in v:
continue
if "networks" not in v["properties"]:
continue
vm_type = get_vm_type_for_nova_server(v)
if not vm_type:
continue
vm_type = vm_type.lower()
# get all ports associated with the nova server
properties = v["properties"]
for v2 in properties["networks"]:
for k3, v3 in v2.items():
if k3 != "port":
continue
if not isinstance(v3, dict):
continue
if "get_param" in v3:
continue
elif "get_resource" in v3:
port_id = v3["get_resource"]
if not resources[port_id]:
continue
port_resource = resources[port_id]
port_id = port_id.lower()
else:
continue
if property_uses_get_resource(v, "network"):
continue
if port_resource.get("type", "") != "OS::Neutron::Port":
continue
network_role = get_network_role_from_port(port_resource)
if not network_role:
invalid_ports.append(
(port_id, "Unable to determine network role for port.")
)
continue
network_role = network_role.lower()
network_type = get_network_type_from_port(port_resource)
if not network_type:
invalid_ports.append(
(
port_id,
"Unable to determine network type for port (internal or external).",
)
)
continue
if network_type == "external":
expected_r_id = r"{}_\d+_{}_port_\d+".format(vm_type, network_role)
else:
expected_r_id = r"{}_\d+_int_{}_port_\d+".format(
vm_type, network_role
)
if not re.match(expected_r_id, port_id):
invalid_ports.append(
(port_id, "Did not match {}".format(expected_r_id))
)
port_errors = "; ".join(
"{} -> {}".format(port, error) for port, error in invalid_ports
)
msg = "The following ports have invalid resource IDs: {}".format(port_errors)
msg = msg.replace(r"\d+", "{index}")
assert not invalid_ports, msg
|
