1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
|
# -*- coding: utf8 -*-
# ============LICENSE_START=======================================================
# org.onap.vvp/validation-scripts
# ===================================================================
# Copyright © 2017 AT&T Intellectual Property. All rights reserved.
# ===================================================================
#
# Unless otherwise specified, all software contained herein is licensed
# under the Apache License, Version 2.0 (the "License");
# you may not use this software except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
#
#
# Unless otherwise specified, all documentation contained herein is licensed
# under the Creative Commons License, Attribution 4.0 Intl. (the "License");
# you may not use this documentation except in compliance with the License.
# You may obtain a copy of the License at
#
# https://creativecommons.org/licenses/by/4.0/
#
# Unless required by applicable law or agreed to in writing, documentation
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# ============LICENSE_END============================================
#
# ECOMP is a trademark and service mark of AT&T Intellectual Property.
#
import pytest
import re
from tests import cached_yaml as yaml
from .helpers import validates
from .utils.network_roles import get_network_role_from_port, property_uses_get_resource
RE_INTERNAL_NETWORK_RID = re.compile( # match pattern
r"int_(?P<network_role>.+)_network$"
)
NETWORK_RESOURCE_TYPES = ["OS::Neutron::Net", "OS::ContrailV2::VirtualNetwork"]
@validates("R-62983", "R-86182")
def test_network_format(heat_template):
"""
Make sure all network properties use the allowed naming
conventions
"""
with open(heat_template) as fh:
yml = yaml.load(fh)
# skip if resources are not defined
if "resources" not in yml:
pytest.skip("No resources specified in the heat template")
invalid_ports = []
for k, v in yml["resources"].items():
if not isinstance(v, dict):
continue
if "properties" not in v:
continue
if property_uses_get_resource(v, "network"):
continue
if v.get("type") != "OS::Neutron::Port":
continue
if not get_network_role_from_port(v):
invalid_ports.append(k)
assert not set(invalid_ports), (
"Missing 'network' property or improperly "
"formatted network parameter name on the "
"following OS::Neutron::Ports: "
"{}".format(", ".join(invalid_ports))
)
@validates("R-16968", "R-35666")
def test_network_resource_id_format(yaml_file):
"""
Make sure all network resource ids use the allowed naming
convention
"""
RE_INTERNAL_NETWORK_RID = re.compile( # match pattern
r"int_(?P<network_role>.+)_network$"
)
with open(yaml_file) as fh:
yml = yaml.load(fh)
# skip if resources are not defined
if "resources" not in yml:
pytest.skip("No resources specified in the heat template")
invalid_networks = []
for k, v in yml["resources"].items():
if not isinstance(v, dict):
continue
if "properties" not in v:
continue
if property_uses_get_resource(v, "network"):
continue
if v.get("type") not in NETWORK_RESOURCE_TYPES:
continue
match = RE_INTERNAL_NETWORK_RID.match(k)
if not match:
invalid_networks.append(k)
assert not set(invalid_networks), (
"Heat templates must only create internal networks "
"and follow format int_{network-role}_network"
"{}".format(", ".join(invalid_networks))
)
@validates("R-16241")
def test_network_has_subnet(yaml_file):
"""
if creating internal network, make sure there is a
corresponding subnet that references it
"""
with open(yaml_file) as fh:
yml = yaml.load(fh)
# skip if resources are not defined
if "resources" not in yml:
pytest.skip("No resources specified in the heat template")
networks = []
for k, v in yml["resources"].items():
if not isinstance(v, dict):
continue
if "properties" not in v:
continue
# need to check if contrail networks also require subnet
# and it is defined the same as neutron networks
# if v.get("type") not in NETWORK_RESOURCE_TYPES:
if v.get("type") not in ["OS::Neutron::Net"]:
continue
networks.append(k)
for k, v in yml["resources"].items():
if not isinstance(v, dict):
continue
if "properties" not in v:
continue
if v.get("type") != "OS::Neutron::Subnet":
continue
network_prop = v.get("properties", {}).get("network", {}).get("get_resource")
if not network_prop:
continue
x = 0
for network in networks:
if network == network_prop:
networks.pop(x)
break
x += 1
assert not networks, "Networks detected without subnet {}".format(networks)
|
