diff options
Diffstat (limited to 'vid-automation/src/test/java/org/onap/vid/more')
3 files changed, 52 insertions, 44 deletions
diff --git a/vid-automation/src/test/java/org/onap/vid/more/LoggerFormatTest.java b/vid-automation/src/test/java/org/onap/vid/more/LoggerFormatTest.java index fd8f48279..7ca29f854 100644 --- a/vid-automation/src/test/java/org/onap/vid/more/LoggerFormatTest.java +++ b/vid-automation/src/test/java/org/onap/vid/more/LoggerFormatTest.java @@ -1,7 +1,17 @@ package org.onap.vid.more; +import static org.hamcrest.CoreMatchers.is; +import static org.hamcrest.Matchers.greaterThan; +import static org.hamcrest.Matchers.greaterThanOrEqualTo; +import static org.junit.Assert.assertThat; + import com.fasterxml.jackson.databind.JsonNode; +import java.net.URI; +import java.util.HashMap; +import java.util.Map; import org.apache.commons.lang3.StringUtils; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; import org.onap.simulator.presetGenerator.presets.aai.PresetAAIGetSubscribersGet; import org.onap.vid.api.BaseApiTest; import org.springframework.web.client.RestTemplate; @@ -9,20 +19,12 @@ import org.testng.annotations.BeforeClass; import org.testng.annotations.Test; import vid.automation.test.services.SimulatorApi; -import java.net.URI; -import java.util.HashMap; -import java.util.Map; - -import static org.hamcrest.CoreMatchers.is; -import static org.hamcrest.MatcherAssert.assertThat; -import static org.hamcrest.Matchers.greaterThan; -import static org.hamcrest.Matchers.greaterThanOrEqualTo; - public class LoggerFormatTest extends BaseApiTest { - // See: https://wiki.web.att.com/display/KSAT/REST-based+Log+Checker - private final static String logChecker = "http://eelflogcheck.it.att.com:31820/validate"; + // See: https://www.openecomp.org/KSAT/REST-based+Log+Checker + private final static String logChecker = "http://eelf.onap.org:31820/validate"; + private final Logger logger = LogManager.getLogger(LoggerFormatTest.class); @BeforeClass public void login() { @@ -56,9 +58,9 @@ public class LoggerFormatTest extends BaseApiTest { private void validateLogsFormat(String logName, String logType) { String logLines = getLogLines(logName); + logger.info("logLines are: "+logLines); JsonNode response = getCheckerResults(logType, logLines); - - System.out.println(response); + logger.info("Response is:" + response.toString()); double fieldscore = response.path("summary").path("score").path("fieldscore").asDouble(); double overall = response.path("summary").path("score").path("overallscore").asDouble(); diff --git a/vid-automation/src/test/java/org/onap/vid/more/RequestIdFilterInstalled.java b/vid-automation/src/test/java/org/onap/vid/more/RequestIdFilterInstalled.java index 560538737..0a0045d4d 100644 --- a/vid-automation/src/test/java/org/onap/vid/more/RequestIdFilterInstalled.java +++ b/vid-automation/src/test/java/org/onap/vid/more/RequestIdFilterInstalled.java @@ -4,23 +4,22 @@ import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; import org.apache.commons.lang3.StringUtils; import org.apache.commons.lang3.tuple.Pair; +import org.junit.Assert; +import org.onap.simulator.presetGenerator.presets.aaf.AAFGetBasicAuthPreset; +import org.onap.simulator.presetGenerator.presets.aaf.AAFGetUrlServicePreset; import org.onap.vid.api.BaseApiTest; import org.onap.vid.api.OperationalEnvironmentControllerApiTest; import org.onap.vid.api.ServiceInstanceMsoApiTest; -import org.springframework.http.HttpEntity; -import org.springframework.http.HttpHeaders; -import org.springframework.http.HttpMethod; -import org.springframework.http.ResponseEntity; +import org.springframework.http.*; import org.testng.annotations.BeforeClass; import org.testng.annotations.Test; import vid.automation.test.services.SimulatorApi; +import java.util.List; import java.util.UUID; import static org.hamcrest.CoreMatchers.*; import static org.hamcrest.MatcherAssert.assertThat; -import static org.hamcrest.Matchers.containsInAnyOrder; -import static org.hamcrest.Matchers.nullValue; import static org.onap.vid.api.CategoryParametersApiTest.GET_CATEGORY_PARAMETER_PROPERTIES; import static org.onap.vid.api.pProbeMsoApiTest.MSO_CREATE_CONFIGURATION; import static org.springframework.http.HttpHeaders.AUTHORIZATION; @@ -49,7 +48,7 @@ public class RequestIdFilterInstalled extends BaseApiTest { } @Test - public void frontendApi_doGET_RequestIdReceived() { + public void frontendApi_doGET_RequestIdReceived() throws InterruptedException { final Pair<HttpEntity, String> responseAndUuid = makeRequest( HttpMethod.GET, @@ -62,7 +61,7 @@ public class RequestIdFilterInstalled extends BaseApiTest { } @Test - public void frontendApi_doPOST_RequestIdReceived() { + public void frontendApi_doPOST_RequestIdReceived() throws InterruptedException { final Pair<HttpEntity, String> responseAndUuid = makeRequest( HttpMethod.POST, @@ -87,14 +86,13 @@ public class RequestIdFilterInstalled extends BaseApiTest { @Test(groups = { "worksOnlyWithLocalhostVID" }) - public void mopOwningEntityApi_doGET_RequestIdReceived() { + public void mopOwningEntityApi_doGET_RequestIdReceived() throws InterruptedException { final Pair<HttpEntity, String> responseAndUuid = makeRequest( HttpMethod.GET, "/" + GET_CATEGORY_PARAMETER_PROPERTIES + "?familyName=PARAMETER_STANDARDIZATION", null ); - assertThatUuidInResponseAndUuidIsInARecentLog(responseAndUuid); /* @@ -110,12 +108,18 @@ public class RequestIdFilterInstalled extends BaseApiTest { } @Test - public void schedulerApi_doPOST_RequestIdReceived() { + public void schedulerApi_doPOST_RequestIdReceived() throws InterruptedException { final String anyInstanceId = "any instance id"; SimulatorApi.registerExpectation( "mso_in_place_software_update_ok.json", ImmutableMap.of("SERVICE_INSTANCE_ID", anyInstanceId, "VNF_INSTANCE_ID", anyInstanceId), SimulatorApi.RegistrationStrategy.CLEAR_THEN_SET); + SimulatorApi.registerExpectationFromPreset( + new AAFGetUrlServicePreset(), + SimulatorApi.RegistrationStrategy.APPEND); + SimulatorApi.registerExpectationFromPreset( + new AAFGetBasicAuthPreset(), + SimulatorApi.RegistrationStrategy.APPEND); final Pair<HttpEntity, String> responseAndUuid = makeRequest( HttpMethod.POST, "/change-management/workflow/" + anyInstanceId, @@ -126,7 +130,7 @@ public class RequestIdFilterInstalled extends BaseApiTest { } @Test - public void healthcheck_doGET_RequestIdReceived(){ + public void healthcheck_doGET_RequestIdReceived() { final Pair<HttpEntity, String> responseAndUuid = makeRequest( HttpMethod.GET, "/healthCheck", null ); @@ -142,14 +146,16 @@ public class RequestIdFilterInstalled extends BaseApiTest { // THIS TEST IS NOT JUST NICE TO HAVE, it also lets us know // that the request/response ran through our "promise request // id" filter, which is great! - assertThat(response, not(nullValue())); - assertThat(response.getHeaders().get(ECOMP_REQUEST_ID_ECHO), containsInAnyOrder(uuid)); + Assert.assertNotNull(response); + List<String> ecompRequestIdHeaderValues = response.getHeaders().get(ECOMP_REQUEST_ID_ECHO); + Assert.assertNotNull(ecompRequestIdHeaderValues); + Assert.assertTrue(ecompRequestIdHeaderValues.contains(uuid)); } private void assertThatTermIsInARecentLog(String uuid) { final ImmutableList<String> logLines = ImmutableList.of( - LoggerFormatTest.getLogLines("audit", 5, 0, restTemplate, uri), - LoggerFormatTest.getLogLines("error", 5, 0, restTemplate, uri) + LoggerFormatTest.getLogLines("audit", 20, 0, restTemplate, uri), + LoggerFormatTest.getLogLines("error", 20, 0, restTemplate, uri) ); // Assert that audit *OR* error has the uuid @@ -164,13 +170,13 @@ public class RequestIdFilterInstalled extends BaseApiTest { final String uuid = UUID.randomUUID().toString(); final HttpHeaders headers = new HttpHeaders(); headers.add(ECOMP_REQUEST_ID, uuid); - headers.add(AUTHORIZATION, "Basic 123=="); + headers.add(AUTHORIZATION, "Basic " + AAFGetBasicAuthPreset.VALID_AUTH_VALUE); + headers.setContentType(MediaType.APPLICATION_JSON); - SimulatorApi.clearExpectations(); if (!StringUtils.isEmpty(expectationFilename)) { SimulatorApi.registerExpectation(expectationFilename, APPEND); } - SimulatorApi.registerExpectation("aai_get_full_subscribers.json", APPEND); + SimulatorApi.registerExpectation("create_new_instance/aai_get_full_subscribers.json", APPEND); SimulatorApi.registerExpectation("ecompportal_getSessionSlotCheckInterval.json", APPEND); HttpEntity entity = new HttpEntity<>(body, headers); diff --git a/vid-automation/src/test/java/org/onap/vid/more/SimulatorLoaderTest.java b/vid-automation/src/test/java/org/onap/vid/more/SimulatorLoaderTest.java index bc550ae19..eff73cf70 100644 --- a/vid-automation/src/test/java/org/onap/vid/more/SimulatorLoaderTest.java +++ b/vid-automation/src/test/java/org/onap/vid/more/SimulatorLoaderTest.java @@ -1,13 +1,7 @@ package org.onap.vid.more; import org.onap.simulator.presetGenerator.presets.BasePresets.BasePreset; -import org.onap.simulator.presetGenerator.presets.aai.PresetAAIBadBodyForGetServicesGet; -import org.onap.simulator.presetGenerator.presets.aai.PresetAAIGetNetworkZones; -import org.onap.simulator.presetGenerator.presets.aai.PresetAAIGetPNFByRegionErrorPut; -import org.onap.simulator.presetGenerator.presets.aai.PresetAAIGetServicesGet; -import org.onap.simulator.presetGenerator.presets.aai.PresetAAIGetSubscribersGet; -import org.onap.simulator.presetGenerator.presets.aai.PresetAAISearchNodeQueryEmptyResult; -import org.onap.simulator.presetGenerator.presets.aai.PresetAAIServiceDesignAndCreationPut; +import org.onap.simulator.presetGenerator.presets.aai.*; import org.onap.simulator.presetGenerator.presets.ecompportal_att.PresetGetSessionSlotCheckIntervalGet; import org.onap.simulator.presetGenerator.presets.ecompportal_att.PresetGetUserGet; import org.onap.simulator.presetGenerator.presets.mso.PresetActivateServiceInstancePost; @@ -34,6 +28,7 @@ import java.util.List; import java.util.Map; import static org.testng.Assert.assertEquals; +import static vid.automation.test.infra.ModelInfo.aLaCarteServiceCreationTest; import static vid.automation.test.services.SimulatorApi.registerExpectationFromPreset; import static vid.automation.test.services.SimulatorApi.registerExpectationFromPresets; @@ -43,8 +38,9 @@ public class SimulatorLoaderTest extends BaseApiTest { protected Invocation.Builder createSimulatorRequestBuilder(BasePreset preset) { WebTarget webTarget = client.target(SimulatorApi.getSimulationUri() + preset.getReqPath()); webTarget = addQueryParamsToWebTarget(preset, webTarget); - return webTarget.request() + Invocation.Builder builder = webTarget.request() .accept("application/json"); + return addHeadersToBuilder(preset, builder); } private WebTarget addQueryParamsToWebTarget(BasePreset preset, WebTarget webTarget) { @@ -56,11 +52,16 @@ public class SimulatorLoaderTest extends BaseApiTest { return webTarget; } + private Invocation.Builder addHeadersToBuilder(BasePreset preset, Invocation.Builder builder) { + preset.getRequestHeaders().forEach((key,value)->builder.header(key,value)); + return builder; + } + @DataProvider public static Object[][] presetClassesWithPutPost(Method test) { return new Object[][]{ {new PresetAAIGetPNFByRegionErrorPut()}, - {new PresetAAIServiceDesignAndCreationPut("a","b")}, + {new PresetAAIServiceDesignAndCreationPut()}, {new PresetDeactivateServiceInstancePost()}, {new PresetActivateServiceInstancePost()}, {new PresetMSOCreateServiceInstancePost()} @@ -87,11 +88,10 @@ public class SimulatorLoaderTest extends BaseApiTest { {new PresetGetSessionSlotCheckIntervalGet()}, {new PresetGetUserGet()}, {new PresetAAIGetServicesGet()}, - {new PresetSDCGetServiceMetadataGet("a" , "b", "serviceCreationTest.zip")}, - {new PresetSDCGetServiceToscaModelGet( "a", "serviceCreationTest.zip")}, + {new PresetSDCGetServiceMetadataGet(aLaCarteServiceCreationTest)}, + {new PresetSDCGetServiceToscaModelGet( aLaCarteServiceCreationTest)}, {new PresetMSOOrchestrationRequestGet()}, {new PresetAAIGetNetworkZones()}, - {new PresetAAISearchNodeQueryEmptyResult()}, {new PresetAAIBadBodyForGetServicesGet("not a json")}, }; } |