Increasing test coverage for vid.mso.rest

Change-Id: Ie672d561c5f1c674cce979e0f640027bb6fc0fa7
Issue-ID: VID-387
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>

1 files changed, 421 insertions, 0 deletions

diff --git a/vid-app-common/src/test/java/org/onap/vid/mso/RestMsoImplementationTest.java b/vid-app-common/src/test/java/org/onap/vid/mso/RestMsoImplementationTest.java
new file mode 100644
index 000000000..4cba53785
--- /dev/null
+++ b/vid-app-common/src/test/java/org/onap/vid/mso/RestMsoImplementationTest.java
@@ -0,0 +1,421 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * VID
+ * ================================================================================
+ * Copyright (C) 2019 Nokia Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
+package org.onap.vid.mso;
+
+import io.joshworks.restclient.request.HttpRequest;
+import org.glassfish.jersey.client.JerseyInvocation;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.onap.portalsdk.core.util.SystemProperties;
+import org.onap.vid.aai.util.HttpsAuthClient;
+import org.onap.vid.changeManagement.RequestDetailsWrapper;
+import org.onap.vid.exceptions.GenericUncheckedException;
+import org.onap.vid.mso.rest.RequestDetails;
+import org.springframework.http.HttpMethod;
+import org.springframework.http.HttpStatus;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+
+import javax.ws.rs.client.Client;
+import javax.ws.rs.client.Entity;
+import javax.ws.rs.client.WebTarget;
+import javax.ws.rs.core.MultivaluedHashMap;
+import javax.ws.rs.core.MultivaluedMap;
+import javax.ws.rs.core.Response;
+
+import java.util.Optional;
+
+import static org.assertj.core.api.Java6Assertions.assertThat;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.when;
+import static org.mockito.MockitoAnnotations.initMocks;
+
+public class RestMsoImplementationTest  {
+
+    @Mock
+    private HttpRequest httpRequest;
+
+    @Mock
+    private Client mockClient;
+
+    @Mock
+    private HttpsAuthClient mockHttpsAuthClient;
+
+    @Mock
+    private WebTarget webTarget;
+
+    @Mock
+    private javax.ws.rs.client.Invocation.Builder builder;
+
+    @Mock
+    private Response response;
+
+    @Mock
+    private JerseyInvocation jerseyInvocation;
+
+    @InjectMocks
+    private RestMsoImplementation restMsoImplementation = new RestMsoImplementation(mockHttpsAuthClient);
+
+    String path = "/test_path/";
+    String rawData = "test-row-data";
+
+    @BeforeClass
+    public void setUp(){
+        initMocks(this);
+    }
+
+    @Test
+    public void shouldProperlyInitMsoClient() {
+        //  when
+        MultivaluedHashMap<String, Object> result = restMsoImplementation.initMsoClient();
+
+        //  then
+        assertThat(result).containsKeys("Authorization","X-ONAP-PartnerName");
+        assertThat(result).doesNotContainKey("notExistingKey");
+    }
+
+    @Test
+    public void shouldProperlyGetRestObjectWithRequestInfo() {
+        //  given
+        RestObject<HttpRequest> restObject = new RestObject<>();
+
+        prepareMocks(rawData, HttpStatus.ACCEPTED.value(),"");
+
+        //  when
+        RestObjectWithRequestInfo<HttpRequest> response = restMsoImplementation.Get(httpRequest, path, restObject,false);
+
+        //  then
+        assertThat(response.getRequestedUrl()).contains(path);
+        assertThat(response.getRawData()).isEqualTo(rawData);
+        assertThat(response.getHttpCode()).isEqualTo(HttpStatus.ACCEPTED.value());
+        assertThat(response.getHttpMethod()).isEqualTo(HttpMethod.GET);
+    }
+
+    @Test( expectedExceptions = GenericUncheckedException.class)
+    public void shouldThrowExceptionWhenGetRestObjectWithRequestInfoGetsWrongStatus() {
+        //  given
+        RestObject<HttpRequest> restObject = new RestObject<>();
+
+        prepareMocks("",HttpStatus.BAD_REQUEST.value(),"");
+
+        //  when
+        restMsoImplementation.Get(httpRequest, "", restObject,false);
+    }
+
+    @Test( expectedExceptions = MsoTestException.class)
+    public void shouldThrowExceptionWhenGetRestObjectWithRequestInfoGetsWrongParameters() {
+        //  given
+        RestObject<HttpRequest> restObject = new RestObject<>();
+
+        prepareMocks("",HttpStatus.ACCEPTED.value(),"");
+        when(mockClient.target(SystemProperties.getProperty(MsoProperties.MSO_SERVER_URL))).thenThrow(new MsoTestException("test-target-exception"));
+
+        //  when
+        restMsoImplementation.Get(httpRequest, "", restObject,false);
+    }
+
+    @Test()
+    public void shouldProperlyGetRestObjectForObjectWithRequestInfoAndAcceptCode() {
+        //  given
+        prepareMocks(rawData,HttpStatus.ACCEPTED.value(),"");
+
+        //  when
+        RestObject response = restMsoImplementation.GetForObject(path, HttpRequest.class);
+
+        //  then
+        assertThat(response.getStatusCode()).isEqualTo(HttpStatus.ACCEPTED.value());
+        assertThat(response.getRaw()).isEqualTo(rawData);
+    }
+
+    @Test()
+    public void shouldProperlyGetRestObjectForObjectWithRequestInfoAndBadRequestCode() {
+        //  given
+        prepareMocks(rawData,HttpStatus.BAD_REQUEST.value(),"");
+
+        //  when
+        RestObject response = restMsoImplementation.GetForObject(path, HttpRequest.class);
+
+        //  then
+        assertThat(response.getStatusCode()).isEqualTo(HttpStatus.BAD_REQUEST.value());
+        assertThat(response.getRaw()).isEqualTo(rawData);
+    }
+
+    @Test()
+    public void shouldProperlyDeleteRestObjectWithStatusHttpAccepted() {
+        //  given
+        RestObject<HttpRequest> restObject = new RestObject<>();
+
+        prepareMocks(rawData,HttpStatus.ACCEPTED.value(),"DELETE");
+
+        //  when
+        restMsoImplementation.Delete(httpRequest, "testObject", path, restObject);
+
+        //  then
+        assertThat(restObject.getStatusCode()).isEqualTo(HttpStatus.ACCEPTED.value());
+    }
+
+    @Test()
+    public void shouldProperlyDeleteRestObjectWithStatusOK() {
+        //  given
+        RestObject<HttpRequest> restObject = new RestObject<>();
+
+        prepareMocks(rawData,HttpStatus.OK.value(),"DELETE");
+
+        //  when
+        restMsoImplementation.Delete(httpRequest, "testObject", path, restObject);
+
+        //  then
+        assertThat(restObject.getStatusCode()).isEqualTo(HttpStatus.OK.value());
+    }
+
+    @Test()
+    public void shouldProperlyReturnFromDeleteWithStatusBadRequest() {
+        //  given
+        RestObject<HttpRequest> restObject = new RestObject<>();
+
+        prepareMocks(rawData,HttpStatus.BAD_REQUEST.value(),"DELETE");
+
+        //  when
+        restMsoImplementation.Delete(httpRequest, "testObject", path, restObject);
+
+        //  then
+        assertThat(restObject.getStatusCode()).isEqualTo(HttpStatus.BAD_REQUEST.value());
+    }
+
+    @Test()
+    public void shouldProperlyReturnFromDeleteWithStatusOtherThenAbove() {
+        //  given
+        RestObject<HttpRequest> restObject = new RestObject<>();
+        prepareMocks(rawData,HttpStatus.NOT_EXTENDED.value(),"DELETE");
+
+        //  when
+        restMsoImplementation.Delete(httpRequest, "testObject", path, restObject);
+
+        //  then
+        assertThat(restObject.getStatusCode()).isEqualTo(HttpStatus.NOT_EXTENDED.value());
+    }
+
+    @Test( expectedExceptions = MsoTestException.class)
+    public void shouldThrowExceptionWhenCallsDeleteWithWrongParameters() {
+        //  given
+        when(mockClient.target(any(String.class))).thenThrow(new MsoTestException("testDeleteException"));
+
+        //  when
+        restMsoImplementation.Delete(httpRequest, "testObject", "", null);
+    }
+
+    @Test( expectedExceptions = NullPointerException.class)
+    public void shouldThrowExceptionWhenCallsDeleteWithWrongObjectType() {
+        //  given
+        RestObject<HttpRequest> restObject = new RestObject<>();
+        prepareMocks(rawData,HttpStatus.ACCEPTED.value(),"DELETE");
+
+        //  when
+        restMsoImplementation.Delete(null, "testObject", path, restObject);
+    }
+
+    @Test
+    public void shouldProperlyPostForObject() {
+        //  given
+        RequestDetails requestDetails = new RequestDetails();
+
+        RestObject<HttpRequest> expectedResponse = new RestObject<>();
+        expectedResponse.setStatusCode(HttpStatus.ACCEPTED.value());
+        expectedResponse.setRaw(rawData);
+
+        prepareMocks(rawData,HttpStatus.ACCEPTED.value(),"POST");
+
+        //  when
+        RestObject<HttpRequest> response = restMsoImplementation.PostForObject(requestDetails, path, HttpRequest.class);
+
+        //  then
+        assertThat(response).isEqualToComparingFieldByField(expectedResponse);
+    }
+
+    @Test
+    public void shouldProperlyDeleteForObject() {
+        //  given
+        RequestDetails requestDetails = new RequestDetails();
+
+        RestObject<HttpRequest> expectedResponse = new RestObject<>();
+        expectedResponse.setStatusCode(HttpStatus.ACCEPTED.value());
+        expectedResponse.setRaw(rawData);
+
+        prepareMocks(rawData,HttpStatus.ACCEPTED.value(),"DELETE");
+
+        //  when
+        RestObject<HttpRequest> response = restMsoImplementation.DeleteForObject(requestDetails, path, HttpRequest.class);
+
+        //  then
+        assertThat(response).isEqualToComparingFieldByField(expectedResponse);
+    }
+
+    @Test
+    public void shouldProperlyPost() {
+        //  given
+        RequestDetails requestDetails = new RequestDetails();
+        RestObject<String> response = new RestObject<>();
+
+        RestObject<String> expectedResponse = new RestObject<>();
+        expectedResponse.setStatusCode(HttpStatus.ACCEPTED.value());
+        expectedResponse.setRaw(rawData);
+
+        prepareMocks(rawData,HttpStatus.ACCEPTED.value(),"POST");
+
+        //  when
+        restMsoImplementation.Post(rawData,requestDetails, path, response);
+
+        //  then
+        assertThat(response).isEqualToComparingFieldByField(expectedResponse);
+    }
+
+    @Test
+    public void shouldProperlyPrepareClient() {
+        //  given
+        String method = "POST";
+        prepareMocks(rawData,HttpStatus.ACCEPTED.value(),method);
+
+        //  when
+        javax.ws.rs.client.Invocation.Builder response = restMsoImplementation.prepareClient(path, method);
+
+        //  then
+        assertThat(response).isEqualTo(builder);
+    }
+
+    @Test
+    public void shouldCreatRestObjectOnlyWithHttpMethod() {
+        //  given
+        String method = "GET";
+        prepareMocks(rawData,HttpStatus.ACCEPTED.value(),method);
+
+        RestObject<String> expectedResponse = new RestObject<>();
+        expectedResponse.setStatusCode(HttpStatus.ACCEPTED.value());
+        expectedResponse.setRaw(rawData);
+
+        //  when
+        RestObject<String> response = restMsoImplementation.restCall(HttpMethod.GET, String.class, null, path, Optional.empty());
+
+        //  then
+        assertThat(response).isEqualToComparingFieldByField(expectedResponse);
+    }
+
+    @Test( expectedExceptions = MsoTestException.class)
+    public void shouldThrowExceptionWhenCreateRestObjectIsCalledWithoutDefinedClient() {
+        //  given
+        when(mockClient.target(any(String.class))).thenThrow(new MsoTestException("testNoClientException"));
+
+        //  when
+        restMsoImplementation.restCall(HttpMethod.GET, String.class, null, "", Optional.empty());
+    }
+
+    @Test
+    public void shouldProperlyPutRestObjectWithProperParametersAndStatusAccepted() {
+        //  given
+        String method = "PUT";
+        prepareMocks(rawData,HttpStatus.ACCEPTED.value(),method);
+
+        org.onap.vid.changeManagement.RequestDetailsWrapper requestDetailsWrapper = new RequestDetailsWrapper();
+        RestObject<String> response = new RestObject<>();
+
+        RestObject<String> expectedResponse = new RestObject<>();
+        expectedResponse.setStatusCode(HttpStatus.ACCEPTED.value());
+        expectedResponse.set(rawData);
+
+        //  when
+        restMsoImplementation.Put("testPutBody", requestDetailsWrapper , path, response);
+
+        //  then
+        assertThat(response).isEqualToComparingFieldByField(expectedResponse);
+    }
+
+    @Test
+    public void shouldProperlyPutRestObjectWithProperParametersAndStatusMultipleChoices() {
+        //  given
+        String method = "PUT";
+        prepareMocks(rawData,HttpStatus.MULTIPLE_CHOICES.value(),method);
+
+        org.onap.vid.changeManagement.RequestDetailsWrapper requestDetailsWrapper = new RequestDetailsWrapper();
+        RestObject<String> response = new RestObject<>();
+
+        RestObject<String> expectedResponse = new RestObject<>();
+        expectedResponse.setStatusCode(HttpStatus.MULTIPLE_CHOICES.value());
+        expectedResponse.set(rawData);
+
+        //  when
+        restMsoImplementation.Put("testPutBody", requestDetailsWrapper , path, response);
+
+        //  then
+        assertThat(response).isEqualToComparingFieldByField(expectedResponse);
+    }
+
+    @Test( expectedExceptions = MsoTestException.class)
+    public void shouldThrowExceptionWhenCallsPutWithWrongParameters() {
+        //  given
+        when(mockClient.target(any(String.class))).thenThrow(new MsoTestException("testDeleteException"));
+        org.onap.vid.changeManagement.RequestDetailsWrapper requestDetailsWrapper = new RequestDetailsWrapper();
+
+        //  when
+        restMsoImplementation.Put(null, requestDetailsWrapper, "", null);
+    }
+
+    @Test( expectedExceptions = NullPointerException.class)
+    public void shouldThrowExceptionWhenCallsPutWithWrongObjectType() {
+        //  given
+        RestObject<HttpRequest> restObject = new RestObject<>();
+        org.onap.vid.changeManagement.RequestDetailsWrapper requestDetailsWrapper = new RequestDetailsWrapper();
+
+        prepareMocks(rawData,HttpStatus.ACCEPTED.value(),"DELETE");
+
+        //  when
+        restMsoImplementation.Put(null, requestDetailsWrapper, path, restObject);
+    }
+
+
+
+    private void prepareMocks(String rawData,int status,String httpMethod) {
+
+        when(mockClient.target(any(String.class))).thenReturn(webTarget);
+        when(webTarget.request()).thenReturn(builder);
+
+
+        when(builder.accept(any(String.class))).thenReturn(builder);
+        when(builder.headers(any(MultivaluedMap.class))).thenReturn(builder);
+        when(builder.get()).thenReturn(response);
+
+        when(builder.build( eq(httpMethod), any(Entity.class))).thenReturn(jerseyInvocation);
+        when(builder.build( eq(httpMethod))).thenReturn(jerseyInvocation);
+
+        when(builder.put( any(Entity.class))).thenReturn(response);
+        when(jerseyInvocation.invoke()).thenReturn(response);
+
+
+        when(response.getStatus()).thenReturn(status);
+        when(response.readEntity(String.class)).thenReturn(rawData);
+    }
+
+    private class MsoTestException extends RuntimeException{
+        MsoTestException(String testException) {
+            super(testException);
+        }
+    }
+
+}
\ No newline at end of file