Merge from ECOMP's repository

Main Features
--------------

-  Async-Instantiation jobs mechanism major update; still WIP (package
   `org.onap.vid.job`)

-  New features in View/Edit: Activate fabric configuration; show
   related networks; soft delete

-  Support AAI service-tree traversal (`AAIServiceTree`)

-  In-memory cache for SDC models and certain A&AI queries
   (`CacheProviderWithLoadingCache`)

-  Upgrade TOSCA Parser and add parsing options; fix malformed TOSCA
   models

-  Resolve Cloud-Owner values for MSO

-  Pass X-ONAP headers to MSO

Infrastructure
--------------
-  Remove codehaus' jackson mapper; use soley fasterxml 2.9.7
-  Surefire invokes both TestNG and JUnit tests
-  Support Kotlin source files
-  AaiController2 which handles errors in a "Spring manner"
-  Inline generated-sources and remove jsonschema2pojo

Quality
--------
-  Cumulative bug fixes (A&AI API, UI timeouts, and many more)
-  Many Sonar issues cleaned-up
-  Some unused classes removed
-  Minor changes in vid-automation project, allowing some API
   verification to run

Hard Merges
------------
-  HTTP Clients (MSO, A&AI, WebConfig, OutgoingRequestHeadersTest)
-  Moved `package org.onap.vid.controllers` to `controller`, without
   plural -- just to keep semantic sync with ECOMP.

Reference commit in ECOMP: 3d1141625

Issue-ID: VID-378
Change-Id: I9c8d1e74caa41815891d441fc0760bb5f29c5788
Signed-off-by: Ittay Stern <ittay.stern@att.com>

1 files changed, 120 insertions, 0 deletions

diff --git a/vid-app-common/src/test/java/org/onap/vid/controller/AaiServiceInstanceStandardQueryControllerTest.java b/vid-app-common/src/test/java/org/onap/vid/controller/AaiServiceInstanceStandardQueryControllerTest.java
new file mode 100644
index 000000000..9a5ee3ecb
--- /dev/null
+++ b/vid-app-common/src/test/java/org/onap/vid/controller/AaiServiceInstanceStandardQueryControllerTest.java
@@ -0,0 +1,120 @@
+package org.onap.vid.controller;
+
+import org.mockito.Answers;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.onap.vid.aai.util.ServiceInstanceStandardQuery;
+import org.onap.vid.asdc.AsdcCatalogException;
+import org.onap.vid.model.Service;
+import org.onap.vid.model.ServiceModel;
+import org.onap.vid.model.VidNotions;
+import org.onap.vid.model.VidNotions.ModelCategory;
+import org.onap.vid.properties.Features;
+import org.onap.vid.services.VidService;
+import org.springframework.mock.web.MockHttpServletRequest;
+import org.testng.annotations.AfterMethod;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+import org.togglz.core.manager.FeatureManager;
+
+import java.util.UUID;
+
+import static org.hamcrest.Matchers.hasSize;
+import static org.junit.Assert.assertThat;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.*;
+
+public class AaiServiceInstanceStandardQueryControllerTest {
+
+    @InjectMocks
+    private AaiServiceInstanceStandardQueryController aaiServiceInstanceStandardQueryController;
+
+    @Mock
+    private FeatureManager featureManager;
+
+    @Mock
+    private VidService sdcService;
+
+    @Mock(answer = Answers.RETURNS_MOCKS)
+    private ServiceInstanceStandardQuery serviceInstanceStandardQuery;
+
+    //Don't use initMocks with @BeforeMethod
+    //because AaiServiceInstanceStandardQueryController contains final members that can not be injected twice
+    //See https://stackoverflow.com/questions/20046210/mockito-injectmocks-strange-behaviour-with-final-fields?answertab=active#tab-top
+    @BeforeClass
+    public void initMocks() {
+        MockitoAnnotations.initMocks(this);
+    }
+
+    @AfterMethod
+    public void resetMocks() {
+        reset(sdcService, featureManager, serviceInstanceStandardQuery);
+    }
+
+    @Test
+    public void getNetworksToVlansByServiceInstance_given5G_PROVIDER_NETWORK_aaiIsAccessed() throws AsdcCatalogException {
+        //  - turn on FLAG_PRESENT_PROVIDER_NETWORKS
+        //  - mock an model with 5G_PROVIDER_NETWORK
+        //  - request it's AAI network->vlan mapping
+        //  - assert that AAI was accessed
+
+        when(featureManager.isActive(Features.FLAG_PRESENT_PROVIDER_NETWORKS_ASSOCIATIONS)).thenReturn(true);
+
+        final UUID randomModelUuid = UUID.randomUUID();
+        mockServiceModel(ModelCategory.IS_5G_PROVIDER_NETWORK_MODEL, randomModelUuid);
+
+        doGetNetworksToVlansByServiceInstance(randomModelUuid);
+
+        verify(serviceInstanceStandardQuery).fetchServiceInstance(any(), any(), any());
+    }
+
+    @Test
+    public void getNetworksToVlansByServiceInstance_givenNon5G_PROVIDER_NETWORK_aaiIsNotAccessed() throws AsdcCatalogException {
+        //  - turn on FLAG_PRESENT_PROVIDER_NETWORKS
+        //  - mock an model without 5G_PROVIDER_NETWORK (i.e. OTHER)
+        //  - request it's AAI network->vlan mapping
+        //  - assert that AAI was not accessed
+        //  - empty result was responded
+
+        when(featureManager.isActive(Features.FLAG_PRESENT_PROVIDER_NETWORKS_ASSOCIATIONS)).thenReturn(true);
+
+        final UUID randomModelUuid = UUID.randomUUID();
+        mockServiceModel(ModelCategory.OTHER, randomModelUuid);
+
+        assertThat(doGetNetworksToVlansByServiceInstance(randomModelUuid).serviceNetworks, hasSize(0));
+        verifyZeroInteractions(serviceInstanceStandardQuery);
+    }
+
+    @Test
+    public void isModelOf5g_givenServiceWithFabricConfiguration_returnTrue() throws AsdcCatalogException {
+        final UUID randomModelUuid = UUID.randomUUID();
+        mockServiceModel(ModelCategory.IS_5G_FABRIC_CONFIGURATION_MODEL, randomModelUuid, VidNotions.InstantiationUI.SERVICE_WITH_FABRIC_CONFIGURATION);
+
+        assertTrue(aaiServiceInstanceStandardQueryController.isModelOf5g(randomModelUuid));
+    }
+
+    private void mockServiceModel(ModelCategory modelCategory, UUID randomModelUuid) throws AsdcCatalogException {
+        mockServiceModel(modelCategory, randomModelUuid, VidNotions.InstantiationUI.LEGACY);
+    }
+
+    private void mockServiceModel(ModelCategory modelCategory, UUID randomModelUuid, VidNotions.InstantiationUI instantiationUI) throws AsdcCatalogException {
+        ServiceModel mockedModel = mock(ServiceModel.class);
+        Service mockedService = mock(Service.class);
+        when(mockedModel.getService()).thenReturn(mockedService);
+        when(mockedService.getVidNotions()).thenReturn(
+                new VidNotions(instantiationUI, modelCategory, VidNotions.InstantiationUI.LEGACY)
+        );
+
+        when(sdcService.getService(randomModelUuid.toString())).thenReturn(mockedModel);
+    }
+
+    private AaiServiceInstanceStandardQueryController.VlansByNetworksHierarchy doGetNetworksToVlansByServiceInstance(UUID randomModelUuid) throws AsdcCatalogException {
+        return aaiServiceInstanceStandardQueryController.getNetworksToVlansByServiceInstance(
+                new MockHttpServletRequest(),
+                randomModelUuid,
+                "my global customer id",
+                "my service type",
+                "my instance id");
+    }
+}
\ No newline at end of file