Refactor of an AAIRestInterface

Refactor and some additional tests added

(cherry picked from commit 6d8fa7d179b8de802ae386b317ddd1214eac1c47)

Change-Id: Ibe7583353499352aa81d100b9995b9c74133c447
Issue-ID: VID-229
Signed-off-by: Stern, Ittay (is9613) <is9613@att.com>
[Added proper headers to modified and created files]
Signed-off-by: golabek <tomasz.golabek@nokia.com>

1 files changed, 77 insertions, 5 deletions

diff --git a/vid-app-common/src/test/java/org/onap/vid/aai/util/HttpsAuthClientTest.java b/vid-app-common/src/test/java/org/onap/vid/aai/util/HttpsAuthClientTest.java
index a26c431e8..f000dc801 100644
--- a/vid-app-common/src/test/java/org/onap/vid/aai/util/HttpsAuthClientTest.java
+++ b/vid-app-common/src/test/java/org/onap/vid/aai/util/HttpsAuthClientTest.java
@@ -1,22 +1,94 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * VID
+ * ================================================================================
+ * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * Modifications Copyright (C) 2018 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
 package org.onap.vid.aai.util;
 
+import org.junit.Before;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.runners.MockitoJUnitRunner;
+import org.onap.vid.aai.exceptions.HttpClientBuilderException;
+
+import javax.net.ssl.SSLContext;
+import java.util.Optional;
+
+import static org.mockito.Matchers.anyString;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
 
+@RunWith(MockitoJUnitRunner.class)
 public class HttpsAuthClientTest {
+    @Mock
+    private SystemPropertyHelper systemPropertyHelper;
+    @Mock
+    private SSLContextProvider sslContextProvider;
+    @Mock
+    private SSLContext sslContext;
+
+    public static final String CERT_FILE_PATH = "any_path";
 
     /*
     TO BE IMPLEMENTED
     
     private HttpsAuthClient createTestSubject() {
-        return new HttpsAuthClient();
+        return new HttpsAuthClient(systemPropertyHelper, sslContextProvider);
+    }
+
+    @Before
+    public void setUp() throws Exception {
+        when(systemPropertyHelper.getAAITruststoreFilename()).thenReturn(Optional.of("filename"));
+        when(systemPropertyHelper.getEncodedTruststorePassword()).thenReturn("password");
+    }
+
+    @Test(expected = HttpClientBuilderException.class)
+    public void testHttpClientBuilderExceptionOnGetClient() throws HttpClientBuilderException {
+        //when
+        when(systemPropertyHelper.getAAIUseClientCert()).thenReturn(Optional.of("true"));
+        when(sslContextProvider.getSslContext(anyString(), anyString())).thenThrow(new HttpClientBuilderException());
+        createTestSubject().getClient("nonExistingFile");
+    }
+
+    @Test
+    public void testGetSecuredClient() throws Exception {
+        // when
+        when(systemPropertyHelper.getAAIUseClientCert()).thenReturn(Optional.of("true"));
+        when(sslContextProvider.getSslContext(anyString(), anyString())).thenReturn(sslContext);
+        createTestSubject().getClient(CERT_FILE_PATH);
+
+        //then
+        verify(sslContextProvider).getSslContext(anyString(), anyString());
     }
 
     @Test
-    public void testGetClient() throws Exception {
-        String certFilePath = "";
+    public void testGetUnsecuredClient() throws Exception {
+        // when
+        when(systemPropertyHelper.getAAIUseClientCert()).thenReturn(Optional.of("false"));
+        when(sslContextProvider.getSslContext(anyString(), anyString())).thenReturn(sslContext);
+        createTestSubject().getClient(CERT_FILE_PATH);
 
-        // default test
-        HttpsAuthClient.getClient(certFilePath);
+        //then
+        verify(sslContextProvider, never()).getSslContext(anyString(), anyString());
     }
     */
 }
\ No newline at end of file