aboutsummaryrefslogtreecommitdiffstats
path: root/mso-api-handlers/mso-api-handler-common
diff options
context:
space:
mode:
authorsurya-huawei <a.u.surya@huawei.com>2017-09-26 18:34:28 +0530
committerSURYA A U <a.u.surya@huawei.com>2017-09-27 03:11:28 +0000
commit12a133db6d235b015d3c5cdd2f61952501b36597 (patch)
tree3997628284a29e9e35d394a85573999a5fc1992b /mso-api-handlers/mso-api-handler-common
parent3065620fde4e78b2c2003ef1d912c36af0b0b61a (diff)
Fix some major sonar issues
*Use collection.isEmpty() instead of collection.size *Remove unnecessary commented line This is done for increasing code readability *Pass the string object directly Instead of wrapping the returned object and creating a new object, passing the object itself will save memory Issue-Id: SO-118 Change-Id: I24c15e9270ec3422d35d3910a8aff9fcf8d632d9 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Diffstat (limited to 'mso-api-handlers/mso-api-handler-common')
-rw-r--r--mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java
index a73eec578d..cd23991875 100644
--- a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java
+++ b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java
@@ -60,7 +60,7 @@ public class BPELRestClient extends RequestClient {
CommonConstants.ENCRYPTION_KEY);
if (userCredentials != null) {
post.addHeader ("Authorization",
- "Basic " + new String (DatatypeConverter.printBase64Binary (userCredentials.getBytes ())));
+ "Basic " + DatatypeConverter.printBase64Binary (userCredentials.getBytes ()));
}
}
}