aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSeshu Kumar M <seshu.kumar.m@huawei.com>2017-09-28 13:18:38 +0000
committerGerrit Code Review <gerrit@onap.org>2017-09-28 13:18:38 +0000
commit5fe627a94b0cc6c424d2e4a513986e7a813dc594 (patch)
tree647b5f45aaa0031f896649bd744178853d675c87
parentafaf3e49d3a6413b5e7fcebe9611c8befb488adb (diff)
parent12a133db6d235b015d3c5cdd2f61952501b36597 (diff)
Merge "Fix some major sonar issues"
-rw-r--r--adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/BpelRestClient.java2
-rw-r--r--adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java1
-rw-r--r--mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java2
3 files changed, 2 insertions, 3 deletions
diff --git a/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/BpelRestClient.java b/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/BpelRestClient.java
index b7ab5043f3..6c571f3e06 100644
--- a/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/BpelRestClient.java
+++ b/adapters/mso-network-adapter/src/main/java/org/openecomp/mso/adapters/network/BpelRestClient.java
@@ -166,7 +166,7 @@ public class BpelRestClient {
}
public String getRetryList() {
- if (retryList.size() == 0)
+ if (retryList.isEmpty())
return "";
String t = retryList.toString();
return t.substring(1, t.length()-1);
diff --git a/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java b/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java
index 6dc0dc35d9..7df05f8b43 100644
--- a/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java
+++ b/adapters/mso-vnf-adapter/src/main/java/org/openecomp/mso/adapters/vnf/BpelRestClient.java
@@ -234,7 +234,6 @@ public class BpelRestClient {
}
private void debug(String m) {
LOGGER.debug(m);
-// System.err.println(m);
}
private void sendOne(final String toBpelStr, final String bpelUrl, final boolean isxml) {
LOGGER.debug("Sending to BPEL server: "+bpelUrl);
diff --git a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java
index a73eec578d..cd23991875 100644
--- a/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java
+++ b/mso-api-handlers/mso-api-handler-common/src/main/java/org/openecomp/mso/apihandler/common/BPELRestClient.java
@@ -60,7 +60,7 @@ public class BPELRestClient extends RequestClient {
CommonConstants.ENCRYPTION_KEY);
if (userCredentials != null) {
post.addHeader ("Authorization",
- "Basic " + new String (DatatypeConverter.printBase64Binary (userCredentials.getBytes ())));
+ "Basic " + DatatypeConverter.printBase64Binary (userCredentials.getBytes ()));
}
}
}