1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
|
/*-
* ============LICENSE_START=======================================================
* SDC
* ================================================================================
* Copyright (C) 2020 AT&T Intellectual Property. All rights reserved.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
* ============LICENSE_END=========================================================
*/
package org.openecomp.sdc.asdctool.migration.tasks.mig1902;
import fj.data.Either;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnitRunner;
import org.openecomp.sdc.asdctool.migration.core.task.MigrationResult;
import org.openecomp.sdc.be.dao.janusgraph.JanusGraphOperationStatus;
import org.openecomp.sdc.be.dao.jsongraph.GraphVertex;
import org.openecomp.sdc.be.dao.jsongraph.JanusGraphDao;
import org.openecomp.sdc.be.dao.jsongraph.types.EdgeLabelEnum;
import org.openecomp.sdc.be.dao.jsongraph.types.JsonParseFlagEnum;
import org.openecomp.sdc.be.dao.jsongraph.types.VertexTypeEnum;
import org.openecomp.sdc.be.datatypes.elements.GroupDataDefinition;
import org.openecomp.sdc.be.datatypes.elements.PropertyDataDefinition;
import org.openecomp.sdc.be.model.GroupTypeDefinition;
import org.openecomp.sdc.be.model.PropertyDefinition;
import org.openecomp.sdc.be.model.operations.api.StorageOperationStatus;
import org.openecomp.sdc.be.model.operations.impl.GroupTypeOperation;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import static org.junit.Assert.assertEquals;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyMap;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
@RunWith(MockitoJUnitRunner.class)
public class SdcGroupsMigrationTest {
@Mock
private JanusGraphDao janusGraphDao;
@Mock
private GroupTypeOperation groupTypeOperation;
@Mock
private GraphVertex topologyTemplateVertex;
@Mock
private GraphVertex groupsVertex;
@InjectMocks
private SdcGroupsMigration groupsMigration;
@Before
public void setUp() {
groupsMigration = new SdcGroupsMigration(janusGraphDao, groupTypeOperation);
when(janusGraphDao.getVertexById(any())).thenReturn(Either.left(topologyTemplateVertex));
}
@Test
public void handleOneContainerWhenErrorHappened() {
when(janusGraphDao.getChildVertex(any(GraphVertex.class), eq(EdgeLabelEnum.GROUPS), eq(JsonParseFlagEnum.ParseAll)))
.thenReturn(Either.right(JanusGraphOperationStatus.MATCH_NOT_FOUND));
StorageOperationStatus status = groupsMigration.handleOneContainer(topologyTemplateVertex);
assertEquals(StorageOperationStatus.MATCH_NOT_FOUND, status);
}
@Test
public void handleOneContainerWhenNoGroups() {
when(janusGraphDao.getChildVertex(any(GraphVertex.class), eq(EdgeLabelEnum.GROUPS), eq(JsonParseFlagEnum.ParseAll)))
.thenReturn(Either.right(JanusGraphOperationStatus.NOT_FOUND));
StorageOperationStatus status = groupsMigration.handleOneContainer(topologyTemplateVertex);
assertEquals(StorageOperationStatus.OK, status);
}
@Test
public void handleOneContainerWhenGroupsShouldNotBeUpdated() {
when(janusGraphDao.getChildVertex(any(GraphVertex.class), eq(EdgeLabelEnum.GROUPS), eq(JsonParseFlagEnum.ParseAll)))
.thenReturn(Either.left(groupsVertex));
doReturn(buildGroupInstancesMap(new String[] {"org.openecomp.groups.heat.HeatStack", "org.openecomp.groups.VfModule"}, new String[]{}))
.when(groupsVertex).getJson();
StorageOperationStatus status = groupsMigration.handleOneContainer(topologyTemplateVertex);
assertEquals(StorageOperationStatus.OK, status);
verify(janusGraphDao, times(0)).commit();
}
@Test
public void handleOneContainerWhenGroupsShouldBeUpdated() {
mockLatestGroupMapCreating();
mockUpgradeHappyFlow();
StorageOperationStatus status = groupsMigration.handleOneContainer(topologyTemplateVertex);
assertEquals(StorageOperationStatus.OK, status);
verify(janusGraphDao, times(1)).commit();
verify(janusGraphDao, times(0)).rollback();
}
private void mockUpgradeHappyFlow() {
when(janusGraphDao.getChildVertex(any(GraphVertex.class), eq(EdgeLabelEnum.GROUPS), eq(JsonParseFlagEnum.ParseAll)))
.thenReturn(Either.left(groupsVertex));
when(janusGraphDao.updateVertex(any(GraphVertex.class))).thenReturn(Either.left(groupsVertex));
when(janusGraphDao.commit()).thenReturn(JanusGraphOperationStatus.OK);
doReturn(buildGroupInstancesMap(new String[] {"org.openecomp.groups.NetworkCollection", "org.openecomp.groups.VfcInstanceGroup"},
new String[] {"old1", "old2"}))
.when(groupsVertex).getJson();
}
@Test
public void handleOneContainerWhenGroupsAlreadyUpdated() {
mockLatestGroupMapCreating();
when(janusGraphDao.getChildVertex(any(GraphVertex.class), eq(EdgeLabelEnum.GROUPS), eq(JsonParseFlagEnum.ParseAll)))
.thenReturn(Either.left(groupsVertex));
doReturn(buildGroupInstancesMap(new String[] {"org.openecomp.groups.NetworkCollection"},
new String[] {"a", "b", "c", "d"}))
.when(groupsVertex).getJson();
StorageOperationStatus status = groupsMigration.handleOneContainer(topologyTemplateVertex);
assertEquals(StorageOperationStatus.OK, status);
verify(janusGraphDao, times(0)).commit();
verify(janusGraphDao, times(1)).rollback();
}
@Test
public void handleOneContainerWhenExceptionIsThrown() {
when(janusGraphDao.getChildVertex(any(GraphVertex.class), eq(EdgeLabelEnum.GROUPS), eq(JsonParseFlagEnum.ParseAll)))
.thenThrow(new RuntimeException());
StorageOperationStatus status = groupsMigration.handleOneContainer(topologyTemplateVertex);
assertEquals(StorageOperationStatus.GENERAL_ERROR, status);
verify(janusGraphDao, times(0)).commit();
verify(janusGraphDao, times(1)).rollback();
}
// A temp remark for this test - following Commit hash: 08595ad21b0c409c69e3902232f5575963199e3e [ASDC-641] – Migration workaround for deployment artifact timeout. Reviewer: Lior.
// @Test
// public void migrateWhenExceptionIsThrown() {
// List<GraphVertex> vertexList = new ArrayList<>();
// vertexList.add(topologyTemplateVertex);
// mockLatestGroupMapCreating();
// when(janusGraphDao.getByCriteria(eq(VertexTypeEnum.TOPOLOGY_TEMPLATE), eq(null), anyMap(), eq(JsonParseFlagEnum.ParseAll)))
// .thenReturn(Either.left(vertexList));
// when(janusGraphDao.getChildVertex(any(GraphVertex.class), eq(EdgeLabelEnum.GROUPS), eq(JsonParseFlagEnum.ParseAll)))
// .thenThrow(new RuntimeException());
// assertEquals(MigrationResult.MigrationStatus.FAILED, groupsMigration.migrate().getMigrationStatus());
// verify(janusGraphDao, times(0)).commit();
// verify(janusGraphDao, times(1)).rollback();
//
// }
@Test
public void migrateWhenGroupsShouldBeUpdated() {
List<GraphVertex> vertexList = new ArrayList<>();
vertexList.add(topologyTemplateVertex);
mockLatestGroupMapCreating();
when(janusGraphDao.getByCriteria(eq(VertexTypeEnum.TOPOLOGY_TEMPLATE), eq(null), anyMap(), eq(JsonParseFlagEnum.ParseAll)))
.thenReturn(Either.left(vertexList));
mockUpgradeHappyFlow();
assertEquals(MigrationResult.MigrationStatus.COMPLETED, groupsMigration.migrate().getMigrationStatus());
verify(janusGraphDao, times(1)).commit();
verify(janusGraphDao, times(0)).rollback();
}
private Map<String, GroupDataDefinition> buildGroupInstancesMap(String[] groupTypes, String [] propertyNames) {
Map<String, GroupDataDefinition> groupsMap = new HashMap<>();
for (String type: groupTypes) {
GroupDataDefinition gr = new GroupDataDefinition();
gr.setType(type);
gr.setProperties(createInstanceProperties(propertyNames));
groupsMap.put(gr.getType(), gr);
}
return groupsMap;
}
private void mockLatestGroupMapCreating() {
doReturn(Either.left(createTypeDefinition(new String[] {"a", "b", "c", "d"})))
.when(groupTypeOperation).getLatestGroupTypeByType(eq(SdcGroupsMigration.GroupsForUpgrade.NW_COLLECTION_GROUP_NAME.getToscaType()), eq(false));
doReturn(Either.left(createTypeDefinition(new String[] {"l", "m", "n", "o", "p"})))
.when(groupTypeOperation).getLatestGroupTypeByType(eq(SdcGroupsMigration.GroupsForUpgrade.VFC_INSTANCE_GROUP_NAME.getToscaType()), eq(false));
groupsMigration.loadLatestGroupTypeDefinitions();
}
private GroupTypeDefinition createTypeDefinition(String[] propertyNames) {
GroupTypeDefinition typeDefinition = new GroupTypeDefinition();
typeDefinition.setProperties(createTypeProperties(propertyNames));
return typeDefinition;
}
private List<PropertyDefinition> createTypeProperties(String[] propertyNames) {
List<PropertyDefinition> propertyDefinitionList = new ArrayList<>();
for (String name: propertyNames) {
PropertyDefinition propertyDefinition = new PropertyDefinition();
propertyDefinition.setName(name);
propertyDefinitionList.add(propertyDefinition);
}
return propertyDefinitionList;
}
private List<PropertyDataDefinition> createInstanceProperties(String[] propertyNames) {
List<PropertyDataDefinition> propertyDefinitionList = new ArrayList<>();
for (String name: propertyNames) {
PropertyDefinition propertyDefinition = new PropertyDefinition();
propertyDefinition.setName(name);
propertyDefinitionList.add(propertyDefinition);
}
return propertyDefinitionList;
}
}
|
