Fix - Port type and vmtype underscore issue

1. Fix for consolidation of VMs for cases when:
   a. VM type contains an underscore
   b. Multiple ports per network role
2. Updated the unit test cases and test data

Change-Id: I875f3c8384f8ef2c2aa6add9e30a5f8899ae1a71
Issue-ID: SDC-1966
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>

5 files changed, 20 insertions, 20 deletions

diff --git a/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/main.yml b/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/main.yml
index 8dc7b43734..eedaf27870 100644
--- a/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/main.yml
+++ b/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/main.yml
@@ -119,14 +119,14 @@ resources:
 
   ########### PATTERN 1C1 #################
 
-  cmaui_port_01:
+  cmaui_1c1_main_1_mgmt_port_0:
     type: OS::Neutron::Port
     properties:
       network: { get_param: contrail_net_name}
       fixed_ips: [{"ip_address": {get_param: [cmaui_oam_ips, 0]}}]
       replacement_policy: AUTO
 
-  cmaui_port_02:
+  cmaui_1c1_main_2_mgmt_port_0:
     type: OS::Neutron::Port
     properties:
       network: { get_param: contrail_net_name}
@@ -145,7 +145,7 @@ resources:
       availability_zone: { get_param: availability_zone_0 }
       flavor: { get_param: cmaui_1c1_main_flavor }
       networks:
-      - port: { get_resource: cmaui_port_01 }
+      - port: { get_resource: cmaui_1c1_main_1_mgmt_port_0 }
 
   server_main_1c1_cmaui_2:
     type: OS::Nova::Server
@@ -159,7 +159,7 @@ resources:
       availability_zone: { get_param: availability_zone_0 }
       flavor: { get_param: cmaui_1c1_main_flavor }
       networks:
-      - port: { get_resource: cmaui_port_02 }
+      - port: { get_resource: cmaui_1c1_main_2_mgmt_port_0 }
 
   ########### PATTERN 4 #################
 
diff --git a/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested-pattern-4-same-type.yml b/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested-pattern-4-same-type.yml
index d957b399c8..b205ee8189 100644
--- a/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested-pattern-4-same-type.yml
+++ b/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested-pattern-4-same-type.yml
@@ -34,14 +34,14 @@ parameters:
     type: string
 resources:
 
-  pd_server_pattern4_port_1:
+  pd_server_pattern4_0_mgmt_port_0:
     type: OS::Neutron::Port
     properties:
       network: { get_param: net }
       fixed_ips: [{"ip_address": {get_param: [pd_server_pattern4_ips, 0]}}]
       replacement_policy: AUTO
 
-  pd_server_pattern4_port_2:
+  pd_server_pattern4_1_mgmt_port_0:
     type: OS::Neutron::Port
     properties:
       network: { get_param: net }
@@ -56,8 +56,8 @@ resources:
       availability_zone: { get_param: availability_zone_0 }
       flavor: { get_param: pd_server_pattern4_flavor }
       networks:
-      - port: { get_resource: pd_server_pattern4_port_1 }
-      - port: { get_resource: pd_server_pattern4_port_2 }
+      - port: { get_resource: pd_server_pattern4_0_mgmt_port_0 }
+      - port: { get_resource: pd_server_pattern4_1_mgmt_port_0 }
 
 outputs:
   pattern4_attr_1:
diff --git a/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested-pattern-4.yml b/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested-pattern-4.yml
index 68c93f53d3..373a967506 100644
--- a/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested-pattern-4.yml
+++ b/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested-pattern-4.yml
@@ -34,14 +34,14 @@ parameters:
     type: string
 resources:
 
-  pd_server_pattern4_port_01:
+  pd_server_pattern4_1_oam_port_0:
     type: OS::Neutron::Port
     properties:
       network: { get_param: net }
       fixed_ips: [{"ip_address": {get_param: [pd_server_pattern4_ips, 0]}}]
       replacement_policy: AUTO
 
-  pd_server_pattern4_port_02:
+  pd_server_pattern4_0_oam_port_0:
     type: OS::Neutron::Port
     properties:
       network: { get_param: net }
@@ -56,8 +56,8 @@ resources:
       availability_zone: { get_param: availability_zone_0 }
       flavor: { get_param: pd_server_pattern4_flavor }
       networks:
-      - port: { get_resource: pd_server_pattern4_port_01 }
-      - port: { get_resource: pd_server_pattern4_port_02 }
+      - port: { get_resource: pd_server_pattern4_1_oam_port_0 }
+      - port: { get_resource: pd_server_pattern4_0_oam_port_0 }
 
 outputs:
   pattern4_attr_1:
diff --git a/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested1.yml b/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested1.yml
index 59312c6bba..af3eab7940 100644
--- a/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested1.yml
+++ b/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested1.yml
@@ -107,14 +107,14 @@ resources:
 
   ########### PATTERN 1C1 (same type as main) #################
 
-  cmaui_port_11:
+  cmaui_1c1_main_11_mgmt_port_0:
     type: OS::Neutron::Port
     properties:
       network: { get_param: contrail_net_name}
       fixed_ips: [{"ip_address": {get_param: [cmaui_oam_ips, 0]}}]
       replacement_policy: AUTO
 
-  cmaui_port_12:
+  cmaui_1c1_main_21_mgmt_port_0:
     type: OS::Neutron::Port
     properties:
       network: { get_param: contrail_net_name}
@@ -133,7 +133,7 @@ resources:
       availability_zone: { get_param: availability_zone_0 }
       flavor: { get_param: cmaui_1c1_main_flavor }
       networks:
-      - port: { get_resource: cmaui_port_11 }
+      - port: { get_resource: cmaui_1c1_main_11_mgmt_port_0 }
 
   server_main_1c1_cmaui_21:
     type: OS::Nova::Server
@@ -147,7 +147,7 @@ resources:
       availability_zone: { get_param: availability_zone_0 }
       flavor: { get_param: cmaui_1c1_main_flavor }
       networks:
-      - port: { get_resource: cmaui_port_12 }
+      - port: { get_resource: cmaui_1c1_main_21_mgmt_port_0 }
 
   ########### PATTERN 4 (same type as main) #################
 
diff --git a/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested2.yml b/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested2.yml
index 930b165ed3..16634bcea2 100644
--- a/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested2.yml
+++ b/openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/allPatternsDependsOnConnectivity/in/nested2.yml
@@ -121,14 +121,14 @@ resources:
 
   ########### PATTERN 1C1 #################
 
-  cmaui_port_1:
+  cmaui_1c1_nested2_1_mgmt_port_0:
     type: OS::Neutron::Port
     properties:
       network: { get_param: contrail_net_name}
       fixed_ips: [{"ip_address": {get_param: [cmaui_oam_ips, 0]}}]
       replacement_policy: AUTO
 
-  cmaui_port_2:
+  cmaui_1c1_nested2_2_mgmt_port_0:
     type: OS::Neutron::Port
     properties:
       network: { get_param: contrail_net_name}
@@ -148,7 +148,7 @@ resources:
       availability_zone: { get_param: availability_zone_0 }
       flavor: { get_param: cmaui_1c1_nested2_flavor }
       networks:
-      - port: { get_resource: cmaui_port_1 }
+      - port: { get_resource: cmaui_1c1_nested2_1_mgmt_port_0 }
 
   server_nested2_1c1_cmaui_2:
     type: OS::Nova::Server
@@ -163,7 +163,7 @@ resources:
       availability_zone: { get_param: availability_zone_0 }
       flavor: { get_param: cmaui_1c1_nested2_flavor }
       networks:
-      - port: { get_resource: cmaui_port_2 }
+      - port: { get_resource: cmaui_1c1_nested2_2_mgmt_port_0 }
 
   ########### PATTERN 4 #################