aboutsummaryrefslogtreecommitdiffstats
path: root/openecomp-be/backend/openecomp-sdc-item-permissions-manager/src/test
diff options
context:
space:
mode:
authorvasraz <vasyl.razinkov@est.tech>2021-02-19 19:04:13 +0000
committerChristophe Closset <christophe.closset@intl.att.com>2021-02-20 07:46:00 +0000
commitdb65955fc93a81911ef66ab88b380dc1a5926dce (patch)
treedbc27f8b2b5cd72fbb825288dc0c4a4ade3d1ad9 /openecomp-be/backend/openecomp-sdc-item-permissions-manager/src/test
parentd6992c860be02a4c88b8f49234d8ee7e117dd60a (diff)
Fix BLOCKER BUGs reported by Sonar
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech> Change-Id: I00c466ac3fcbe8fab4629aed3a36bb2d8af3a970 Issue-ID: SDC-3472
Diffstat (limited to 'openecomp-be/backend/openecomp-sdc-item-permissions-manager/src/test')
-rw-r--r--openecomp-be/backend/openecomp-sdc-item-permissions-manager/src/test/java/org/openecomp/sdc/itempermissions/dao/impl/PermissionsManagerImplTest.java214
1 files changed, 110 insertions, 104 deletions
diff --git a/openecomp-be/backend/openecomp-sdc-item-permissions-manager/src/test/java/org/openecomp/sdc/itempermissions/dao/impl/PermissionsManagerImplTest.java b/openecomp-be/backend/openecomp-sdc-item-permissions-manager/src/test/java/org/openecomp/sdc/itempermissions/dao/impl/PermissionsManagerImplTest.java
index e124f841e7..2755edeafd 100644
--- a/openecomp-be/backend/openecomp-sdc-item-permissions-manager/src/test/java/org/openecomp/sdc/itempermissions/dao/impl/PermissionsManagerImplTest.java
+++ b/openecomp-be/backend/openecomp-sdc-item-permissions-manager/src/test/java/org/openecomp/sdc/itempermissions/dao/impl/PermissionsManagerImplTest.java
@@ -16,7 +16,32 @@
package org.openecomp.sdc.itempermissions.dao.impl;
-import org.mockito.*;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.verify;
+import static org.openecomp.sdc.itempermissions.notifications.NotificationConstants.ITEM_ID_PROP;
+import static org.openecomp.sdc.itempermissions.notifications.NotificationConstants.PERMISSION_CHANGED;
+import static org.openecomp.sdc.itempermissions.notifications.NotificationConstants.PERMISSION_GRANTED;
+import static org.openecomp.sdc.itempermissions.notifications.NotificationConstants.PERMISSION_ITEM;
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertTrue;
+
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.ArgumentCaptor;
+import org.mockito.Captor;
+import org.mockito.InjectMocks;
+import org.mockito.Matchers;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.mockito.junit.jupiter.MockitoExtension;
import org.openecomp.sdc.common.errors.CoreException;
import org.openecomp.sdc.common.session.SessionContextProviderFactory;
import org.openecomp.sdc.itempermissions.PermissionsServices;
@@ -25,123 +50,104 @@ import org.openecomp.sdc.notification.services.NotificationPropagationManager;
import org.openecomp.sdc.notification.services.SubscriptionService;
import org.openecomp.sdc.versioning.AsdcItemManager;
import org.openecomp.sdc.versioning.types.Item;
-import org.testng.annotations.BeforeMethod;
-import org.testng.annotations.Test;
-import java.util.Collections;
-import java.util.HashSet;
-import java.util.Map;
-import java.util.Set;
-import java.util.stream.Collectors;
-import java.util.stream.Stream;
+@ExtendWith(MockitoExtension.class)
+class PermissionsManagerImplTest {
+
+ private static final String ITEM1_ID = "1";
+ private static final String PERMISSION = "Contributor";
+ private static final String ACTION = "Change_Item_Permissions";
+ private static final String USER = "user";
+ private static final String AFFECTED_USER1 = "affected_user1";
+ private static final String AFFECTED_USER2 = "affected_user2";
+ private static final String AFFECTED_USER3 = "affected_user3";
+ private static final String tenant = "dox";
+
+ @Mock
+ private PermissionsServices permissionsServicesMock;
+ @Mock
+ private AsdcItemManager asdcItemManagerMock;
+ @Mock
+ private SubscriptionService subscriptionServiceMock;
+ @Mock
+ private NotificationPropagationManager notifierMock;
+ @Captor
+ private ArgumentCaptor<Event> eventArgumentCaptor;
+
+ @InjectMocks
+ private PermissionsManagerImpl permissionsManager;
+
+ @BeforeEach
+ public void setUp() throws Exception {
+ SessionContextProviderFactory.getInstance().createInterface().create(USER,
+ tenant);
+ MockitoAnnotations.initMocks(this);
+ }
-import static org.mockito.Mockito.doReturn;
-import static org.mockito.Mockito.verify;
-import static org.openecomp.sdc.itempermissions.notifications.NotificationConstants.*;
-import static org.testng.Assert.assertEquals;
-import static org.testng.Assert.assertTrue;
+ @Test
+ void testUpdateItemPermissionsWhenNotAllowed() {
+ doReturn(false).when(permissionsServicesMock).isAllowed(ITEM1_ID, USER, ACTION);
+ final HashSet<String> removedUsersIds = new HashSet<>();
+ final Set<String> addedUsersIds = Collections.singleton(AFFECTED_USER1);
+ Assertions.assertThrows(CoreException.class, () -> {
+ permissionsManager.updateItemPermissions(ITEM1_ID, PERMISSION, addedUsersIds, removedUsersIds);
+ });
+ }
-/**
- * Created by ayalaben on 7/6/2017
- */
-public class PermissionsManagerImplTest {
-
- private static final String ITEM1_ID = "1";
- private static final String PERMISSION = "Contributor";
- private static final String ACTION = "Change_Item_Permissions";
- private static final String USER = "user";
- private static final String AFFECTED_USER1 = "affected_user1";
- private static final String AFFECTED_USER2 = "affected_user2";
- private static final String AFFECTED_USER3 = "affected_user3";
- private static final String tenant = "dox";
-
- @Mock
- private PermissionsServices permissionsServicesMock;
- @Mock
- private AsdcItemManager asdcItemManagerMock;
- @Mock
- private SubscriptionService subscriptionServiceMock;
- @Mock
- private NotificationPropagationManager notifierMock;
- @Captor
- private ArgumentCaptor<Event> eventArgumentCaptor;
-
- @InjectMocks
- private PermissionsManagerImpl permissionsManager;
-
-
- @BeforeMethod
- public void setUp() throws Exception {
- SessionContextProviderFactory.getInstance().createInterface().create(USER,
- tenant);
- MockitoAnnotations.initMocks(this);
- }
-
- @Test(expectedExceptions = CoreException.class, expectedExceptionsMessageRegExp = "Permissions " +
- "Error. The user does not have permission to perform this action.")
- public void testUpdateItemPermissionsWhenNotAllowed() {
- doReturn(false).when(permissionsServicesMock).isAllowed(ITEM1_ID, USER, ACTION);
-
- permissionsManager
- .updateItemPermissions(ITEM1_ID, PERMISSION, Collections.singleton(AFFECTED_USER1),
- new HashSet<>());
- }
-
- @Test
- public void testUpdateItemPermissions() {
- doReturn(true).when(permissionsServicesMock).isAllowed(ITEM1_ID, USER, ACTION);
- Item item = new Item();
- item.setName("Item 1 Name");
- doReturn(item).when(asdcItemManagerMock).get(ITEM1_ID);
-
- Set<String> addedUsersIds =
+ @Test
+ void testUpdateItemPermissions() {
+ doReturn(true).when(permissionsServicesMock).isAllowed(ITEM1_ID, USER, ACTION);
+ Item item = new Item();
+ item.setName("Item 1 Name");
+ doReturn(item).when(asdcItemManagerMock).get(ITEM1_ID);
+
+ Set<String> addedUsersIds =
Stream.of(AFFECTED_USER1, AFFECTED_USER2).collect(Collectors.toSet());
- Set<String> removedUsersIds = Collections.singleton(AFFECTED_USER3);
- permissionsManager
+ Set<String> removedUsersIds = Collections.singleton(AFFECTED_USER3);
+ permissionsManager
.updateItemPermissions(ITEM1_ID, PERMISSION, addedUsersIds, removedUsersIds);
- verify(permissionsServicesMock)
+ verify(permissionsServicesMock)
.updateItemPermissions(ITEM1_ID, PERMISSION, addedUsersIds, removedUsersIds);
- for (String addedUsersId : addedUsersIds) {
- verifyCallsToNotificationsFramework(addedUsersId, true);
- }
- for (String removedUsersId : removedUsersIds) {
- verifyCallsToNotificationsFramework(removedUsersId, false);
+ for (String addedUsersId : addedUsersIds) {
+ verifyCallsToNotificationsFramework(addedUsersId, true);
+ }
+ for (String removedUsersId : removedUsersIds) {
+ verifyCallsToNotificationsFramework(removedUsersId, false);
+ }
}
- }
- @Test
- public void testListUserPermittedItems(){
- permissionsManager.listUserPermittedItems(AFFECTED_USER1,PERMISSION);
+ @Test
+ void testListUserPermittedItems() {
+ permissionsManager.listUserPermittedItems(AFFECTED_USER1, PERMISSION);
- verify(permissionsServicesMock)
+ verify(permissionsServicesMock)
.listUserPermittedItems(AFFECTED_USER1, PERMISSION);
- }
-
- private void verifyCallsToNotificationsFramework(String affectedUser, boolean permissionGranted) {
- verifyCallToSubscriptionService(affectedUser, permissionGranted);
- verifyDirectNotificationCallParameters(affectedUser, permissionGranted);
- }
-
- private void verifyDirectNotificationCallParameters(String affectedUser, boolean permissionGranted) {
- verify(notifierMock).directNotification(eventArgumentCaptor.capture(), Matchers.eq(affectedUser));
- Event event = eventArgumentCaptor.getValue();
- assertTrue(event.getEventType().equals(PERMISSION_CHANGED));
- Map<String, Object> attributes = event.getAttributes();
- assertEquals(attributes.get(PERMISSION_GRANTED), permissionGranted);
- assertEquals(attributes.get(ITEM_ID_PROP), ITEM1_ID);
- assertEquals(attributes.get(PERMISSION_ITEM), PERMISSION);
- }
-
- private void verifyCallToSubscriptionService(String affectedUser, boolean permissionGranted) {
- if (permissionGranted) {
- verify(subscriptionServiceMock).subscribe(affectedUser, ITEM1_ID);
- } else {
- verify(subscriptionServiceMock).unsubscribe(affectedUser, ITEM1_ID);
}
- }
+ private void verifyCallsToNotificationsFramework(String affectedUser, boolean permissionGranted) {
+ verifyCallToSubscriptionService(affectedUser, permissionGranted);
+ verifyDirectNotificationCallParameters(affectedUser, permissionGranted);
+ }
+
+ private void verifyDirectNotificationCallParameters(String affectedUser, boolean permissionGranted) {
+ verify(notifierMock).directNotification(eventArgumentCaptor.capture(), Matchers.eq(affectedUser));
+ Event event = eventArgumentCaptor.getValue();
+ assertTrue(event.getEventType().equals(PERMISSION_CHANGED));
+ Map<String, Object> attributes = event.getAttributes();
+ assertEquals(attributes.get(PERMISSION_GRANTED), permissionGranted);
+ assertEquals(attributes.get(ITEM_ID_PROP), ITEM1_ID);
+ assertEquals(attributes.get(PERMISSION_ITEM), PERMISSION);
+ }
+
+ private void verifyCallToSubscriptionService(String affectedUser, boolean permissionGranted) {
+ if (permissionGranted) {
+ verify(subscriptionServiceMock).subscribe(affectedUser, ITEM1_ID);
+ } else {
+ verify(subscriptionServiceMock).unsubscribe(affectedUser, ITEM1_ID);
+ }
+ }
}