diff options
| author |   sheetalm <sheetal.mudholkar@amdocs.com> | 2018-04-02 18:12:54 +0530 |
|---|---|---|
| committer |   Vitaly Emporopulo <Vitaliy.Emporopulo@amdocs.com> | 2018-04-10 14:37:17 +0000 |
| commit | 40bd5b855df62e257e4cc2810a95248bc3426302 (patch) | |
| tree | 518cff1b6aaf972a3f06066f8e47ac1a5e65bfee /openecomp-bdd/features | |
| parent | 7a9073719da3db83024e66a1da9ba14546cfd175 (diff) | |
Activity Spec - Change Error Response Structure
1 Added ActivitySpecNotFoundException to map to 404 Not Found response code
2 404 Not Found response code will only be returned in case activity spec
does not exists irrespective of GET or PUT used in REST
3 Update flow test to check error messages
4 Error Response to have only "message" now
5 Use proper response code instead of EXPECTATION_FAILED
Change-Id: I82fb3c0970f4e9416d9fe2577174dcaf0a4fef92
Issue-ID: SDC-1048
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
Diffstat (limited to 'openecomp-bdd/features')
| -rw-r--r-- | openecomp-bdd/features/ActivitySpec/TestCreate.feature | 12 | ||||
| -rw-r--r-- | openecomp-bdd/features/ActivitySpec/TestInvalidStatusTransition.feature | 10 |
2 files changed, 11 insertions, 11 deletions
diff --git a/openecomp-bdd/features/ActivitySpec/TestCreate.feature b/openecomp-bdd/features/ActivitySpec/TestCreate.feature index accae6ad11..c4e77a7c1b 100644 --- a/openecomp-bdd/features/ActivitySpec/TestCreate.feature +++ b/openecomp-bdd/features/ActivitySpec/TestCreate.feature @@ -35,9 +35,9 @@ # And I want to get the ActivitySpec for the current item # And I want to check property "status" for value "Deleted" # -# #Pass Invalid Id to Get and verify error code +# #Pass Invalid Id to Get and verify error message # Then I want to set property "item.id" to value "invalidId" -# Then I want the following to fail with error code "ACTIVITYSPEC_NOT_FOUND" +# Then I want the following to fail with error message "No Activity Spec found for the given identifiers" # And I want to get the ActivitySpec for the current item # # # SDC-6353 @@ -49,22 +49,22 @@ # Then I want to check property "id" exists # And I want to check property "versionId" exists # -# #Again Create ActivitySpec with name "test" and verify error code +# #Again Create ActivitySpec with name "test" and verify error message # When I want to set the input data to file "resources/json/createActivitySpec.json" # Then I want to update the input property "name" with value "test" -# Then I want the following to fail with error code "UNIQUE_VALUE_VIOLATION" +# Then I want the following to fail with error message "name already in use" # When I want to create an ActivitySpec # # # SDC-6354 # Scenario: Test Create Activity Spec With Invalid Name Format # When I want to set the input data to file "resources/json/createActivitySpec.json" # Then I want to update the input property "name" with value "test!@" -# Then I want the following to fail with error code "FIELD_VALIDATION_ERROR_ERR_ID" +# Then I want the following to fail with error message "name should match with \"^[a-zA-Z0-9-]*$\" pattern" # When I want to create an ActivitySpec # # # SDC-6355 # Scenario: Test Create Activity Spec With Null/Blank Name # When I want to set the input data to file "resources/json/createActivitySpec.json" # Then I want to update the input property "name" with value "" -# Then I want the following to fail with error code "FIELD_VALIDATION_ERROR_ERR_ID" +# Then I want the following to fail with error message "Mandatory name field is missing/null" # When I want to create an ActivitySpec
\ No newline at end of file diff --git a/openecomp-bdd/features/ActivitySpec/TestInvalidStatusTransition.feature b/openecomp-bdd/features/ActivitySpec/TestInvalidStatusTransition.feature index 1a94635a49..452570e421 100644 --- a/openecomp-bdd/features/ActivitySpec/TestInvalidStatusTransition.feature +++ b/openecomp-bdd/features/ActivitySpec/TestInvalidStatusTransition.feature @@ -14,16 +14,16 @@ # When I want to get the ActivitySpec for the current item # Then I want to check property "status" for value "Draft" # -# #Deprecate "Draft" activity status and verify error code -# Then I want the following to fail with error code "STATUS_NOT_CERTIFIED" +# #Deprecate "Draft" activity status and verify error message +# Then I want the following to fail with error message "Activity Spec is in an invalid state" # When I want to call action "DEPRECATE" on this ActivitySpec item # # #Delete "Draft" activity spec and verify error code -# Then I want the following to fail with error code "STATUS_NOT_DEPRECATED" +# Then I want the following to fail with error message "Activity Spec is in an invalid state" # When I want to call action "DELETE" on this ActivitySpec item # # #Certify activity spec # When I want to call action "CERTIFY" on this ActivitySpec item # #Certify "certified" activity spec and verify error code -# Then I want the following to fail with error code "STATUS_NOT_DRAFT" -# When I want to call action "CERTIFY" on this ActivitySpec item +# Then I want the following to fail with error message "Activity Spec is in an invalid state" +# When I want to call action "CERTIFY" on this ActivitySpec item
\ No newline at end of file |