Onboarding build optimization incl Qual Control

Sonar fixes, incremental build enhancements and Quality control mechanism integration.

Change-Id: I118d7fc0cc50c1eddb94137310c00afaaa3aaffb
Issue-ID: SDC-1189
Signed-off-by: GAUTAMS <gautams@amdocs.com>

1 files changed, 31 insertions, 36 deletions

diff --git a/onboarding/pom.xml b/onboarding/pom.xml
index 1987f19be3..2383b39e74 100644
--- a/onboarding/pom.xml
+++ b/onboarding/pom.xml
@@ -13,9 +13,13 @@
     </parent>
 
     <modules>
+        <module>../openecomp-be/tools/artifact-copy-plugin</module>
         <module>../openecomp-be/tools/compile-helper-plugin</module>
+        <module>../openecomp-be/tools/pmd-helper-plugin</module>
         <module>../common</module>
         <module>../openecomp-be</module>
+        <module>../openecomp-be/tools/build-data-helper</module>
+        <module>../openecomp-be/tools/build-data-installer</module>
         <module>../openecomp-ui</module>
     </modules>
 
@@ -25,14 +29,16 @@
         <mvn.assembly.version>2.1</mvn.assembly.version>
         <mvn.compiler.version>3.7.0</mvn.compiler.version>
         <mvn.clean.version>2.5</mvn.clean.version>
+        <mvn.resource.version>3.1.0</mvn.resource.version>
         <mvn.deploy.version>2.4</mvn.deploy.version>
         <mvn.hub.version>1.4.0</mvn.hub.version>
-        <mvn.install.version>2.3.1</mvn.install.version>
+        <mvn.install.version>2.4</mvn.install.version>
         <mvn.jar.version>2.4</mvn.jar.version>
         <mvn.jaxb2.version>0.13.3</mvn.jaxb2.version>
         <mvn.license.version>1.10</mvn.license.version>
         <mvn.shade.version>2.3</mvn.shade.version>
         <mvn.surefire.version>2.19.1</mvn.surefire.version>
+        <maven.dependency.version>3.1.0</maven.dependency.version>
         <mvn.swagger.version>3.1.0</mvn.swagger.version>
         <mvn.war.version>2.1.1</mvn.war.version>
         <maven-core.version>3.5.3</maven-core.version>
@@ -114,6 +120,9 @@
         <build.tools.version>${project.version}</build.tools.version>
         <togglz.version>2.4.1.Final</togglz.version>
         <jacoco.skip>true</jacoco.skip>
+        <maven.pmd.plugin.version>3.9.0</maven.pmd.plugin.version>
+        <pmd.java.version>6.3.0</pmd.java.version>
+        <pmd.core.version>6.3.0</pmd.core.version>
     </properties>
 
     <dependencyManagement>
@@ -131,46 +140,16 @@
         <plugins>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-pmd-plugin</artifactId>
-                <version>3.8</version>
-                <configuration>
-                    <analysisCache>true</analysisCache>
-                    <analysisCacheLocation>${project.build.directory}/pmd/pmd.cache</analysisCacheLocation>
-                    <aggregate>false</aggregate>
-                    <includeTests>true</includeTests>
-                    <linkXRef>false</linkXRef>
-                    <printFailingErrors>true</printFailingErrors>
-                    <rulesets>
-                        <ruleset>build-pmd-ruleset.xml</ruleset>
-                    </rulesets>
-                </configuration>
+                <artifactId>maven-jar-plugin</artifactId>
+                <version>${mvn.jar.version}</version>
                 <executions>
                     <execution>
-                        <id>pmd-check</id>
-                        <phase>verify</phase>
                         <goals>
-                            <!-- violations fail build -->
-                            <goal>check</goal>
+                            <goal>test-jar</goal>
                         </goals>
+                        <phase>none</phase>
                     </execution>
                 </executions>
-                <dependencies>
-                    <dependency>
-                        <groupId>org.openecomp.sdc</groupId>
-                        <artifactId>build-tools</artifactId>
-                        <version>${build.tools.version}</version>
-                    </dependency>
-                    <dependency>
-                        <groupId>net.sourceforge.pmd</groupId>
-                        <artifactId>pmd-core</artifactId>
-                        <version>${pmd.version}</version>
-                    </dependency>
-                    <dependency>
-                        <groupId>net.sourceforge.pmd</groupId>
-                        <artifactId>pmd-java</artifactId>
-                        <version>${pmd.version}</version>
-                    </dependency>
-                </dependencies>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
@@ -184,7 +163,6 @@
                             <excludes>
                                 <exclude>${classes}</exclude>
                                 <exclude>${testClasses}</exclude>
-                                <exclude>${pmd}</exclude>
                                 <exclude>${mavenStatus}</exclude>
                                 <exclude>${customGeneratedSources}</exclude>
                                 <exclude>build-data/**</exclude>
@@ -199,6 +177,7 @@
                 <version>${mvn.surefire.version}</version>
                 <configuration>
                     <forkCount>${fork.count}</forkCount>
+                    <forkMode>${fork.mode}</forkMode>
                     <printSummary>false</printSummary>
                     <redirectTestOutputToFile>true</redirectTestOutputToFile>
                     <additionalClasspathElements>
@@ -215,6 +194,22 @@
                     <skip>${skipTestRun}</skip>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-install-plugin</artifactId>
+                <version>${mvn.install.version}</version>
+                <configuration>
+                    <skip>${skipInstall}</skip>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-resources-plugin</artifactId>
+                <version>${mvn.resource.version}</version>
+                <configuration>
+                    <skip>${skipResourceCollection}</skip>
+                </configuration>
+            </plugin>
         </plugins>
         <testResources>
             <testResource>