diff options
| author |   Arindam Mondal <arind.mondal@samsung.com> | 2019-09-03 14:23:35 +0900 |
|---|---|---|
| committer |   Ofir Sonsino <ofir.sonsino@intl.att.com> | 2019-09-03 08:12:57 +0000 |
| commit | 6c4fe4d6157352eadc47ef72b9a76b0cbdb0f94e (patch) | |
| tree | 69742ba9be5c0c100099b87bee8737d8f38e57de /asdctool/src | |
| parent | 0bf19d95a42082ce34e977a24144811d94880d82 (diff) | |
General Sonar fixes
+)Organize imports
++) log formatter
Issue-ID: SDC-2542
Change-Id: Ibb4b568b19ee40a68f783bfa820bd7c73aae5c1f
Signed-off-by: arindamm <arind.mondal@samsung.com>
Diffstat (limited to 'asdctool/src')
3 files changed, 5 insertions, 7 deletions
diff --git a/asdctool/src/main/java/org/openecomp/sdc/asdctool/configuration/ArtifactUUIDFixConfiguration.java b/asdctool/src/main/java/org/openecomp/sdc/asdctool/configuration/ArtifactUUIDFixConfiguration.java index 608c6a6dd7..abfd10547b 100644 --- a/asdctool/src/main/java/org/openecomp/sdc/asdctool/configuration/ArtifactUUIDFixConfiguration.java +++ b/asdctool/src/main/java/org/openecomp/sdc/asdctool/configuration/ArtifactUUIDFixConfiguration.java @@ -22,7 +22,6 @@ package org.openecomp.sdc.asdctool.configuration; import org.openecomp.sdc.asdctool.impl.ArtifactUuidFix; -import org.openecomp.sdc.be.components.distribution.engine.ServiceDistributionArtifactsBuilder; import org.openecomp.sdc.be.config.CatalogModelSpringConfig; import org.openecomp.sdc.be.dao.cassandra.ArtifactCassandraDao; import org.openecomp.sdc.be.dao.config.DAOSpringConfig; diff --git a/asdctool/src/main/java/org/openecomp/sdc/asdctool/impl/GraphMLConverter.java b/asdctool/src/main/java/org/openecomp/sdc/asdctool/impl/GraphMLConverter.java index a7c6d38b09..deb766fff9 100644 --- a/asdctool/src/main/java/org/openecomp/sdc/asdctool/impl/GraphMLConverter.java +++ b/asdctool/src/main/java/org/openecomp/sdc/asdctool/impl/GraphMLConverter.java @@ -71,6 +71,7 @@ public class GraphMLConverter { private static Logger log = Logger.getLogger(GraphMLConverter.class.getName()); private Gson gson = new Gson(); + private static final String LOG_FORMATTER = "{} {}"; public boolean importGraph(String[] args) { @@ -118,7 +119,7 @@ public class GraphMLConverter { return false; } - log.info("{} {}", EXPORTED_FILE, result); + log.info(LOG_FORMATTER, EXPORTED_FILE, result); } catch (Exception e) { log.info("export graph failed ", e); return false; @@ -142,7 +143,7 @@ public class GraphMLConverter { result = exportGraphMl(graph, outputDirectory); - log.info("{} {}", EXPORTED_FILE, result); + log.info(LOG_FORMATTER, EXPORTED_FILE, result); } catch (Exception e) { log.info("export exportGraphMl failed ", e); return null; @@ -169,7 +170,7 @@ public class GraphMLConverter { return false; } - log.info("{} {}", EXPORTED_FILE, result); + log.info(LOG_FORMATTER, EXPORTED_FILE, result); } catch (Exception e) { log.info("find Error In Json Graph failed ", e); return false; diff --git a/asdctool/src/main/java/org/openecomp/sdc/asdctool/impl/validator/executers/VfValidatorExecuter.java b/asdctool/src/main/java/org/openecomp/sdc/asdctool/impl/validator/executers/VfValidatorExecuter.java index 080845a999..eefd19594a 100644 --- a/asdctool/src/main/java/org/openecomp/sdc/asdctool/impl/validator/executers/VfValidatorExecuter.java +++ b/asdctool/src/main/java/org/openecomp/sdc/asdctool/impl/validator/executers/VfValidatorExecuter.java @@ -20,15 +20,13 @@ package org.openecomp.sdc.asdctool.impl.validator.executers; +import java.util.List; import org.openecomp.sdc.asdctool.impl.validator.tasks.VfValidationTask; import org.openecomp.sdc.be.dao.jsongraph.GraphVertex; import org.openecomp.sdc.be.dao.jsongraph.JanusGraphDao; import org.openecomp.sdc.be.datatypes.enums.ComponentTypeEnum; import org.springframework.beans.factory.annotation.Autowired; -import java.util.ArrayList; -import java.util.List; - /** * Created by chaya on 7/3/2017. */ |