aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAbhai Singh <Abhai.Singh@amdocs.com>2018-01-04 11:46:40 +0530
committerVitaly Emporopulo <Vitaliy.Emporopulo@amdocs.com>2018-01-04 10:15:45 +0000
commitbd3aca53b345da9602eb7dba93eba4acfd3513c9 (patch)
treeed8d48baeca4b339209a1d4a556e91a1cb9d8df5
parent3b1cf41e7133a7edb5faf45e6bfce5cddaeed297 (diff)
Fix Sonar ImageDaoZusammenImpl
Fixed reported sonar issue Change-Id: I129fa4cbb5ba09c361663f7259807fca690eff0e Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
-rw-r--r--openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ImageDaoZusammenImpl.java10
1 files changed, 5 insertions, 5 deletions
diff --git a/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ImageDaoZusammenImpl.java b/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ImageDaoZusammenImpl.java
index 24ca072b23..d6a56bb612 100644
--- a/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ImageDaoZusammenImpl.java
+++ b/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ImageDaoZusammenImpl.java
@@ -38,6 +38,7 @@ public class ImageDaoZusammenImpl implements ImageDao {
@Override
public void registerVersioning(String versionableEntityType) {
+ // registerVersioning not implemented for ImageDaoZusammenImpl
}
@Override
@@ -51,11 +52,10 @@ public class ImageDaoZusammenImpl implements ImageDao {
private Collection<ImageEntity> listImages(SessionContext context,
ElementContext elementContext, ImageEntity image) {
- ElementToImageConvertor convertor = new ElementToImageConvertor();
return zusammenAdaptor
.listElementsByName(context, elementContext, new Id(image.getComponentId()),
ElementType.Images.name())
- .stream().map(convertor::convert)
+ .stream().map(new ElementToImageConvertor()::convert)
.map(imageEntity -> {
imageEntity.setComponentId(image.getComponentId());
imageEntity.setVspId(image.getVspId());
@@ -137,9 +137,9 @@ public class ImageDaoZusammenImpl implements ImageDao {
null, ElementType.Images.name());
if (elementOptional.isPresent()) {
- Element ImagesElement = elementOptional.get();
- Collection<Element> Images = ImagesElement.getSubElements();
- Images.forEach(image -> {
+ Element imagesElement = elementOptional.get();
+ Collection<Element> images = imagesElement.getSubElements();
+ images.forEach(image -> {
ZusammenElement imageZusammenElement = buildElement(image.getElementId(), Action.DELETE);
zusammenAdaptor.saveElement(context, elementContext, imageZusammenElement, "Delete image " +
"with id " + image.getElementId());