1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
|
package org.onap.vid.controllers;
/*-
* ============LICENSE_START=======================================================
* VID
* ================================================================================
* Copyright © 2018 AT&T Intellectual Property. All rights reserved.
* ================================================================================
* Modifications Copyright 2018 Nokia
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
* ============LICENSE_END=========================================================
*/
import static org.mockito.BDDMockito.given;
import static org.mockito.BDDMockito.then;
import static org.mockito.BDDMockito.willThrow;
import static org.mockito.Matchers.argThat;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.times;
import static org.onap.vid.model.CategoryParameter.Family.PARAMETER_STANDARDIZATION;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import java.util.Collections;
import java.util.function.BiFunction;
import javax.ws.rs.ForbiddenException;
import org.apache.log4j.BasicConfigurator;
import org.codehaus.jackson.map.ObjectMapper;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.ArgumentMatcher;
import org.mockito.Mock;
import org.mockito.runners.MockitoJUnitRunner;
import org.onap.vid.category.AddCategoryOptionResponse;
import org.onap.vid.category.AddCategoryOptionsRequest;
import org.onap.vid.category.CategoryParameterOptionRep;
import org.onap.vid.category.CategoryParametersResponse;
import org.onap.vid.model.CategoryParameter;
import org.onap.vid.model.CategoryParameterOption;
import org.onap.vid.services.CategoryParameterService;
import org.onap.vid.services.CategoryParameterServiceImpl;
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;
import org.springframework.test.web.servlet.ResultActions;
import org.springframework.test.web.servlet.request.MockHttpServletRequestBuilder;
import org.springframework.test.web.servlet.request.MockMvcRequestBuilders;
import org.springframework.test.web.servlet.setup.MockMvcBuilders;
@RunWith(MockitoJUnitRunner.class)
public class MaintenanceControllerTest {
final private String MAINTENANCE_CATEGORY_PATH = "/maintenance/category_parameter";
final private String CATEGORY_PARAMETER_PATH = MAINTENANCE_CATEGORY_PATH + "/{name}";
final private String DELETE_CATEGORY_PATH = "/maintenance/delete_category_parameter/{name}";
@Mock
private CategoryParameterService service;
private MaintenanceController maintenanceController;
private MockMvc mockMvc;
private ObjectMapper objectMapper;
@Before
public void setUp() {
maintenanceController = new MaintenanceController(service);
BasicConfigurator.configure();
mockMvc = MockMvcBuilders.standaloneSetup(maintenanceController).build();
objectMapper = new ObjectMapper();
}
@Test
public void addCategoryOptions_shouldReturnMultiStatus_whenErrorsExist() throws Exception {
String categoryName = "catName1";
AddCategoryOptionsRequest req = new AddCategoryOptionsRequest();
req.options = ImmutableList.of("first option", "second option");
AddCategoryOptionResponse addCategoryOptionResponse = new AddCategoryOptionResponse(
ImmutableList.of("error one", "error two"));
given(service.createCategoryParameterOptions(eq(categoryName), argThat(requestMatcher(req))))
.willReturn(addCategoryOptionResponse);
prepareRequestExpectations(MockMvcRequestBuilders::post, CATEGORY_PARAMETER_PATH, categoryName,
objectMapper.writeValueAsString(req))
.andExpect(status().isMultiStatus())
.andExpect(
content().json(objectMapper
.writeValueAsString(addCategoryOptionResponse)));
}
@Test
public void addCategoryOptions_shouldReturnOk_whenNoErrorsExist() throws Exception {
String categoryName = "catName2";
AddCategoryOptionsRequest req = new AddCategoryOptionsRequest();
req.options = ImmutableList.of("first option", "second option", "third option");
AddCategoryOptionResponse addCategoryOptionResponse = new AddCategoryOptionResponse(Collections.emptyList());
given(service.createCategoryParameterOptions(eq(categoryName), argThat(requestMatcher(req))))
.willReturn(addCategoryOptionResponse);
prepareRequestExpectations(MockMvcRequestBuilders::post, CATEGORY_PARAMETER_PATH, categoryName,
objectMapper.writeValueAsString(req))
.andExpect(status().isOk())
.andExpect(content().json(
objectMapper.writeValueAsString(addCategoryOptionResponse)));
}
@Test
public void addCategoryOptions_shouldReturnNotFound_whenUnfoundedCategoryExceptionIsThrown() throws Exception {
String unfoundedMsg = "unfounded category exception message";
String categoryName = "catName3";
AddCategoryOptionsRequest req = new AddCategoryOptionsRequest();
req.options = ImmutableList.of("first option");
given(service.createCategoryParameterOptions(eq(categoryName), argThat(requestMatcher(req))))
.willThrow(new CategoryParameterServiceImpl.UnfoundedCategoryException(unfoundedMsg));
prepareRequestExpectations(MockMvcRequestBuilders::post, CATEGORY_PARAMETER_PATH, categoryName,
objectMapper.writeValueAsString(req))
.andExpect(status().isNotFound())
.andExpect(content().json(
objectMapper.writeValueAsString(new AddCategoryOptionResponse(ImmutableList.of(unfoundedMsg)))));
}
@Test
public void addCategoryOptions_shouldReturnInternalServerError_whenExceptionIsThrown() throws Exception {
String categoryName = "catName13";
AddCategoryOptionsRequest req = new AddCategoryOptionsRequest();
req.options = ImmutableList.of("option second", "first option");
given(service.createCategoryParameterOptions(eq(categoryName), argThat(requestMatcher(req))))
.willThrow(new RuntimeException());
prepareRequestExpectations(MockMvcRequestBuilders::post, CATEGORY_PARAMETER_PATH, categoryName,
objectMapper.writeValueAsString(req))
.andExpect(status().isInternalServerError());
}
@Test
public void updateNameForOption_shouldReturnMultiStatus_whenErrorsExist() throws Exception {
String categoryName = "catName4";
CategoryParameterOptionRep categoryParameterOptionRep = new CategoryParameterOptionRep("id1", "name1");
AddCategoryOptionResponse addCategoryOptionResponse = new AddCategoryOptionResponse(
ImmutableList.of("error one", "error two"));
given(service
.updateCategoryParameterOption(eq(categoryName), argThat(requestMatcher(categoryParameterOptionRep))))
.willReturn(addCategoryOptionResponse);
prepareRequestExpectations(MockMvcRequestBuilders::put, CATEGORY_PARAMETER_PATH, categoryName,
objectMapper.writeValueAsString(categoryParameterOptionRep))
.andExpect(status().isMultiStatus())
.andExpect(
content().json(objectMapper
.writeValueAsString(addCategoryOptionResponse)));
}
@Test
public void updateNameForOption_shouldReturnOk_whenNoErrorsExist() throws Exception {
String categoryName = "catName5";
CategoryParameterOptionRep categoryParameterOptionRep = new CategoryParameterOptionRep("id2", "name2");
AddCategoryOptionResponse addCategoryOptionResponse = new AddCategoryOptionResponse(Collections.emptyList());
given(service
.updateCategoryParameterOption(eq(categoryName), argThat(requestMatcher(categoryParameterOptionRep))))
.willReturn(addCategoryOptionResponse);
prepareRequestExpectations(MockMvcRequestBuilders::put, CATEGORY_PARAMETER_PATH, categoryName,
objectMapper.writeValueAsString(categoryParameterOptionRep))
.andExpect(status().isOk())
.andExpect(content().json(
objectMapper.writeValueAsString(addCategoryOptionResponse)));
}
@Test
public void updateNameForOption_shouldReturnForbidden_whenForbiddenExceptionIsThrown() throws Exception {
String categoryName = "catName6";
CategoryParameterOptionRep categoryParameterOptionRep = new CategoryParameterOptionRep("id3", "name3");
given(service
.updateCategoryParameterOption(eq(categoryName), argThat(requestMatcher(categoryParameterOptionRep))))
.willThrow(new ForbiddenException());
prepareRequestExpectations(MockMvcRequestBuilders::put, CATEGORY_PARAMETER_PATH, categoryName,
objectMapper.writeValueAsString(categoryParameterOptionRep))
.andExpect(status().isForbidden())
.andExpect(content().json(
objectMapper
.writeValueAsString(new AddCategoryOptionResponse(ImmutableList.of("HTTP 403 Forbidden")))));
}
@Test
public void updateNameForOption_shouldReturnNotFound_whenUnfoundedIsThrown() throws Exception {
String unfoundedOptionMsg = "unfounded category option exception message";
String categoryName = "catName7";
CategoryParameterOptionRep categoryParameterOptionRep = new CategoryParameterOptionRep("id4", "name4");
given(service
.updateCategoryParameterOption(eq(categoryName), argThat(requestMatcher(categoryParameterOptionRep))))
.willThrow(new CategoryParameterServiceImpl.UnfoundedCategoryOptionException(unfoundedOptionMsg));
prepareRequestExpectations(MockMvcRequestBuilders::put, CATEGORY_PARAMETER_PATH, categoryName,
objectMapper.writeValueAsString(categoryParameterOptionRep))
.andExpect(status().isNotFound())
.andExpect(content().json(
objectMapper.writeValueAsString(new AddCategoryOptionResponse(ImmutableList.of(unfoundedOptionMsg)))));
}
@Test
public void updateNameForOption_shouldReturnConflict_whenAlreadyExistOptionNameIsThrown() throws Exception {
String conflictMsg = "already exists option name exception message";
String categoryName = "catName8";
CategoryParameterOptionRep categoryParameterOptionRep = new CategoryParameterOptionRep("id5", "name5");
given(service
.updateCategoryParameterOption(eq(categoryName), argThat(requestMatcher(categoryParameterOptionRep))))
.willThrow(new CategoryParameterServiceImpl.AlreadyExistOptionNameException(conflictMsg));
prepareRequestExpectations(MockMvcRequestBuilders::put, CATEGORY_PARAMETER_PATH, categoryName,
objectMapper.writeValueAsString(categoryParameterOptionRep))
.andExpect(status().isConflict())
.andExpect(content().json(
objectMapper.writeValueAsString(new AddCategoryOptionResponse(ImmutableList.of(conflictMsg)))));
}
@Test
public void updateNameForOption_shouldReturnInternalServerError_whenExceptionIsThrown() throws Exception {
String categoryName = "catName18";
CategoryParameterOptionRep categoryParameterOptionRep = new CategoryParameterOptionRep("id6", "name6");
given(service
.updateCategoryParameterOption(eq(categoryName), argThat(requestMatcher(categoryParameterOptionRep))))
.willThrow(new RuntimeException());
prepareRequestExpectations(MockMvcRequestBuilders::put, CATEGORY_PARAMETER_PATH, categoryName,
objectMapper.writeValueAsString(categoryParameterOptionRep))
.andExpect(status().isInternalServerError());
}
@Test
public void getCategoryParameter_shouldReturnExistingMap() throws Exception {
CategoryParametersResponse categoryParametersResponse =
new CategoryParametersResponse(
ImmutableMap.of(
"key1", ImmutableList.of(
new CategoryParameterOptionRep("testId", "testName"))));
given(service.getCategoryParameters(PARAMETER_STANDARDIZATION))
.willReturn(categoryParametersResponse);
mockMvc.perform(get(MAINTENANCE_CATEGORY_PATH)
.param("familyName", "PARAMETER_STANDARDIZATION")
.accept(MediaType.APPLICATION_JSON))
.andExpect(status().isOk())
.andExpect(content().json(objectMapper.writeValueAsString(categoryParametersResponse)));
}
@Test
public void getCategoryParameter_shouldReturnInternalServerError_whenExceptionIsThrown() throws Exception {
given(service.getCategoryParameters(PARAMETER_STANDARDIZATION))
.willThrow(new RuntimeException());
mockMvc.perform(get(MAINTENANCE_CATEGORY_PATH)
.param("familyName", "PARAMETER_STANDARDIZATION")
.accept(MediaType.APPLICATION_JSON))
.andExpect(status().isInternalServerError());
}
@Test
public void deleteCategoryOption_shouldReturnOk_whenNoExceptionIsThrown() throws Exception {
String categoryName = "catName9";
CategoryParameterOption categoryParameterOption = new CategoryParameterOption("id1", "name1",
new CategoryParameter());
prepareRequestExpectations(MockMvcRequestBuilders::delete, DELETE_CATEGORY_PATH, categoryName,
objectMapper.writeValueAsString(categoryParameterOption))
.andExpect(status().isOk());
then(service).should(times(1))
.deleteCategoryOption(eq(categoryName), argThat(requestMatcher(categoryParameterOption)));
}
@Test
public void deleteCategoryOption_shouldReturnNotFound_whenUnfoundedExceptionIsThrown() throws Exception {
String unfoundedMsg = "unfounded category exception message";
String categoryName = "catName10";
CategoryParameterOption categoryParameterOption = new CategoryParameterOption("id2", "name2",
new CategoryParameter());
willThrow(new CategoryParameterServiceImpl.UnfoundedCategoryException(unfoundedMsg))
.given(service).deleteCategoryOption(eq(categoryName), argThat(requestMatcher(categoryParameterOption)));
prepareRequestExpectations(MockMvcRequestBuilders::delete, DELETE_CATEGORY_PATH, categoryName,
objectMapper.writeValueAsString(categoryParameterOption))
.andExpect(status().isNotFound())
.andExpect(content().json(
objectMapper.writeValueAsString(new AddCategoryOptionResponse(ImmutableList.of(unfoundedMsg)))));
}
@Test
public void deleteCategoryOption_shouldReturnInternalServerError_whenExceptionIsThrown() throws Exception {
String categoryName = "catName19";
CategoryParameterOption categoryParameterOption = new CategoryParameterOption("id3", "name3",
new CategoryParameter());
willThrow(new RuntimeException()).given(service)
.deleteCategoryOption(eq(categoryName), argThat(requestMatcher(categoryParameterOption)));
prepareRequestExpectations(MockMvcRequestBuilders::delete, DELETE_CATEGORY_PATH, categoryName,
objectMapper.writeValueAsString(categoryParameterOption))
.andExpect(status().isInternalServerError());
}
private <T> ArgumentMatcher<T> requestMatcher(T t) {
return new ArgumentMatcher<T>() {
@Override
public boolean matches(Object o) {
return t.equals(o);
}
};
}
private ResultActions prepareRequestExpectations(
BiFunction<String, String, MockHttpServletRequestBuilder> httpMethod,
String path, String name, String jsonContent) throws Exception {
return mockMvc.perform(httpMethod.apply(path, name)
.contentType(MediaType.APPLICATION_JSON)
.content(jsonContent));
}
}
|