diff options
author | Krishnakumar Jinka <kris.jinka@samsung.com> | 2018-12-02 22:22:25 +0900 |
---|---|---|
committer | krisjinka <kris.jinka@samsung.com> | 2018-12-02 22:24:20 +0900 |
commit | 37ed86ed44e466409ac6d0ab425589377ab33c81 (patch) | |
tree | f4ee9cbff5df84f8d9156692d78d4957a541d7d8 /ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/Node.java | |
parent | 677b05aeacfd280209a07debba202eaa01ac0968 (diff) |
Fix sonar issue in node
Fix issue reported by sonar on more than allowed params in
method using a builder object.
Issue-ID: PORTAL-481
Change-Id: I0b88f083253570aa1a1f1be2c8af2d2bb3334e50
Signed-off-by: krisjinka <kris.jinka@samsung.com>
Diffstat (limited to 'ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/Node.java')
-rw-r--r-- | ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/Node.java | 26 |
1 files changed, 13 insertions, 13 deletions
diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/Node.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/Node.java index bb04c335..60e7a166 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/Node.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/gmap/node/Node.java @@ -3,6 +3,7 @@ * ONAP Portal SDK * =================================================================== * Copyright © 2017 AT&T Intellectual Property. All rights reserved. + * Modifications Copyright (C) 2018 Samsung Electronics Co., Ltd. * =================================================================== * * Unless otherwise specified, all software contained herein is licensed @@ -62,20 +63,19 @@ public class Node { selectionList = new ArrayList<String>(); } - public NodeInfo addNode(double longitude, double latitude, String nodeType, String nodeID, - String nodeAttributes, int state, boolean moveable, boolean deleteable) { - NodeInfo nodeInfo = new NodeInfo(nodeID); - nodeInfo.geoCoordinate.longitude = longitude; - nodeInfo.geoCoordinate.latitude = latitude; - nodeInfo.setNodeType(nodeType); - nodeInfo.setState(state); - nodeInfo.setMoveable(moveable); - nodeInfo.setDeleteable(deleteable); - nodeInfo.initializeAttributes(nodeAttributes); + public NodeInfo addNode(NodeParam nodeParam) { + NodeInfo nodeInfo = new NodeInfo(nodeParam.getNodeID()); + nodeInfo.geoCoordinate.longitude = nodeParam.getLongitude(); + nodeInfo.geoCoordinate.latitude = nodeParam.getLatitude(); + nodeInfo.setNodeType(nodeParam.getNodeType()); + nodeInfo.setState(nodeParam.getState()); + nodeInfo.setMoveable(nodeParam.isMoveable()); + nodeInfo.setDeleteable(nodeParam.isDeleteable()); + nodeInfo.initializeAttributes(nodeParam.getNodeAttributes()); - //if (nodeCollection.getNode(nodeInfo.getNodeID()+""+nodeInfo.getNodeType()) == null) { - nodeCollection.addNode(nodeInfo); - nodeIDSet.add(nodeID); + //if (nodeCollection.getNode(nodeInfo.getNodeID()+""+nodeInfo.getNodeType()) == null) { + nodeCollection.addNode(nodeInfo); + nodeIDSet.add(nodeParam.getNodeID()); /* } else { return nodeCollection.getNode(nodeType); |