summaryrefslogtreecommitdiffstats
path: root/ecomp-portal-BE-common/src
diff options
context:
space:
mode:
authorezhil <ezhrajam@in.ibm.com>2020-04-28 19:31:11 +0530
committerezhil <ezhrajam@in.ibm.com>2020-04-28 19:31:17 +0530
commit1581eace8ad6ec086c20d55034462dbf5010699e (patch)
tree2e76f84512a13b086ee8042762447553985ce49e /ecomp-portal-BE-common/src
parent328da2e4cf0c4155a4d29718cb5f57628d7a5277 (diff)
Sonar - Major blocker issue fix
Issue-ID: PORTAL-865 Change-Id: Idee6e7892db3d91b697d0d8d5ead122d16464c98 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
Diffstat (limited to 'ecomp-portal-BE-common/src')
-rw-r--r--ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/controller/RolesApprovalSystemController.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/controller/RolesApprovalSystemController.java b/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/controller/RolesApprovalSystemController.java
index 5562caac..487cc4d5 100644
--- a/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/controller/RolesApprovalSystemController.java
+++ b/ecomp-portal-BE-common/src/main/java/org/onap/portalapp/portal/controller/RolesApprovalSystemController.java
@@ -219,9 +219,9 @@ public class RolesApprovalSystemController implements BasicAuthenticationControl
* If any field is missing.
*/
private void validateExtSystemUser(ExternalSystemUser extSysUser, boolean rolesRequired) throws Exception {
- if (extSysUser.getLoginId() == null || extSysUser.getLoginId() == "")
+ if (extSysUser.getLoginId() == null || extSysUser.getLoginId().equals(""))
throw new Exception("Request has no login ID");
- if (extSysUser.getApplicationName() == null || extSysUser.getApplicationName() == "")
+ if (extSysUser.getApplicationName() == null || extSysUser.getApplicationName().equals(""))
throw new Exception("Request has no application name");
if (extSysUser.getMyloginrequestId() == null)
throw new Exception("Request has no request ID");