diff options
| author |   mkidd <michael.kidd@est.tech> | 2021-03-04 15:27:27 +0000 |
|---|---|---|
| committer | mkidd <michael.kidd@est.tech> | 2021-03-10 16:21:17 +0000 |
| commit | 7125d4c2c715d307d61e41bafe0cd11f269aa896 (patch) | |
| tree | 70ba3e2996d5660cb55d0acae3045da426279439 /gui-pdp-monitoring/src/webapp | |
| parent | e5b070acb072d62d7f86e50e51b6b1586b85e307 (diff) | |
fix code smells and vulnerabilities monitoring
removed / from start of Rest path, hard coded it - resolves code smell issue
small code smell changes regarding passing variables to functions that have access to the variable from its current scope
reintroduced data parameter being passed in MonitoringUtils.js, can look into this more later
fixed pom for parent version, commons step up
Issue-ID: POLICY-3095
Signed-off-by: mkidd <michael.kidd@est.tech>
Change-Id: Id8b6a8b41e9b3c2f362821750d3fa728b93336a0
Signed-off-by: mkidd <michael.kidd@est.tech>
Diffstat (limited to 'gui-pdp-monitoring/src/webapp')
| -rw-r--r-- | gui-pdp-monitoring/src/webapp/js/PdpInformation.js | 4 | ||||
| -rw-r--r-- | gui-pdp-monitoring/src/webapp/js/PdpListView.js | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/gui-pdp-monitoring/src/webapp/js/PdpInformation.js b/gui-pdp-monitoring/src/webapp/js/PdpInformation.js index cbb71a7..f25c245 100644 --- a/gui-pdp-monitoring/src/webapp/js/PdpInformation.js +++ b/gui-pdp-monitoring/src/webapp/js/PdpInformation.js @@ -1,6 +1,6 @@ /*- * ============LICENSE_START======================================================= - * Copyright (C) 2020 Nordix Foundation. + * Copyright (C) 2020-2021 Nordix Foundation. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -60,6 +60,6 @@ function setEngineServiceData(engineId, groupName, subGroupName, healthStatus, p engineServiceTable.find("#" + tableId + "_" + headers[h]).html(data[h]); } } -}; +} export { createEngineServiceTable, setEngineServiceData };
\ No newline at end of file diff --git a/gui-pdp-monitoring/src/webapp/js/PdpListView.js b/gui-pdp-monitoring/src/webapp/js/PdpListView.js index 1457a9e..9ae5c23 100644 --- a/gui-pdp-monitoring/src/webapp/js/PdpListView.js +++ b/gui-pdp-monitoring/src/webapp/js/PdpListView.js @@ -1,6 +1,6 @@ /*- * ============LICENSE_START======================================================= - * Copyright (C) 2020 Nordix Foundation. + * Copyright (C) 2020-2021 Nordix Foundation. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -70,6 +70,6 @@ function highlightSelected (id){ el.classList.remove('pdps__link--active'); }); document.querySelector(`.pdps__link[href*="${id}"]`).classList.add('pdps__link--active'); -}; +} export { RenderPdpList, highlightSelected, };
\ No newline at end of file |