2 files changed, 136 insertions, 14 deletions
diff --git a/POLICY-SDK-APP/src/test/java/org/onap/policy/controller/AdminTabControllerTest.java b/POLICY-SDK-APP/src/test/java/org/onap/policy/controller/AdminTabControllerTest.java
index 85337f18b..b4a4130ab 100644
--- a/POLICY-SDK-APP/src/test/java/org/onap/policy/controller/AdminTabControllerTest.java
+++ b/POLICY-SDK-APP/src/test/java/org/onap/policy/controller/AdminTabControllerTest.java
@@ -23,20 +23,22 @@
 package org.onap.policy.controller;
 
 import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
 import java.io.BufferedReader;
+import java.io.IOException;
 import java.io.StringReader;
 import java.io.UnsupportedEncodingException;
 import java.util.ArrayList;
 import java.util.List;
-
 import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
 import javax.servlet.http.HttpSession;
-
 import org.junit.Before;
 import org.junit.Test;
 import org.mockito.Mockito;
@@ -54,6 +56,7 @@ public class AdminTabControllerTest {
     private static CommonClassDao commonClassDao;
     private HttpServletRequest request;
     private MockHttpServletResponse response;
+    private AdminTabController admin;
 
     /**
      * Before.
@@ -62,21 +65,17 @@ public class AdminTabControllerTest {
      */
     @Before
     public void setUp() throws Exception {
-
+        admin = new AdminTabController();
         logger.info("setUp: Entering");
         commonClassDao = mock(CommonClassDao.class);
-
         request = mock(HttpServletRequest.class);
         response = new MockHttpServletResponse();
-
         HttpSession mockSession = mock(HttpSession.class);
         User user = new User();
         user.setOrgUserId("Test");
         Mockito.when(mockSession.getAttribute(SystemProperties.getProperty("user_attribute_name"))).thenReturn(user);
         Mockito.when(request.getSession(false)).thenReturn(mockSession);
-
         AdminTabController.setCommonClassDao(commonClassDao);
-
         GlobalRoleSettings globalRole = new GlobalRoleSettings();
         globalRole.setLockdown(true);
         globalRole.setRole("super-admin");
@@ -87,7 +86,6 @@ public class AdminTabControllerTest {
 
     @Test
     public void testGetAdminRole() {
-        AdminTabController admin = new AdminTabController();
         assertNotNull(AdminTabController.getCommonClassDao());
         try {
             admin.getAdminTabEntityData(request, response);
@@ -100,7 +98,6 @@ public class AdminTabControllerTest {
 
     @Test
     public void testSaveAdminRole() throws Exception {
-        AdminTabController admin = new AdminTabController();
         String data = "{\"lockdowndata\":{\"lockdown\":true}}";
         BufferedReader reader = new BufferedReader(new StringReader(data));
         try {
@@ -113,4 +110,18 @@ public class AdminTabControllerTest {
             fail();
         }
     }
+
+    @SuppressWarnings("unchecked")
+    @Test
+    public void testGetAdminTabEntityDataException() throws IOException {
+        HttpServletResponse mockResponse = Mockito.mock(HttpServletResponse.class);
+        when(mockResponse.getWriter()).thenThrow(Exception.class);
+        admin.getAdminTabEntityData(request, mockResponse);
+        verify(mockResponse).getWriter();
+    }
+
+    @Test
+    public void testSaveAdminTabLockdownValueException() throws IOException {
+        assertNull(admin.saveAdminTabLockdownValue(request, response));
+    }
 }
diff --git a/POLICY-SDK-APP/src/test/java/org/onap/policy/controller/AutoPushControllerTest.java b/POLICY-SDK-APP/src/test/java/org/onap/policy/controller/AutoPushControllerTest.java
index 64c3b04ff..5e390da53 100644
--- a/POLICY-SDK-APP/src/test/java/org/onap/policy/controller/AutoPushControllerTest.java
+++ b/POLICY-SDK-APP/src/test/java/org/onap/policy/controller/AutoPushControllerTest.java
@@ -24,20 +24,33 @@ package org.onap.policy.controller;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.fail;
+import static org.mockito.Matchers.any;
+import static org.mockito.Mockito.atLeast;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
 
+import com.att.research.xacml.api.pap.PAPException;
 import com.mockrunner.mock.web.MockHttpServletRequest;
 import com.mockrunner.mock.web.MockHttpServletResponse;
-
 import java.io.IOException;
-
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
-
+import javax.servlet.http.HttpSession;
+import org.junit.BeforeClass;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
 import org.junit.runner.RunWith;
 import org.mockito.Mockito;
+import org.onap.policy.model.Roles;
+import org.onap.policy.xacml.api.pap.OnapPDPGroup;
+import org.onap.policy.xacml.api.pap.PAPPolicyEngine;
 import org.onap.portalsdk.core.domain.User;
+import org.onap.portalsdk.core.web.support.AppUtils;
 import org.onap.portalsdk.core.web.support.UserUtils;
 import org.powermock.api.mockito.PowerMockito;
 import org.powermock.core.classloader.annotations.PrepareForTest;
@@ -48,12 +61,27 @@ public class AutoPushControllerTest {
     private PolicyController controller = new PolicyController();
     private AutoPushController apController = new AutoPushController();
 
+    private static HttpServletRequest mockRequest = Mockito.mock(HttpServletRequest.class);
+    private static HttpServletResponse mockResponse = Mockito.mock(HttpServletResponse.class);
+    private static PolicyController mockPolicyController = Mockito.mock(PolicyController.class);
+    private static HttpSession mockSession = Mockito.mock(HttpSession.class);
+    private static User mockUser = Mockito.mock(User.class);
+    private static List<Object> rolesList = new ArrayList<>();
+
     @Rule
     public ExpectedException thrown = ExpectedException.none();
 
+    @BeforeClass
+    public static void setupMocks() {
+        when(mockRequest.getSession(false)).thenReturn(mockSession);
+        when(AppUtils.getSession(mockRequest)).thenReturn(mockSession);
+        when(UserUtils.getUserSession(mockRequest)).thenReturn(mockUser);
+        when(mockUser.getOrgUserId()).thenReturn("");
+        when(mockPolicyController.getRoles(any(String.class))).thenReturn(rolesList);
+    }
+
     @Test
     public void testAutoPushSetGet() throws IOException {
-        // Get and set tests
         apController.setPolicyController(controller);
         assertEquals(apController.getPolicyController(), controller);
     }
@@ -80,7 +108,7 @@ public class AutoPushControllerTest {
     }
 
     @Test(expected = NullPointerException.class)
-    public void testRefresh() throws IOException {
+    public void testRefreshGroupsNull() throws IOException {
         apController.refreshGroups();
     }
 
@@ -111,4 +139,87 @@ public class AutoPushControllerTest {
         apController.removePDPGroup(request, response);
         assertEquals(HttpServletResponse.SC_OK, response.getStatusCode());
     }
+
+    @Test
+    public void testRefreshGroupsSuccess() throws PAPException {
+        PolicyController mockPolicyController = Mockito.mock(PolicyController.class);
+        PAPPolicyEngine mockPAPPolicyEngine = Mockito.mock(PAPPolicyEngine.class);
+        Set<OnapPDPGroup> onapPDPGroups = new HashSet<>();
+        when(mockPolicyController.getPapEngine()).thenReturn(mockPAPPolicyEngine);
+        when(mockPAPPolicyEngine.getOnapPDPGroups()).thenReturn(onapPDPGroups);
+        apController.setPolicyController(mockPolicyController);
+        apController.refreshGroups();
+        verify(mockPolicyController).getPapEngine();
+        verify(mockPAPPolicyEngine).getOnapPDPGroups();
+    }
+
+    @SuppressWarnings("unchecked")
+    @Test
+    public void testRefreshGroups() throws PAPException {
+        PolicyController mockPolicyController = Mockito.mock(PolicyController.class);
+        PAPPolicyEngine mockPAPPolicyEngine = Mockito.mock(PAPPolicyEngine.class);
+        when(mockPolicyController.getPapEngine()).thenReturn(mockPAPPolicyEngine);
+        when(mockPAPPolicyEngine.getOnapPDPGroups()).thenThrow(PAPException.class);
+        apController.setPolicyController(mockPolicyController);
+        apController.refreshGroups();
+        verify(mockPolicyController).getPapEngine();
+        verify(mockPAPPolicyEngine).getOnapPDPGroups();
+    }
+
+    @Test
+    public void testGetPolicyGroupContainerData() throws Exception {
+        Roles superAdmin = new Roles();
+        Roles superEditor = new Roles();
+        Roles superGuest = new Roles();
+        rolesList.add(superAdmin);
+        rolesList.add(superEditor);
+        rolesList.add(superGuest);
+
+        apController.setPolicyController(mockPolicyController);
+        apController.getPolicyGroupContainerData(mockRequest, mockResponse);
+
+        verify(mockRequest, atLeast(1)).getSession(false);
+        verify(mockUser, atLeast(1)).getOrgUserId();
+        verify(mockPolicyController, atLeast(1)).getRoles(any(String.class));
+    }
+
+    @Test
+    public void testGetPolicyGroupContainerDataWithScope() throws Exception {
+        Roles superAdmin = new Roles();
+        superAdmin.setScope("super-admin-scope");
+        Roles superEditor = new Roles();
+        superEditor.setScope("super-editor-scope");
+        Roles superGuest = new Roles();
+        superGuest.setScope("super-guest-scope");
+        rolesList.add(superAdmin);
+        rolesList.add(superEditor);
+        rolesList.add(superGuest);
+
+        apController.setPolicyController(mockPolicyController);
+        apController.getPolicyGroupContainerData(mockRequest, mockResponse);
+
+        verify(mockRequest, atLeast(1)).getSession(false);
+        verify(mockUser, atLeast(1)).getOrgUserId();
+        verify(mockPolicyController, atLeast(1)).getRoles(any(String.class));
+    }
+
+    @Test
+    public void testGetPolicyGroupContainerDataWithRole() throws Exception {
+        Roles superAdmin = new Roles();
+        superAdmin.setRole("super-admin");
+        Roles superEditor = new Roles();
+        superEditor.setRole("super-editor");
+        Roles superGuest = new Roles();
+        superGuest.setRole("super-guest");
+        rolesList.add(superAdmin);
+        rolesList.add(superEditor);
+        rolesList.add(superGuest);
+
+        apController.setPolicyController(mockPolicyController);
+        apController.getPolicyGroupContainerData(mockRequest, mockResponse);
+
+        verify(mockRequest, atLeast(1)).getSession(false);
+        verify(mockUser, atLeast(1)).getOrgUserId();
+        verify(mockPolicyController, atLeast(1)).getRoles(any(String.class));
+    }
 }