Consolidate PolicyRestAdapter setup

Put common code into PolicyEngineUtils that the controllers use to
populate the PolicyRestController.

Also some more sonar cleanup and formatting of XML files.

Shortened 120 line characters. Removed some trailing spaces
from comments.

Fixed up one JUnit.

Licenses.

Issue-ID: POLICY-2133
Change-Id: Id7d8ac3ab60331535f048ec0f26aeb17a099414e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

1 files changed, 48 insertions, 31 deletions

diff --git a/PolicyEngineUtils/src/test/resources/META-INF/persistencePUtest.xml b/PolicyEngineUtils/src/test/resources/META-INF/persistencePUtest.xml
index a73e6b3c5..17cdce68d 100644
--- a/PolicyEngineUtils/src/test/resources/META-INF/persistencePUtest.xml
+++ b/PolicyEngineUtils/src/test/resources/META-INF/persistencePUtest.xml
@@ -1,35 +1,52 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!-- ============LICENSE_START======================================================= 
-	PolicyEngineUtils ================================================================================ 
-	Copyright (C) 2017 AT&T Intellectual Property. All rights reserved. ================================================================================ 
-	Licensed under the Apache License, Version 2.0 (the "License"); you may not 
-	use this file except in compliance with the License. You may obtain a copy 
-	of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required 
-	by applicable law or agreed to in writing, software distributed under the 
-	License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS 
-	OF ANY KIND, either express or implied. See the License for the specific 
-	language governing permissions and limitations under the License. ============LICENSE_END========================================================= -->
+<!--
+  ============LICENSE_START=======================================================
+  PolicyEngineUtils
+  ================================================================================
+  Copyright (C) 2017, 2019 AT&T Intellectual Property. All rights reserved.
+  ================================================================================
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+  
+       http://www.apache.org/licenses/LICENSE-2.0
+  
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+  ============LICENSE_END=========================================================
+  -->
 
 <persistence version="2.1"
-	xmlns="http://xmlns.jcp.org/xml/ns/persistence" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-	xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/persistence http://xmlns.jcp.org/xml/ns/persistence/persistence_2_1.xsd">
-	<persistence-unit name="PolicyEngineUtils"
-		transaction-type="RESOURCE_LOCAL">
-		<provider>org.eclipse.persistence.jpa.PersistenceProvider</provider>
-		<class>org.onap.policy.jpa.BackUpMonitorEntity</class>
-		<property name="javax.persistence.schema-generation.scripts.action"
-			value="drop-and-create" />
-		<property name="javax.persistence.schema-generation.scripts.create-target"
-			value="./src/test/resources/META-INF/generatedCreate.ddl" />
-		<property name="javax.persistence.schema-generation.scripts.drop-target"
-			value="./src/test/resources/META-INF/generatedDrop.ddl" />
-		<property name="javax.persistence.schema-generation.database.action"
-			value="drop-and-create" />
-		<property name="javax.persistence.schema-generation.create-source"
-			value="metadata-then-script" />
-		<property name="javax.persistence.schema-generation.drop-source"
-			value="script" />
-		<property name="javax.persistence.schema-generation.drop-script-source"
-			value="META-INF/drop.ddl" />
-	</persistence-unit>
+    xmlns="http://xmlns.jcp.org/xml/ns/persistence"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/persistence http://xmlns.jcp.org/xml/ns/persistence/persistence_2_1.xsd">
+    <persistence-unit name="PolicyEngineUtils"
+        transaction-type="RESOURCE_LOCAL">
+        <provider>org.eclipse.persistence.jpa.PersistenceProvider</provider>
+        <class>org.onap.policy.jpa.BackUpMonitorEntity</class>
+        <property
+            name="javax.persistence.schema-generation.scripts.action"
+            value="drop-and-create" />
+        <property
+            name="javax.persistence.schema-generation.scripts.create-target"
+            value="./src/test/resources/META-INF/generatedCreate.ddl" />
+        <property
+            name="javax.persistence.schema-generation.scripts.drop-target"
+            value="./src/test/resources/META-INF/generatedDrop.ddl" />
+        <property
+            name="javax.persistence.schema-generation.database.action"
+            value="drop-and-create" />
+        <property
+            name="javax.persistence.schema-generation.create-source"
+            value="metadata-then-script" />
+        <property
+            name="javax.persistence.schema-generation.drop-source"
+            value="script" />
+        <property
+            name="javax.persistence.schema-generation.drop-script-source"
+            value="META-INF/drop.ddl" />
+    </persistence-unit>
 </persistence>