Included Policy GUI Enhancements and validations

Added hover messages for all policy templates.
Resolved few sonar issues.
Added fixes for Policy GUI Validations.

Issue-ID: POLICY-597
Change-Id: I74abb92dd6ac8722d7869b6a316fad1d8db11d9c
Signed-off-by: rb7147 <rb7147@att.com>

12 files changed, 20 insertions, 49 deletions

diff --git a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/CLSiteDictionary.html b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/CLSiteDictionary.html
index 569f7bf5d..02175f92e 100644
--- a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/CLSiteDictionary.html
+++ b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/CLSiteDictionary.html
@@ -23,10 +23,6 @@
 			<div class="modal-content">
         <div class="modal-header">
             <h2 class="font-showcase-font-name" style="color : #157bb2">{{label}}</h2>
-			<div class="corner-button in">
-				<button type="button" class="close" aria-label="Close"
-				ng-click="$dismiss('cancel')"></button>
-			</div>
         </div>
 		<form name="formdata" ng-submit="saveCLSite(editCLSite);" novalidate>
         <div class="modal-body">
diff --git a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/CLVarbindDictionary.html b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/CLVarbindDictionary.html
index 2271992b0..2858d9782 100644
--- a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/CLVarbindDictionary.html
+++ b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/CLVarbindDictionary.html
@@ -23,10 +23,6 @@
 			<div class="modal-content">
         <div class="modal-header">
             <h2 class="font-showcase-font-name" style="color : #157bb2">{{label}}</h2>
-			<div class="corner-button in">
-				<button type="button" class="close" aria-label="Close"
-				ng-click="$dismiss('cancel')"></button>
-			</div>
         </div>
 		<form name="formdata" ng-submit="saveCLVarbind(editCLVarbind);" novalidate>
         <div class="modal-body">
diff --git a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/FWZoneDictionary.html b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/FWZoneDictionary.html
index 194f4481f..380f22bb3 100644
--- a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/FWZoneDictionary.html
+++ b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/FWZoneDictionary.html
@@ -23,10 +23,6 @@
 			<div class="modal-content">
         <div class="modal-header">
             <h2 class="font-showcase-font-name" style="color : #157bb2">{{label}}</h2>
-			<div class="corner-button in">
-				<button type="button" class="close" aria-label="Close"
-				ng-click="$dismiss('cancel')"></button>
-			</div>
         </div>
 		<form name="formdata" ng-submit="saveZoneName(editZoneName);" novalidate>
         <div class="modal-body">
diff --git a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSConfigNameDictionary.html b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSConfigNameDictionary.html
index 0b89a3150..cfde1c2dd 100644
--- a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSConfigNameDictionary.html
+++ b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSConfigNameDictionary.html
@@ -23,10 +23,6 @@
 			<div class="modal-content">
         <div class="modal-header">
             <h2 class="font-showcase-font-name" style="color : #157bb2">{{label}}</h2>
-			<div class="corner-button in">
-				<button type="button" class="close" aria-label="Close"
-				ng-click="$dismiss('cancel')"></button>
-			</div>
         </div>
 		<form name="formdata" ng-submit="saveMSConfig(editMSConfig);" novalidate>
         <div class="modal-body">
diff --git a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSDCAEUUIDDictionary.html b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSDCAEUUIDDictionary.html
index 89e3aff1e..4fded51ec 100644
--- a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSDCAEUUIDDictionary.html
+++ b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSDCAEUUIDDictionary.html
@@ -23,10 +23,6 @@
 			<div class="modal-content">
         <div class="modal-header">
             <h2 class="font-showcase-font-name" style="color : #157bb2">{{label}}</h2>
-			<div class="corner-button in">
-				<button type="button" class="close" aria-label="Close"
-				ng-click="$dismiss('cancel')"></button>
-			</div>
         </div>
 		<form name="formdata" ng-submit="saveDCAEUUID(editDCAEuuid);" novalidate>
         <div class="modal-body">
diff --git a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSLocationDictionary.html b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSLocationDictionary.html
index a6919870f..609c9f326 100644
--- a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSLocationDictionary.html
+++ b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSLocationDictionary.html
@@ -23,10 +23,6 @@
 			<div class="modal-content">
         <div class="modal-header">
             <h2 class="font-showcase-font-name" style="color : #157bb2">{{label}}</h2>
-			<div class="corner-button in">
-				<button type="button" class="close" aria-label="Close"
-				ng-click="$dismiss('cancel')"></button>
-			</div>
         </div>
 		<form name="formdata" ng-submit="saveMSLocation(editMSLocation);" novalidate>
         <div class="modal-body">
diff --git a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSModelsDictionary.html b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSModelsDictionary.html
index 15a476040..fbdd8cd6c 100644
--- a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSModelsDictionary.html
+++ b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/MSModelsDictionary.html
@@ -23,10 +23,6 @@
 			<div class="modal-content">
         <div class="modal-header">
             <h2 class="font-showcase-font-name" style="color : #157bb2">{{label}}</h2>
-			<div class="corner-button in">
-				<button type="button" class="close" aria-label="Close"
-				ng-click="$dismiss('cancel')"></button>
-			</div>
         </div>
 		<form name="formdata" ng-submit="saveMSModel(editMSmodelName);" novalidate>
         <div class="modal-body">
diff --git a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/ModelAttributeDictionary.html b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/ModelAttributeDictionary.html
index 201e1ba52..0531a00ae 100644
--- a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/ModelAttributeDictionary.html
+++ b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Dictionary/ModelAttributeDictionary.html
@@ -24,7 +24,6 @@
         <div class="modal-header">
             <h2 class="font-showcase-font-name" style="color : #157bb2">{{label}}</h2>
         </div>
-        <div class="divider-container"><hr> </div>
 		<form name="formdata" ng-submit="saveModelAttribute(editModelAttribute);" novalidate>
         <div class="modal-body">
 			<div class="form-group row">
diff --git a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Edit_Roles_Window.html b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Edit_Roles_Window.html
index 11e960b51..7974d4e3f 100644
--- a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Edit_Roles_Window.html
+++ b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/Edit_Roles_Window.html
@@ -40,13 +40,13 @@
 			<div class="form-group row">
 			<div class="form-group col-sm-6" >
 				<label><sup><b>*</b></sup>Scope:</label><br>
-				<select class="form-control" multiple  ng-model="editRole.scope" ng-options="option for option in scopeDatas" ></select>
+				<select class="form-control" multiple  ng-model="editRole.scope" ng-options="option for option in scopeDatas" title="Select the Scopes from the dropdown."></select>
 			</div>
 			</div>
 		</div>
 		<div class="modal-footer">
-			<button class="btn btn-success" herf="javascript:void(0)" ng-click="saveRole(editRole);">Save</button>
-			<button class="btn btn-default" herf="javascript:void(0)" ng-click="close()">Close</button>
+			<button class="btn btn-success" herf="javascript:void(0)" ng-click="saveRole(editRole);" title="OnClick Policy Role is saved.">Save</button>
+			<button class="btn btn-default" herf="javascript:void(0)" ng-click="close()" title="OnClick Policy Role Window is closed.">Close</button>
 		</div>
 	</div>
 </div>
diff --git a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/PDPTabWindows/AddorEditPDPtoGroup.html b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/PDPTabWindows/AddorEditPDPtoGroup.html
index cbb617c6f..cc3d076c9 100644
--- a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/PDPTabWindows/AddorEditPDPtoGroup.html
+++ b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/PDPTabWindows/AddorEditPDPtoGroup.html
@@ -28,34 +28,34 @@
 			<div class="form-group row">
             <div class="form-group col-sm-6">
                 <label>PDP URL:<sup><b>*</b></sup> </label><br>
-                <input type="text"  class="form-control" ng-model="editPDPInGroup.id" class="form-control" />
+                <input type="text"  class="form-control" ng-model="editPDPInGroup.id" class="form-control" title="Enter the valid PDP URL value."/>
             </div>
 			</div>
 			<div class="form-group row">
             <div class="form-group col-sm-6">
                 <label>JMX Port:<sup><b>*</b></sup></label><br>
                 <input type="text"  class="form-control" ng-model="editPDPInGroup.jmxPort"
-                       class="form-control"  />
+                       class="form-control"  title="Enter the valid PDP JMX Port Number."/>
             </div>
 			</div>
 			<div class="form-group row">
             <div class="form-group col-sm-6">
                 <label>PDP Name:<sup><b>*</b></sup></label><br>
                 <input type="text"  class="form-control" ng-model="editPDPInGroup.name"
-                      class="form-control"  />
+                      class="form-control"  title="Enter the PDP Name."/>
             </div>
 			</div>
 			<div class="form-group row">
             <div class="form-group col-sm-6">
                 <label>PDP Description:</label><br>
                 <input type="text"  class="form-control" ng-model="editPDPInGroup.description"
-                      class="form-control"/>
+                      class="form-control" title="Enter the PDP Description."/>
             </div>
 			</div>
         </div>
         <div class="modal-footer">
-            <button class="btn btn-success"  herf="javascript:void(0)" ng-click="savePDPInGroup(editPDPInGroup);">Save</button>
-            <button class="btn btn-default" herf="javascript:void(0)" ng-click="close()">Close</button>
+            <button class="btn btn-success"  herf="javascript:void(0)" ng-click="savePDPInGroup(editPDPInGroup);" title="OnClick PDP Group is created.">Save</button>
+            <button class="btn btn-default" herf="javascript:void(0)" ng-click="close()" title="OnClick PDP Group Window is closed.">Close</button>
 		</div>
     </div>
 	</div>
diff --git a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/PushtabWindow/removeGroupPoliciesWindow.html b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/PushtabWindow/removeGroupPoliciesWindow.html
index d6bde6957..84c6c3f8c 100644
--- a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/PushtabWindow/removeGroupPoliciesWindow.html
+++ b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/PushtabWindow/removeGroupPoliciesWindow.html
@@ -29,8 +29,8 @@
             <div style="width: 100%; height:580px" ui-grid = "removePoliciesGrid" ui-grid-pagination ui-grid-selection ui-grid-exporter class= "grid"></div>
         </div>
         <div class="modal-footer">
-            <button class="btn btn-success" herf="javascript:void(0)" ng-click="removePolicies();">Remove</button>
-            <button class="btn btn-default" herf="javascript:void(0)" ng-click="$close()">Close</button>
+            <button class="btn btn-success" herf="javascript:void(0)" ng-click="removePolicies();" title="OnClick Policy will be removed from PDP Group.">Remove</button>
+            <button class="btn btn-default" herf="javascript:void(0)" ng-click="$close()" title="OnClick Remove Policy Window is Closed.">Close</button>
 		</div>
     </div>
 	</div>
diff --git a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/new_PDPGroup_Window.html b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/new_PDPGroup_Window.html
index e13a140d9..8eae7a144 100644
--- a/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/new_PDPGroup_Window.html
+++ b/POLICY-SDK-APP/src/main/webapp/app/policyApp/Windows/new_PDPGroup_Window.html
@@ -28,19 +28,19 @@
 			<div class="form-group row">
 			<div class="form-group col-sm-6">
 				<label>Group Name:<sup><b>*</b></sup> </label><br>
-				<input type="text"  class="form-control" ng-model="editPDPGroup.groupName"/>
+				<input type="text"  class="form-control" ng-model="editPDPGroup.groupName" title="Enter the Valid PDP Group Name."/>
 			</div>
 			</div>
 			<div class="form-group row">
 			<div class="form-group col-sm-6">
 				<label><sup><b></b></sup>Group Description:</label><br>
-				<input type="text"   class="form-control" ng-model="editPDPGroup.description"/>
+				<input type="text"   class="form-control" ng-model="editPDPGroup.description" title="Enter the Description"/>
 			</div>
 			</div>
 		</div>
 		<div class="modal-footer">
-			<button class="btn btn-success" herf="javascript:void(0)" ng-click="savePDPGroup(editPDPGroup);">Save</button>
-			<button class="btn btn-default" herf="javascript:void(0)" ng-click="close()">Close</button>
+			<button class="btn btn-success" herf="javascript:void(0)" ng-click="savePDPGroup(editPDPGroup);" title="OnClick PDP Group is saved.">Save</button>
+			<button class="btn btn-default" herf="javascript:void(0)" ng-click="close()" title="OnClick PDP Group Window is closed.">Close</button>
 		</div>
 	</div>
 			</div>
@@ -58,11 +58,11 @@
 			<div class="form-group row">
 			<div class="form-group col-sm-6">
 				<label> Group Name:<sup><b>*</b></sup></label><br>
-				<input type="text"  class="form-control"  ng-model="editPDPGroup.name"/>
+				<input type="text"  class="form-control"  ng-model="editPDPGroup.name" title="Enter the Valid PDP Group Name."/>
 			</div>
 			<div class="form-group col-sm-6">
 				<label>Group Description:</label><br>
-				<input type="text" class="form-control" ng-model="editPDPGroup.description"/>
+				<input type="text" class="form-control" ng-model="editPDPGroup.description" title="Enter the Description"/>
 			</div>
 			</div>
 			<div >
@@ -75,8 +75,8 @@
 			</div>
 		</div>
 	<div class="modal-footer">
-		<button class="btn btn-success" herf="javascript:void(0)" ng-click="savePDPGroup(editPDPGroup);">Save</button>
-		<button class="btn btn-default" herf="javascript:void(0)" ng-click="close()">Close</button>
+		<button class="btn btn-success" herf="javascript:void(0)" ng-click="savePDPGroup(editPDPGroup);" title="OnClick PDP Group is Updated.">Save</button>
+		<button class="btn btn-default" herf="javascript:void(0)" ng-click="close()" title="OnClick PDP Group Window is closed.">Close</button>
 	</div>
 	</div>
 			</div>
@@ -101,7 +101,7 @@
 			</div>
 		</div>
 	<div class="modal-footer">
-		<button class="btn btn-default" herf="javascript:void(0)" ng-click="close()">Close</button>
+		<button class="btn btn-default" herf="javascript:void(0)" ng-click="close()" title="OnClick Show Policies PDP Group Window is closed.">Close</button>
 	</div>
 	</div>
 	</div>