Addressing Technical Debt for POLICY-SDK-APP

* Using booleans true and false
* Using already predefined static strings
* Adding private constructors to hide implicit
* Adding empty constructor comment to satisfy SONAR
* Using single quotes for indexOf to use faster method
* Preferred use of .isEmpty()
* Ordering of public static synchronized syntax
* Removing commented out code
* Using an already defined constant
* Unnecessary declaration of runtime exceptions
* Unnecessary casts
* Unused variables and imports
* Unnecessary use of toString()
* Just using return vs storing into a local var and returning that
* Extra semicolons

Issue-ID: POLICY-482
Change-Id: I6b9dcc5211dd52895a8787239b9df3059928fa45
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/AutoPushController.java b/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/AutoPushController.java
index 50b9d6923..9ade81d17 100644
--- a/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/AutoPushController.java
+++ b/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/AutoPushController.java
@@ -120,7 +120,7 @@ public class AutoPushController extends RestrictedBaseController{
 		try{
 			Set<String> scopes = null;
 			List<String> roles = null;
-			data = new ArrayList<Object>();
+			data = new ArrayList<>();
 			String userId = UserUtils.getUserSession(request).getOrgUserId();
 			Map<String, Object> model = new HashMap<>();
 			ObjectMapper mapper = new ObjectMapper();
@@ -230,7 +230,7 @@ public class AutoPushController extends RestrictedBaseController{
 					String id = name;
 					if (id.endsWith(".xml")) {
 						id = id.replace(".xml", "");
-						id = id.substring(0, id.lastIndexOf("."));
+						id = id.substring(0, id.lastIndexOf('.'));
 					}
 					
 					// Default policy to be Root policy; user can change to deferred
@@ -348,7 +348,7 @@ public class AutoPushController extends RestrictedBaseController{
 			ObjectMapper mapper = new ObjectMapper();
 			mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
 			JsonNode root = mapper.readTree(request.getReader());  
-			StdPDPGroup group = (StdPDPGroup)mapper.readValue(root.get("activePdpGroup").toString(), StdPDPGroup.class);
+			StdPDPGroup group = mapper.readValue(root.get("activePdpGroup").toString(), StdPDPGroup.class);
 			JsonNode removePolicyData = root.get("data");
 			
 			String userId = UserUtils.getUserSession(request).getOrgUserId();