Add PAP Policy parameter builder xacml policy

Fix Sonar flagged major issue about 14 params instead of 9
in the constructor of std pap policy class. Commit5 for
modify constrctor.fix test

Issue-ID: POLICY-1016
Change-Id: I79c8482b7fc4e203cb18402ba2b5a68a120c57b1
Signed-off-by: krisjinka <kris.jinka@samsung.com>

1 files changed, 79 insertions, 74 deletions

diff --git a/ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/api/services/FirewallPolicyService.java b/ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/api/services/FirewallPolicyService.java
index 8f4ba9a79..45deeb49f 100644
--- a/ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/api/services/FirewallPolicyService.java
+++ b/ONAP-PDP-REST/src/main/java/org/onap/policy/pdp/rest/api/services/FirewallPolicyService.java
@@ -7,9 +7,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -31,83 +31,88 @@ import org.onap.policy.xacml.api.XACMLErrorConstants;
 import org.onap.policy.xacml.std.pap.StdPAPPolicy;
 
 /**
- * Firewall Policy Implementation. 
- * 
+ * Firewall Policy Implementation.
+ *
  * @version 0.1
  */
 public class FirewallPolicyService {
-	private static final Logger LOGGER = FlexLogger.getLogger(FirewallPolicyService.class.getName());
-	
-	private  PAPServices papServices = null;
-	private PolicyParameters policyParameters = null;
-	private String message = null;
-	private String policyName = null;
-	private String policyScope = null;
-	private String date = null;
-	private JsonObject firewallJson = null;
-	
-	public FirewallPolicyService(String policyName, String policyScope,
-			PolicyParameters policyParameters, String date) {
-		this.policyParameters = policyParameters;
-		this.policyName = policyName;
-		this.policyScope = policyScope;
-		this.date = date;
-		papServices = new PAPServices();
-	}
+    private static final Logger LOGGER = FlexLogger.getLogger(FirewallPolicyService.class.getName());
 
-	public Boolean getValidation() {
-		if(policyParameters.getConfigBody()==null){
-			message = XACMLErrorConstants.ERROR_DATA_ISSUE+ "No Config Body given.";
-			return false;
-		}
-		try{
-			firewallJson = PolicyApiUtils.stringToJsonObject(policyParameters.getConfigBody());
-		} catch(JsonException| IllegalStateException e){
-			message = XACMLErrorConstants.ERROR_DATA_ISSUE+ " improper JSON object : " + policyParameters.getConfigBody();
-			LOGGER.error("Error while parsing JSON body for creating Firewall Policy " , e);
-			return false;
-		}
-		if(firewallJson==null|| firewallJson.isEmpty()){
-			message = XACMLErrorConstants.ERROR_DATA_ISSUE + "No Config-Body given.";
-			return false;
-		}
-		boolean levelCheck = false;
-		levelCheck = PolicyApiUtils.isNumeric(policyParameters.getRiskLevel());
-		if (!levelCheck){
-			message = XACMLErrorConstants.ERROR_DATA_ISSUE + "Incorrect Risk Level given.";
-			return false;
-		}
-		return true;
-	}
+    private PAPServices papServices = null;
+    private PolicyParameters policyParameters = null;
+    private String message = null;
+    private String policyName = null;
+    private String policyScope = null;
+    private String date = null;
+    private JsonObject firewallJson = null;
 
-	public String getMessage() {
-		return message;
-	}
+    public FirewallPolicyService(String policyName, String policyScope,
+                                 PolicyParameters policyParameters, String date) {
+        this.policyParameters = policyParameters;
+        this.policyName = policyName;
+        this.policyScope = policyScope;
+        this.date = date;
+        papServices = new PAPServices();
+    }
 
-	public String getResult(boolean updateFlag) throws PolicyException {
-		String response = null;
-		String operation = null;
-		if (updateFlag){
-			operation = "update";
-		} else {
-			operation = "create";
-		}
-		//set values for basic policy information
-		if(!firewallJson.containsKey("configName")){
-			message = XACMLErrorConstants.ERROR_DATA_ISSUE + "No configName given in firwall JSON.";
-			LOGGER.error(message);
-			return message;
-		}
-		String configName = firewallJson.get("configName").toString();
-		String configDescription = "";
-		String json = firewallJson.toString();
-		// Create Policy. 
-		StdPAPPolicy newPAPPolicy = new StdPAPPolicy("Firewall Config", policyName, configDescription, configName, updateFlag, policyScope, json, 0, 
-				policyParameters.getRiskLevel(),policyParameters.getRiskType(), String.valueOf(policyParameters.getGuard()), date);
-		// Send Json to PAP. 
-		response = (String) papServices.callPAP(newPAPPolicy, new String[] {"operation="+operation, "apiflag=api", "policyType=Config"}, policyParameters.getRequestID(), "ConfigFirewall");
-		LOGGER.info(response);
-		return response;
-	}
+    public Boolean getValidation() {
+        if (policyParameters.getConfigBody() == null) {
+            message = XACMLErrorConstants.ERROR_DATA_ISSUE + "No Config Body given.";
+            return false;
+        }
+        try {
+            firewallJson = PolicyApiUtils.stringToJsonObject(policyParameters.getConfigBody());
+        } catch (JsonException | IllegalStateException e) {
+            message =
+                    XACMLErrorConstants.ERROR_DATA_ISSUE + " improper JSON object : " +
+                            policyParameters.getConfigBody();
+            LOGGER.error("Error while parsing JSON body for creating Firewall Policy ", e);
+            return false;
+        }
+        if (firewallJson == null || firewallJson.isEmpty()) {
+            message = XACMLErrorConstants.ERROR_DATA_ISSUE + "No Config-Body given.";
+            return false;
+        }
+        boolean levelCheck = false;
+        levelCheck = PolicyApiUtils.isNumeric(policyParameters.getRiskLevel());
+        if (!levelCheck) {
+            message = XACMLErrorConstants.ERROR_DATA_ISSUE + "Incorrect Risk Level given.";
+            return false;
+        }
+        return true;
+    }
+
+    public String getMessage() {
+        return message;
+    }
+
+    public String getResult(boolean updateFlag) throws PolicyException {
+        String response = null;
+        String operation = null;
+        if (updateFlag) {
+            operation = "update";
+        } else {
+            operation = "create";
+        }
+        //set values for basic policy information
+        if (!firewallJson.containsKey("configName")) {
+            message = XACMLErrorConstants.ERROR_DATA_ISSUE + "No configName given in firwall JSON.";
+            LOGGER.error(message);
+            return message;
+        }
+        String configName = firewallJson.get("configName").toString();
+        String configDescription = "";
+        String json = firewallJson.toString();
+        // Create Policy.
+        StdPAPPolicy newPAPPolicy = new StdPAPPolicy("Firewall Config", policyName, configDescription, configName,
+                updateFlag, policyScope, json, 0,
+                policyParameters.getRiskLevel(), policyParameters.getRiskType(),
+                String.valueOf(policyParameters.getGuard()), date);
+        // Send Json to PAP.
+        response = (String) papServices.callPAP(newPAPPolicy, new String[]{"operation=" + operation, "apiflag=api",
+                "policyType=Config"}, policyParameters.getRequestID(), "ConfigFirewall");
+        LOGGER.info(response);
+        return response;
+    }
 
 }