diff options
author | 2018-07-16 17:04:55 -0400 | |
---|---|---|
committer | 2018-07-16 17:08:22 -0400 | |
commit | f892e8b13ea87c1d7fb1c890f64ff00fc6e2de5f (patch) | |
tree | f8cef500ab1a90f5c893a8e8e6767887c5a120cb /controlloop/common/guard/src/main/java/org | |
parent | b266225319cf01ce0d778074fc1f792a3f7a1321 (diff) |
Use refresh() instead of lock() in guard
This is the second step of separating the lock "refresh" operation
from the original "lock" operation.
Modified PolicyGuard to use refresh() to extend a lock. Also removed
the host name from the owner String, as it will no be longer needed
(once the final step is done).
Change-Id: I3a498e6f81d9dba1bbdfd6f7388087355192bcf5
Issue-ID: POLICY-872
Signed-off-by: Jim Hahn <jrh3@att.com>
Diffstat (limited to 'controlloop/common/guard/src/main/java/org')
-rw-r--r-- | controlloop/common/guard/src/main/java/org/onap/policy/guard/PolicyGuard.java | 33 |
1 files changed, 7 insertions, 26 deletions
diff --git a/controlloop/common/guard/src/main/java/org/onap/policy/guard/PolicyGuard.java b/controlloop/common/guard/src/main/java/org/onap/policy/guard/PolicyGuard.java index 73baf205d..e9ff01072 100644 --- a/controlloop/common/guard/src/main/java/org/onap/policy/guard/PolicyGuard.java +++ b/controlloop/common/guard/src/main/java/org/onap/policy/guard/PolicyGuard.java @@ -23,7 +23,6 @@ package org.onap.policy.guard; import java.util.UUID; import org.onap.policy.controlloop.policy.TargetType; import org.onap.policy.drools.core.lock.PolicyResourceLockManager; -import org.onap.policy.drools.utils.NetworkUtil; import org.onap.policy.guard.impl.PNFTargetLock; import org.onap.policy.guard.impl.VMTargetLock; import org.onap.policy.guard.impl.VNFTargetLock; @@ -94,10 +93,10 @@ public class PolicyGuard { UUID requestID, LockCallback callback, int holdSec) { String owner = makeOwner(targetType, requestID); - - GuardResult guardResult = managerLockTarget(targetInstance, owner, holdSec); - if(guardResult != GuardResult.LOCK_ACQUIRED) { - return LockResult.createLockResult(guardResult, null); + + boolean result = factory.getManager().lock(targetInstance, owner, holdSec); + if(!result) { + return LockResult.createLockResult(GuardResult.LOCK_DENIED, null); } TargetLock lock = null; @@ -142,21 +141,10 @@ public class PolicyGuard { */ public static GuardResult lockTarget(TargetLock lock, int holdSec) { String owner = makeOwner(lock.getTargetType(), lock.getRequestID()); - GuardResult result = managerLockTarget(lock.getTargetInstance(), owner, holdSec); + + boolean result = factory.getManager().refresh(lock.getTargetInstance(), owner, holdSec); logger.debug("Lock {} extend {}", lock, result); - return result; - } - - /** - * Asks the manager to lock the given target. - * @param targetInstance - * @param owner - * @param holdSec maximum number of seconds to hold the lock - * @return the result: acquired or denied - */ - private static GuardResult managerLockTarget(String targetInstance, String owner, int holdSec) { - boolean result = factory.getManager().lock(targetInstance, owner, holdSec); return(result ? GuardResult.LOCK_ACQUIRED : GuardResult.LOCK_DENIED); } @@ -210,7 +198,7 @@ public class PolicyGuard { throw new IllegalArgumentException("null requestID for lock type " + targetType); } - return factory.getHostname() + ":" + targetType + ":" + requestID; + return targetType + ":" + requestID; } /** @@ -224,12 +212,5 @@ public class PolicyGuard { public PolicyResourceLockManager getManager() { return PolicyResourceLockManager.getInstance(); } - - /** - * @return the current host name - */ - public String getHostname() { - return NetworkUtil.getHostname(); - } } } |