Age | Commit message (Collapse) | Author | Files | Lines |
|
Make test classes name consistence
Issue-ID: POLICY-1281
Change-Id: I2d70eda0a2fe7dc60e020dd91c743c1708d1f11a
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
|
|
Change-Id: I84fd562e7050508a75b4192ba162a09acd938986
Issue-ID: POLICY-1148
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
The root pom.xml had a syntax error in a declaration. The suppressions
xml was not being found by the sub-modules. It was better to create a
copy in each of the sub-modules where we will not be fixing
abbreviations or the interface declarations in own java file.
Added specific checkstyle files for each submodule.
One interesting note for the InheritDoc tag. It seems that the mvn
compile has a bug that interprets these as missing a period after
the tag. Even though the parent interface has it correctly. It was
easier to just remove it than duplicate.
There are new JIRA's for that work to be done in Dublin.
Fixed some spacing in pom's.
Issue-ID: POLICY-1131
Change-Id: I5f845958ccefd50a3b7290662da43c994870f1f7
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
|
|
* Changing TestHealthCheckReport to use openpojo for testing the
HealthCheckReport class.
* Adding a custom Tester implementation called ToStringTester
as a utility to test toString() method of classes using openpojo.
Change-Id: I491a23c471d50454b4d5591c6c09c6758e2c0624
Issue-ID: POLICY-1035
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
For this repo, we add an suppression filter for some abbreviation names.
It is far too cumbersome to rename these checkstyle issues at this time.
We will do so post-Casablanca release.
We copy the oparent checkstyle pom settings and set to fail on any
warnings.
Change-Id: Icfbd005819a3289acd30796693be85c2ea460212
Issue-ID: POLICY-881
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
* Adding HealthCheckReport class to policy/common for wider use
among all policy modules.
* Adding utility class called ParameterValidationUtils for providing
common validation methods to all policy modules. For now, it has only 3
validation methods but we all can add more in future.
Change-Id: I363fe116ba74f25299fd71211be73505b3164f72
Issue-ID: POLICY-1035
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
|
|
Cleared all the checkstyle in these 2 submodules.
Issue-ID: POLICY-881
Change-Id: I248e1894aebf549d5a4f8669a6466ec227d40b55
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
|
|
Add ResourceUtils, a class that provides utility methods
for dealing with Java resources on the classpath.
Change-Id: Ie4df249315ad145aabdfb35bb827ffbf6d79e095
Issue-ID: POLICY-922
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
|
|
Issue-ID: POLICY-967
Change-Id: I374c155ee102c3e157c60d0a22d7191544abb76a
Signed-off-by: mmis <michael.morris@ericsson.com>
|
|
|
|
|
|
Change-Id: Ie97d2c396ec6df1e03287a7ecb866bc8acf6cfbc
Issue-ID: POLICY-907
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Add some comments. Update license text.
Change-Id: I4cee208378c44d9730274aee337feb95f9026add
Issue-ID: POLICY-908
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
|
|
Change-Id: Ifa1785922b42f990d4d84c1410dd1d881b10647d
Issue-ID: POLICY-907
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Fortify generates a security exception when PropertyConfiguration
attempts to directly update private fields. PropertyConfiguration
has been modified to invoke setXxx() methods, instead, to set the
values for the fields.
Add junit tests for new methods.
Change-Id: Ic4420b6348724c5a384d3c2c8bf7b4c0c6350fa9
Issue-ID: POLICY-906
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Added PropertyConfiguration class, which provides for the loading of
properties into the fields of a subclass. Annotations are used to
identify the field to be loaded and the name of the property from
which it is to be loaded.
Changed attribute "useDefault" to "emptyOk" so that it only has to
be specified when the default value is empty.
Reformatted a couple of files.
Added setAllFields() method.
Added getRawPropertyValue() method so subclasses can change how
values are extracted from the property set.
Added SpecPropertyConfiguration so controller or session names
may be embedded within property names.
Fixed some typos.
Refactored out generalizeType2().
Changed exception classes to take field name instead of Field object.
Modified getValue() to take the field name and class type instead of
Field object.
Removed or fixed comments in junit tests.
Added more junit tests.
Changed emptyOk attribute to accept, to facilitate adding other
options in the future.
Corrected comments on the isEmptyOk() methods.
Change-Id: I6b190fea687f87cf512fb3236bfcf40b7adc4566
Issue-ID: POLICY-577
Signed-off-by: Jim Hahn <jrh3@att.com>
|
|
Removed checkstyle warnings in policy/common/utils
Issue-ID: POLICY-695
Change-Id: I831b74c889d44784d6328619d88eb92fb524ce74
Signed-off-by: mmis <michael.morris@ericsson.com>
|
|
Added EntityMgrCloser and EntityMgrTrans classes that will automatically
close/rollback the wrapped JPA classes. As a result, these classes can
be used in try-with-resource statements to ensure that the JPA
EntityTransaction is rolled back and the EntityManager is closed.
Add "build" section into pom to make it consistent with other poms
in common.
Changed scope to "provided" in utils pom for javax.persistence to
prevent clashes with other projects that depend on the utils project.
Changed scope to "test" in utils pom and to "provided" in utils-test
pom for junit.
Fixed license date in EntityTransCloser.
Fixed license titles in utils & utils-test source files.
Moved files from package xxx.test.jpa to package xxx.jpa, because they
are not test-specific classes.
Include exception when logging message in ThrowablesTester, hopefully
eliminating sonar complaint.
Change-Id: I531f20d93a679d4bb432c1d75c1feac0e334bc44
Issue-ID: POLICY-582
Signed-off-by: Jim Hahn <jrh3@att.com>
|