aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-07-26Merge "Add common parameter handling"Jorge Hernandez13-2/+673
2018-07-26Fix eclipse warnings in common loggingliamfallon2-5/+5
Minor annoying eclipse warnings due to raw Class and deprecated log enums removed. Change-Id: I7248b0c6fa4a4dc62104c75b07fadc5a144e8a47 Issue-ID: POLICY-716 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-07-25Add common parameter handlingliamfallon13-2/+673
This common module is proposed to handle all parameters and properties for the ONAP Policy Framework in a common way. Parameters and Properties: - are validated once when they are loaded and need not be checked again in classes that use them - are available for lookup in a parameter service, they need not be passed in constructors and method arguments - are input using a single implementiation of input method only (JSON/YAML/Java properties/REST) - are defined in a schema and the schema is used for validation as much as possible Issue-ID: POLICY-922 Change-Id: I1fac88b9e952b6b5fcbea04319cb4294a9653327 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-07-25Copy policy-endpoints from drools-pdp to commonmmis70-247/+9125
Issue-ID: POLICY-967 Change-Id: I374c155ee102c3e157c60d0a22d7191544abb76a Signed-off-by: mmis <michael.morris@ericsson.com>
2018-07-20Remove site-manager from common-modulesKevin McKiou30-2737/+0
Patch 1: The site-manager is specific to the AT&T environment and is not functional in ONAP. This change removes the site-manager module from the policy common-modules. Patch 2: Removed the site-manager from the pom.xml file. Issue-ID: POLICY-1001 Change-Id: Ibd8dd95915739205b0c5463c8b28706b615d9faf Signed-off-by: Kevin McKiou <km097d@att.com>
2018-07-10fixed Checkstyle warningsvamshi.nemalikonda2-138/+201
Issue-ID: POLICY-881 Signed-off-by: vamshi.nemalikonda <vn00480215@techmahindra.com> Change-Id: I4057306bec83a48921c90a081fb9752f663ee3b6
2018-07-03fixed Checkstyle warningsvamshi.nemalikonda1-31/+32
Issue-ID: POLICY-881 Signed-off-by: vamshi.nemalikonda <vn00480215@techmahindra.com> Change-Id: Idc0c088497b4a49789c3f0aedf034d380bd3af1c
2018-06-25Merge "IntegrityMonitor: remove sleep from junit tests"Pamela Dragosh12-195/+300
2018-06-21IntegrityAuditor: remove sleep from junit testsJim Hahn14-332/+270
Modified the code to use a CurrentTime object for its "time" operations (e.g., sleep(), currentTimeInMillis()). Modified junit tests to replace the CurrentTime object with TestTime objects so they don't actually do any sleeping. Reformat "commit" message. Remove TODO from junit test. Init testTime in junit setUp(). Add AuditorTime and test classes. Change "latch" to "semaphore" in comments. Change time units in junit test from SECONDS to MILLISECONDS. Add sleep() method to auditor test class. Reorder field qualifiers. Change utils scope to "compile" in pom. Change-Id: I8aa8b642b315156c00422192e4aa8e47b4503c2f Issue-ID: POLICY-908 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-21IntegrityMonitor: remove sleep from junit testsJim Hahn12-195/+300
Modified the code to use a CurrentTime object for its "time" operations (e.g., sleep(), currentTimeInMillis()). Modified junit tests to replace the CurrentTime object with TestTime objects so they don't actually do any sleeping. Update license date. Remove unneeded dependency from pom. Don't start FpManager thread within its own constructor. toMillis() should handle -1 as an input. Fix comment in test base superclass. Change time units in test base from DAYS to MILLISECONDS. Change-Id: Id6a4edb1747ca1a683e5d37522872b781294532d Issue-ID: POLICY-908 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-21Merge "PropertyUtil: remove sleep when running junit test"Pamela Dragosh3-29/+79
2018-06-21Merge "Delete SpecPropertyConfiguration class"Pamela Dragosh2-644/+0
2018-06-21Merge "IntegrityMonitory - remove latch for non-test code"Pamela Dragosh3-67/+93
2018-06-21Merge "IntegrityAudit - remove latches from non-test code"Pamela Dragosh3-117/+115
2018-06-21PropertyUtil: remove sleep when running junit testJim Hahn3-29/+79
Update licenses. Remove uneeded dependencies. Make "timer" field private. Make LazyHolder protected. Add comment to TestListener. Combine copyright lines. Change-Id: I77c198c9bc6c224fa93ef74d0c56aa73b187e169 Issue-ID: POLICY-908 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-20IntegrityAudit - remove latches from non-test codeJim Hahn3-117/+115
Change-Id: I5d5cc7d581f78d5551e2fe7447720403bb63ada2 Issue-ID: POLICY-908 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-20IntegrityMonitory - remove latch for non-test codeJim Hahn3-67/+93
Change-Id: I95ebcf8aabfa01eb6453a4ba5dd88d11c8f025c9 Issue-ID: POLICY-908 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-20Merge "Add CurrentTime utilities"Pamela Dragosh7-0/+566
2018-06-20Delete SpecPropertyConfiguration classJim Hahn2-644/+0
Change-Id: Ie97d2c396ec6df1e03287a7ecb866bc8acf6cfbc Issue-ID: POLICY-907 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-19Add CurrentTime utilitiesJim Hahn7-0/+566
Add some comments. Update license text. Change-Id: I4cee208378c44d9730274aee337feb95f9026add Issue-ID: POLICY-908 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-19Merge "Move SpecProperties from drools-pdp to common"Pamela Dragosh2-0/+341
2018-06-18Move SpecProperties from drools-pdp to commonJim Hahn2-0/+341
Change-Id: Ifa1785922b42f990d4d84c1410dd1d881b10647d Issue-ID: POLICY-907 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-18Use setXxx() methods for @Property fieldsJim Hahn4-180/+534
Fortify generates a security exception when PropertyConfiguration attempts to directly update private fields. PropertyConfiguration has been modified to invoke setXxx() methods, instead, to set the values for the fields. Add junit tests for new methods. Change-Id: Ic4420b6348724c5a384d3c2c8bf7b4c0c6350fa9 Issue-ID: POLICY-906 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-10Merge "Fix entry in logging message catalog"Pamela Dragosh1-1/+1
2018-06-08Remove "&quot;" from logback xml filesJim Hahn4-9/+9
Logback complains if %d{} values contain "&quot;", but it works fine without them, thus they have been removed. Update license header. Change-Id: Ie72cc5ec922c161e1fd5058021a57282c4f0134b Issue-ID: POLICY-785 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-08Fix entry in logging message catalogJim Hahn1-1/+1
Replaced hyphen with underscore in a resource id in the message catalog. Change-Id: I3734d87361a3a58f92db48a8c22b40e5eadead42 Issue-ID: POLICY-785 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-07Removing checkstyle warnings from ErrorsTestervamshi.nemalikonda1-15/+17
Change-Id: Ifc70d9682317033fd98b43ba802f9fd1acf519a8 Issue-ID: POLICY-881 Signed-off-by: vamshi.nemalikonda <vn00480215@techmahindra.com>
2018-06-07Fixed most of the Checkstyle warnings.vamshi.nemalikonda1-14/+14
Change-Id: I80b05663e81648058f84aff5d5cda2deaa2d87c9 Issue-ID: POLICY-881 Signed-off-by: vamshi.nemalikonda <vn00480215@techmahindra.com>
2018-06-05Update policy-common to SNAPSHOT-1.3.0liamfallon8-9/+9
Snapshot updated for Casablanca. Change-Id: Ife941f771b02be68e35fd638adfac78cf2b3ba99 Issue-ID: POLICY-875 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-21Use ${POLICY_LOGS} for log directoryv1.2.32.0.0-ONAPbeijing2.0.0-ONAPJim Hahn2-6/+6
Update license date. Change-Id: I912e1d8ab56b124178b4bfdd8646ee62b48b386c Issue-ID: POLICY-759 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-05-21Update Policy Common to 1.2.3-SNAPSHOTliamfallon8-8/+8
These reviews must be merged in order because of layering. This review should be merged FIRST. Issue-ID: POLICY-844 Change-Id: I7cf07902c3b2d7766dc64f1c1dd80d91dee18467 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-16Upgrade 1.2.2 version.propertiesv1.2.2Pamela Dragosh1-1/+1
This file needs to be upgraded also. Issue-ID: POLICY-798 Change-Id: I9a899b9889e0cb0cf82d65dba6f86af5613e201e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-05-16Upgrade SNAPSHOT to 1.2.2liamfallon7-7/+7
These reviews must be merged in order because of layering. This review should be merged FIRST Change-Id: If143b2d23487c073fafad8f6208cd8d320ec98e9 Issue-ID: POLICY-798 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-05-01Add INFO.yaml filev1.2.1Jessica Wagantall1-0/+37
Add INFO.yaml to list: - Project description - Properties - PTL information - Meeting information - Committer information Change-Id: Ia4f34d6a00c7d5f0b5a830ca58de20445ff2b224 Issue-ID: CIMAN-134 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2018-04-13Add missing licensesPamela Dragosh3-0/+21
Issue-ID: POLICY-741 Change-Id: Iac1b4a61dbdc6de46fa82357076d6b3b44b128f1 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-04-13Upgrade SNAPSHOT to 1.2.1Pamela Dragosh8-8/+8
Issue-ID: POLICY-736 Change-Id: Iccb43b692908ffc35fc0d18da1e967718e3c3519 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-03-28Remove ECOMP trademarkv1.2.0Pamela Dragosh1-2/+0
Issue-ID: POLICY-696 Change-Id: I036dbbe004e4e37b5ffa95e416dab3ec507046d2 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-03-28Removed checkstyle warningseikrwaq18-182/+341
Change-Id: I350bbd414477fe0b480c1bc4e7fa60b1e63842a7 Issue-ID: POLICY-712 Signed-off-by: eikrwaq <waqas.ikram@ericsson.com>
2018-03-25Add PropertyConfiguration classJim Hahn15-0/+2896
Added PropertyConfiguration class, which provides for the loading of properties into the fields of a subclass. Annotations are used to identify the field to be loaded and the name of the property from which it is to be loaded. Changed attribute "useDefault" to "emptyOk" so that it only has to be specified when the default value is empty. Reformatted a couple of files. Added setAllFields() method. Added getRawPropertyValue() method so subclasses can change how values are extracted from the property set. Added SpecPropertyConfiguration so controller or session names may be embedded within property names. Fixed some typos. Refactored out generalizeType2(). Changed exception classes to take field name instead of Field object. Modified getValue() to take the field name and class type instead of Field object. Removed or fixed comments in junit tests. Added more junit tests. Changed emptyOk attribute to accept, to facilitate adding other options in the future. Corrected comments on the isEmptyOk() methods. Change-Id: I6b190fea687f87cf512fb3236bfcf40b7adc4566 Issue-ID: POLICY-577 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-03-22Add junit and refactor codeeikrwaq25-344/+2151
Adding Junit tests in modules and refactoring code Change-Id: I887f1b2371d9e3d4a4e2ce6e7e1f3c97a361f283 Issue-ID: POLICY-704 Signed-off-by: eikrwaq <waqas.ikram@ericsson.com>
2018-03-21Merge "Removed checkstyle warnings"Pamela Dragosh1-494/+399
2018-03-21Merge "Removed checkstyle warnings"Pamela Dragosh20-5242/+5196
2018-03-20Removed checkstyle warningsmmis20-5242/+5196
Removed checkstyle warnings in policy/common/ia Issue-ID: POLICY-695 Change-Id: I25f589dff5ce1dba0681ba549a53087426593d71 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-03-20Removed checkstyle warningsmmis1-494/+399
Removed checkstyle warnings in policy/common/sitemanager Issue-ID: POLICY-695 Change-Id: I9ac6f95e7e259016e0ad9ad7caced59e4d6b84a0 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-03-20Removed checkstyle warningsmmis29-7603/+7889
Removed checkstyle warnings in policy/common/im Issue-ID: POLICY-695 Change-Id: I32b4797249386c0d1bd0f50792880a1759503a67 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-03-20Merge "Removed checkstyle warnings"Pamela Dragosh37-4616/+4848
2018-03-20Removed checkstyle warningsmmis37-4616/+4848
Removed checkstyle warnings in policy/common/logging Some warnings remain that required renaming of classes and public methods. These will be taken separately Issue-ID: POLICY-695 Change-Id: Id604c66708917de390c556b50f6266f929b09134 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-03-17Fixing reported bug in Sonar for policy/commoneikrwaq1-182/+170
Change-Id: I449259749f93a5b9058c76e99d96465466458a56 Issue-ID: POLICY-661 Signed-off-by: eikrwaq <waqas.ikram@ericsson.com>
2018-03-16Merge "Fixing 12 reported bugs in Sonar for policy/common"Pamela Dragosh5-368/+476
2018-03-16Fixing 12 reported bugs in Sonar for policy/commoneikrwaq5-368/+476
Change-Id: I7bf453828f7a62070e7a73362798e6f2d4806b2f Issue-ID: POLICY-661 Signed-off-by: eikrwaq <waqas.ikram@ericsson.com>