aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-10-12Release policy/common 1.9.1liamfallon1-0/+4
Issue-ID: POLICY-3696 Change-Id: Ia942f56bbd02a76d13a6b5511bd7872db502f171 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-10-12Point at released policy/parentliamfallon1-1/+1
Issue-ID: POLICY-3696 Change-Id: Ib9769f66ba2da0726cbabca17fc07e5a44082b1a Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-09-22Don't use keytool in test codeJim Hahn3-37/+78
Modified code to generate a self-signed certificate file programmatically instead of using keytool. Issue-ID: POLICY-3587 Change-Id: I53b6ffe65f33e5710eba633973e5d23b148f049f Signed-off-by: Jim Hahn <jrh3.lf@gmail.com>
2021-09-20Revert ignoring tests in commonRam Krishna Verma1-6/+0
Reverting the ignoring of tests in common as the staging jobs have been marked to skip tests. Issue-ID: POLICY-3587 Change-Id: Idcb9f432d1f563ba5e072c0c7511de7b650163fa Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2021-09-13Bump snapshot versionliamfallon11-11/+11
Issue-ID: POLICY-3587 Change-Id: I11043890dfd4dfbc19ec24eb15a546745393d105 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-09-13Release policy-common 1.9.0liamfallon1-0/+4
Issue-ID: POLICY-3587 Change-Id: I76b7a870e330154394a8e1b20e711ab97fed01d7 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-09-13Work around test failure in staging jobliamfallon1-2/+8
The "keytool" program does not exist in the Jenkins staging job environment, so the test case that checks for a keytool error message fails because an unexpected error message is received. Other tests also break so the tests are morked with @Ignore for now. Issue-ID: POLICY-3587 Change-Id: Iebdbce8f5e61fb209d65198d7f7e28f5ca70e589 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-09-13Fix test failure in staging jobliamfallon1-2/+2
The "keytool" program does not exist in the Jenkins staging job environment, so the test case that checks for a keytool error message fails because an unexpected error message is received. By changing the test case to expect "keytool" rather than "keytool exited with", then the test will pass when the error message "Cannot run program "keytool": error=2, No such file or directory" is returned. Issue-ID: POLICY-3587 Change-Id: I3a6b77fb571cfbf170f5f16bf93eece2d78a7bbb Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-09-09Point at released policy-parentliamfallon1-1/+1
Issue-ID: POLICY-3587 Change-Id: I5827b432e436620d4e014dbc4d97e0bacdb7e8e9 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-09-09Merge "Update INFO.yaml"Pamela Dragosh1-10/+13
2021-09-09Point at released policy parentliamfallon1-1/+1
Issue-ID: POLICY-3587 Change-Id: Ia541b927eb591f2790141f11f40f3124c32beb6d Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-09-08Update INFO.yamlliamfallon1-10/+13
Update the INFO.yaml file with latest information. Issue-ID: POLICY-3552 Change-Id: Icc9b3dc4bfa2266cc1c023761861ca22b1f6f586 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-09-02Create methods for creating temp filesJim Hahn6-67/+224
Created utility methods to create temp files and set default permissions. These can be used in other repos to satisfy sonar. Also added code to close streams and clean up temp files created by some junit tests. Modified to use IOUtils to read a stream. Issue-ID: POLICY-3289 Change-Id: Ic83e4f4d7745be7b37ebb42bf1d81e303d8dadc9 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-23Support multiple filters in RestServerJim Hahn2-8/+58
Added an API to RestServer so that multiple Filters may be provided. Issue-ID: POLICY-3531 Change-Id: I21f474c01d58237c744d1d70f5b39c2c90fdb401 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-23Merge "Prevent deadlock in ServiceManager"Ram Krishna Verma1-9/+10
2021-08-23Merge "Fix sonars and java warnings in common"Ram Krishna Verma2-36/+5
2021-08-23Prevent deadlock in ServiceManagerJim Hahn1-9/+10
Modified the ServiceManager code so that isAlive() can be invoked without requiring synchronization, thus eliminating one potential area of deadlock. Issue-ID: POLICY-3531 Change-Id: I27d060c3a7cfad8dab20a197d1e42c4ee607a1e2 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-23Disable prometheus by default in policy/commona.sreekumar1-1/+1
Change-Id: I30acac6ea84bfb032994e81a93f38443818a0d1a Issue-ID: POLICY-3538 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-08-20Fix sonars and java warnings in commonJim Hahn2-36/+5
Issue-ID: POLICY-3284 Change-Id: I13fc28c6ae681871be8bb9cf3d222d7c65459a44 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-18Add topic checkerJim Hahn2-1/+380
Added a method to check the readiness of a bidirectional topic. Issue-ID: POLICY-3531 Change-Id: I2fefae7ba1ea5ed9ed33140717d05828e6dec94d Signed-off-by: Jim Hahn <jrh3@att.com>
2021-08-18Integrating prometheus with Policy componentsa.sreekumar13-41/+292
With this change, all PF components can export prometheus metrics by default. The prometheus metrics servlet will be running on /metrics servletPath.. If the metrics shouldn't be exported, just add a flag "promethus": false in the restServerParameters of default configuration file. This brings up prometheus servlet on /metrics servletPath. Also as part of standard servlet support, "servletUriPath" and "servletClass" are 2 other fields added to RestServerParameters which can be used to add standard servlets. This can be revisited later if needed. Basically, any servlet can be added by passing these fields, for example, to add prometheus metrics servlet on /test/metrics, add the below to restServerParameters: "servletUriPath": "/test/metrics", "servletClass": "io.prometheus.client.exporter.MetricsServlet" In addition, we can later go to individual components and add more metrics, say for e.g., deployedPoliciesCounter/undeployedPoliciesCounter etc on PAP, executedEvents/failedEvents etc on PDP and so on. This will look something like below, for e.g. in policy-pap component: io.prometheus.client.Counter counter = Counter.build() .name("policies_deployed_total") .help("Number of policies deployed.").register() Whenever a policy is deployed, just call counter.inc() Usage of code like above in the individual component will expose such data as well as part of the exposed metrics. Change-Id: Id667f27b15c012398421ba657b5324cc1d82cf1f Issue-ID: POLICY-3524 Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca> Signed-off-by: jhh <jorge.hernandez-herrero@att.com> Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2021-08-04refactor slf4j logger to common utilTaka Cho4-4/+3
avoid EELF lib dependency, was suggested to move to common util instead Issue-ID: POLICY-3087 Change-Id: I79a2f5ba32fd3fc496ef3f72a02f4696b766f9c7 Signed-off-by: Taka Cho <takamune.cho@att.com>
2021-08-02refactor slf4j Marker to common repoTaka Cho3-0/+286
slf4j Marker logger is using in drools-pdp and clamp. was suggested to move to common repo to reduce duplicated codes. And possibly other repo would be used also. Issue-ID: POLICY-3087 Change-Id: If14b89c18e28f517f83a2b9a8dcce201333a919e Signed-off-by: Taka Cho <takamune.cho@att.com>
2021-07-13Update Pam's email INFO.yamlDragosh, Pamela (pd1248)1-1/+1
Issue-ID: POLICY-3484 Change-Id: I57aa0b25c104acaa5529f95ee2cbf4e5c73195ab Signed-off-by: Dragosh, Pamela (pd1248) <pd1248@att.com>
2021-07-02Merge "Use UUID for topic consumer instance"Jim Hahn2-11/+36
2021-07-02Wait after fetch exception on topicJim Hahn2-10/+52
When dmaap is inaccessible for some reason, the topic source frequently enters a fast fail loop, rapidly filling up the log. Modified the code to wait the configured fetchTimeout when this occurs. With any luck, this will also fix the sporadic kubernetes crash-fail loops sometimes seen with the xacml-pdp pod. Modified to limit how long it will sleep after a failure, regardless of the fetchTimeout that was specified. Issue-ID: POLICY-3457 Change-Id: I88e360fb1d31197b46f4959e5ea0ea2d741ad25c Signed-off-by: Jim Hahn <jrh3@att.com>
2021-07-01Use UUID for topic consumer instanceJim Hahn2-11/+36
Modified the code so that if the consumer group is defined, but the consumer instance is not, then policy-endpoints will generate a UUID for the consumer instance. Made the logic a little more straight-forward in response to a review comment. Issue-ID: POLICY-3405 Change-Id: If74440bdb01525bc463a28e5b8a9a2eca89a855a Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-29Address sonars in commonJim Hahn4-58/+74
Fixed: - use "var" - duplicate code block Issue-ID: POLICY-3284 Change-Id: I8cd7f2588353a2e7702c90d37d7b9f972634dca9 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-29Merge "Add name generator for PAP and PDPs"Ajith Sreekumar2-1/+23
2021-06-28Merge "Update policy-common for checkstyle 8.43"Liam Fallon1-1/+2
2021-06-28Update policy-common for checkstyle 8.43liamfallon1-1/+2
Issue-ID: POLICY-3206 Change-Id: I6d14a62e6619e2162e68846853feb36b95274866 Signed-off-by: liamfallon <liam.fallon@est.tech>
2021-06-25Add name generator for PAP and PDPsJim Hahn2-1/+23
Added a method that PAPs and PDPs can use to generate a unique name or identifier to be used in PAP-PDP messages. Issue-ID: POLICY-3410 Change-Id: I22b075b123f79ba05e0884f743296c4bc64842b9 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-22Move Validators and RestClientParameters in policy-commonFrancescoFioraEst4-0/+159
Issue-ID: POLICY-3402 Change-Id: I7479027e3ea1e960266264c2d13cd69e2103710b Signed-off-by: FrancescoFioraEst <francesco.fiora@est.tech>
2021-06-18Merge "Fix new checkstyle issues in policy-common"Jim Hahn4-6/+5
2021-06-18Merge "Use lombok in policy-endpoints"Jim Hahn24-399/+104
2021-06-18Fix new checkstyle issues in policy-commonJim Hahn4-6/+5
The new version of checkstyle identified new issues. Fixed those. Issue-ID: POLICY-3284 Change-Id: I2a8bf2b460fda7972ce573f14df5af52d46c9993 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-18Use lombok in policy-common utils-testJim Hahn6-46/+19
Issue-ID: POLICY-3394 Change-Id: I85504848afc268be7419654dc95ed555d870272c Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-18Merge "Use lombok in policy-common utils"Jim Hahn22-224/+109
2021-06-17Merge "Use lombok annotations in IM and ONAP logging"Jim Hahn20-467/+129
2021-06-17Use lombok in policy-common utilsJim Hahn22-224/+109
Issue-ID: POLICY-3394 Change-Id: I42a18c115c3ca7110f37fc0ae8aeea3f2bbffb37 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-17Use lombok in policy-endpointsJim Hahn24-399/+104
Issue-ID: POLICY-3394 Change-Id: I8dfb0814d5cc544b2c334dc11a3e69ef407f163f Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-17Use lombok annotations in IM and ONAP loggingJim Hahn20-467/+129
Issue-ID: POLICY-3394 Change-Id: I25db6b4b13bad8754889eaedb93197cae7d27c4d Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-16Use lombok in common paramsJim Hahn14-240/+80
Also condensed some Map calls. Issue-ID: POLICY-3394 Change-Id: I850fcad5a72d92271da76b0731195e8b93dd4089 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-06-01Validator should report serialized field nameJim Hahn3-4/+15
The validator reports field names as they appear in the class rather than as they appear on the wire, which may be confusing to the client. Modified the code to use the serialized name instead. Note: this will require tweaks to some junits in some of the other policy repos. Issue-ID: POLICY-3333 Change-Id: I867dafdc87cd78dec3d3c6fe0236a744284314a3 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-27Fix sonar issues in commonJim Hahn1-1/+1
Fixed sonar issue: - class should not be abstract Issue-ID: POLICY-3284 Change-Id: I9c4aa149b7321cbcaff8dce5e2999315a06f19b0 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-24Merge "Enhance toString methods in factory classes"Jim Hahn28-236/+89
2021-05-21Fix sonar duplicate code issueJim Hahn2-50/+109
Issue-ID: POLICY-3284 Change-Id: I78c3a8ac92e18e2b0088eb07e27a4e97866d6182 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-21Enhance toString methods in factory classesJim Hahn28-236/+89
The factory classes in policy-endpoints have toString() methods that return "[]" for their list contents. Updated the code to provide a list of the keys rather than just an empty list. Also replaced some toString() methods with lombok. Also replace StringBuilder with concatenation in some cases. Issue-ID: POLICY-3298 Change-Id: I64fca21a4b009f7e09fcc482b5d156753fb7e680 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-07Change java.util.regex to re2jJim Hahn20-20/+28
Sonar complains about java.util.regex. Thought I used re2j when creating all of the patterns, but apparently not. Fixed that oversight. Issue-ID: POLICY-3284 Change-Id: Idbec112ab0d4c3b477ce357f8a556d95e4dea083 Signed-off-by: Jim Hahn <jrh3@att.com>
2021-05-06Fix sonars in policy-commonJim Hahn83-452/+496
Fixed sonars: - use "var" instead of actual type name - re-interrupt threads - use rej2 split() instead of String split() Issue-ID: POLICY-3285 Change-Id: I82261e0b8a53ee5c5264556fbf5cec37454f014e Signed-off-by: Jim Hahn <jrh3@att.com>