aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-08-28Merge "Adding usage of openpojo in policy common"Pamela Dragosh4-130/+200
2018-08-28Adding usage of openpojo in policy commonramverma4-130/+200
* Changing TestHealthCheckReport to use openpojo for testing the HealthCheckReport class. * Adding a custom Tester implementation called ToStringTester as a utility to test toString() method of classes using openpojo. Change-Id: I491a23c471d50454b4d5591c6c09c6758e2c0624 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-28Improvements to Parameter Srviceliamfallon20-44/+300
Add proper handling for optional parameters Add setName() to the parameter group interface to force definition of that method Add some convenience metnods to parameter service Issue-ID: POLICY-1035 Change-Id: Iaa9226f45215b00aff9b78ab5fc120c24a0af46d Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-08-23Make checkstyle warnings failPamela Dragosh3-1/+49
For this repo, we add an suppression filter for some abbreviation names. It is far too cumbersome to rename these checkstyle issues at this time. We will do so post-Casablanca release. We copy the oparent checkstyle pom settings and set to fail on any warnings. Change-Id: Icfbd005819a3289acd30796693be85c2ea460212 Issue-ID: POLICY-881 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-22Adding common utility classes to policy/commonramverma4-0/+329
* Adding HealthCheckReport class to policy/common for wider use among all policy modules. * Adding utility class called ParameterValidationUtils for providing common validation methods to all policy modules. For now, it has only 3 validation methods but we all can add more in future. Change-Id: I363fe116ba74f25299fd71211be73505b3164f72 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-20Use builder for http and jersey clientKrishnajinka8-122/+218
Sonar issue with more than 7 params in a method. Use builder object instead of params. Rework2 for fixing review comments. Add modifications copyright Issue-ID: POLICY-1017 Change-Id: Ib0fa692f8da770dcba06158d6e6cafbed2969c27 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-15Fix checkstyle comments etc.Pamela Dragosh22-165/+225
Adding javadoc comments, renaming variables names, fixed whitespace and 120 length. Also some variables were made final since they were declared further from usage. Splitting out Asserts. Still remaining are the abbreviations. Issue-ID: POLICY-881 Change-Id: I31ce5a9eea02578bce023c0c607a19108bb726fa Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-14Merge "Fixes for checkstyle issues"Jorge Hernandez17-52/+80
2018-08-14Fixes for checkstyle issuesPamela Dragosh17-52/+80
More fixes for spacing, adding comments, adding period at the end, and move code closer to usage. Issue-ID: POLICY-881 Change-Id: Ife99eaf627a221e87d65d24dfd145b0ee4e06d21 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-14Modify topic factory to use builder paramKrishnajinka6-369/+257
Fix sonar issue with method build using more than 7 params Use BusTopicParams to send parameters into methods Issue-ID: POLICY-1017 Change-Id: I194284da63cb95f91ce2e8a8c21a526a5ab9f6f3 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-13Fix checkstyle in utilsPamela Dragosh28-999/+1069
Cleared all the checkstyle in these 2 submodules. Issue-ID: POLICY-881 Change-Id: I248e1894aebf549d5a4f8669a6466ec227d40b55 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-13Remove simple checkstylePamela Dragosh38-505/+526
Mostly concentrated on the period at the end of summary. But I did clear a few others for longer than 120 characters and placement of methods next to each other. Possibly a few others. I did not clear everything, but will submit a few more reviews to get the others. Issue-ID: POLICY-881 Change-Id: I692a5349d686d52fee4040757cdc2ed8b5cc221b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-10Merge "get time from correct timer object"Pamela Dragosh1-1/+1
2018-08-10get time from correct timer objectJim Hahn1-1/+1
Change-Id: Ie060e45d2cda368ffbb5908b41594d7795bae40b Issue-ID: POLICY-1045 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-08-09Merge "Fix bug in common-paramter validation service"Pamela Dragosh8-7/+70
2018-08-09Merge "generic jetty filter and cadi support"Pamela Dragosh7-65/+155
2018-08-09Fix bug in common-paramter validation serviceramverma8-7/+70
In GroupValidationResult & GroupMapValidationResult, the setResult method was not setting the actual status that it has recieved from the nested group rather it was setting its own status again. Due to which the validation status of overall ParameterGroup was coming as CLEAN even if a nested child has reported it as INVALID. Changed the expected validation result texts for TestValidation accordingly. Change-Id: I5943decce39574089ca74f9bbccbfbe66d8d542c Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-08generic jetty filter and cadi supportJorge Hernandez7-65/+155
Change-Id: I363e44e85e1d89c6254218629010d5c3e1507e0a Issue-ID: POLICY-1043 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-08-06Apply builder pattern for topic cnsmer prdcrkrishnajinka15-538/+711
Modify endpoints event bus related classes to use builder pattern in particular apply bus topic params object instead of using parameters as it is. Rework based on commnts Issue-ID: POLICY-1017 Change-Id: I572a72fa525cf4f664eb70d0415be73116499bd2 Signed-off-by: krisjinka <kris.jinka@samsung.com>
2018-08-03Merge "generic jetty https server support"Pamela Dragosh7-30/+176
2018-08-03Merge "Use builder in Bus DMaap UEB Topic constrctr"Liam Fallon5-124/+307
2018-08-03generic jetty https server supportJorge Hernandez7-30/+176
jetty https support in constructor, or by using ".https" when creating an http server service. Change-Id: I94e8e3e4b93eb6b194657028c740b6781316c7da Issue-ID: POLICY-940 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-08-03Upgrade jetty to clear security issuePamela Dragosh1-1/+1
This got missed in this repository Issue-ID: POLICY-1030 Change-Id: Ib62fd66cc8cb74b7579f9eddbba675e4c1d16c2a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-03Fix pom and checkstyle warnings in commonliamfallon19-37/+35
Some dependency versions are now managed in the master POM Checkstyle showed up some warnings in paramters and capabilities. Change-Id: Ifebd8a076bdb3fda626b5b1fda9324801bf58643 Issue-ID: POLICY-716 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-08-03Use builder in Bus DMaap UEB Topic constrctrKrishnajinka5-124/+307
Constructors of the Bus Dmaap Ueb topic source class using many param Refactor to use builder pattern for clean code implementation. Issue-ID: POLICY-1017 Change-Id: Iea75b64ad232e83541a60a03a19cbb598c370cff Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-01Merge "Add resource handling utility class"Jorge Hernandez3-0/+541
2018-07-31Add resource handling utility classliamfallon3-0/+541
Add ResourceUtils, a class that provides utility methods for dealing with Java resources on the classpath. Change-Id: Ie4df249315ad145aabdfb35bb827ffbf6d79e095 Issue-ID: POLICY-922 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-07-31Merge "Improve validation, add hierarchical validation"Jorge Hernandez44-126/+2561
2018-07-31Improve validation, add hierarchical validationliamfallon44-126/+2561
Parameter validaiton updated to generically support nested groups of parameters, and nested maps of parameters. Unit test showing JSON parameter input added. Unit test showing YAML parameter inout added. Test parameter group classes moved into subdirectory This allows parameters to be unmarshaled seamlessly from JSON and YAML files. Change-Id: I768e11f31ee7f62299c4d5d95ab68a005d1aff16 Issue-ID: POLICY-922 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-07-31Copy policy-endpoints from drools-pdp to commonmmis43-3481/+2966
Removed changes made in commit b40acf2d244058c162a8597968e59f2708e6abf4 that went beyond the scope of POLICY-967 Issue-ID: POLICY-967 Change-Id: Ibbf78540dec8bf8601a62dacc8c7056d43f70ba1 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-07-28support ueb/dmaap https related configurationJorge Hernandez3-5/+11
Change-Id: Ide2e3524cbbf0a8caf36ad48c003b7500482ad4a Issue-ID: POLICY-941 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-07-26Merge "Add common parameter handling"Jorge Hernandez13-2/+673
2018-07-26Fix eclipse warnings in common loggingliamfallon2-5/+5
Minor annoying eclipse warnings due to raw Class and deprecated log enums removed. Change-Id: I7248b0c6fa4a4dc62104c75b07fadc5a144e8a47 Issue-ID: POLICY-716 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-07-25Add common parameter handlingliamfallon13-2/+673
This common module is proposed to handle all parameters and properties for the ONAP Policy Framework in a common way. Parameters and Properties: - are validated once when they are loaded and need not be checked again in classes that use them - are available for lookup in a parameter service, they need not be passed in constructors and method arguments - are input using a single implementiation of input method only (JSON/YAML/Java properties/REST) - are defined in a schema and the schema is used for validation as much as possible Issue-ID: POLICY-922 Change-Id: I1fac88b9e952b6b5fcbea04319cb4294a9653327 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-07-25Copy policy-endpoints from drools-pdp to commonmmis70-247/+9125
Issue-ID: POLICY-967 Change-Id: I374c155ee102c3e157c60d0a22d7191544abb76a Signed-off-by: mmis <michael.morris@ericsson.com>
2018-07-20Remove site-manager from common-modulesKevin McKiou30-2737/+0
Patch 1: The site-manager is specific to the AT&T environment and is not functional in ONAP. This change removes the site-manager module from the policy common-modules. Patch 2: Removed the site-manager from the pom.xml file. Issue-ID: POLICY-1001 Change-Id: Ibd8dd95915739205b0c5463c8b28706b615d9faf Signed-off-by: Kevin McKiou <km097d@att.com>
2018-07-10fixed Checkstyle warningsvamshi.nemalikonda2-138/+201
Issue-ID: POLICY-881 Signed-off-by: vamshi.nemalikonda <vn00480215@techmahindra.com> Change-Id: I4057306bec83a48921c90a081fb9752f663ee3b6
2018-07-03fixed Checkstyle warningsvamshi.nemalikonda1-31/+32
Issue-ID: POLICY-881 Signed-off-by: vamshi.nemalikonda <vn00480215@techmahindra.com> Change-Id: Idc0c088497b4a49789c3f0aedf034d380bd3af1c
2018-06-25Merge "IntegrityMonitor: remove sleep from junit tests"Pamela Dragosh12-195/+300
2018-06-21IntegrityAuditor: remove sleep from junit testsJim Hahn14-332/+270
Modified the code to use a CurrentTime object for its "time" operations (e.g., sleep(), currentTimeInMillis()). Modified junit tests to replace the CurrentTime object with TestTime objects so they don't actually do any sleeping. Reformat "commit" message. Remove TODO from junit test. Init testTime in junit setUp(). Add AuditorTime and test classes. Change "latch" to "semaphore" in comments. Change time units in junit test from SECONDS to MILLISECONDS. Add sleep() method to auditor test class. Reorder field qualifiers. Change utils scope to "compile" in pom. Change-Id: I8aa8b642b315156c00422192e4aa8e47b4503c2f Issue-ID: POLICY-908 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-21IntegrityMonitor: remove sleep from junit testsJim Hahn12-195/+300
Modified the code to use a CurrentTime object for its "time" operations (e.g., sleep(), currentTimeInMillis()). Modified junit tests to replace the CurrentTime object with TestTime objects so they don't actually do any sleeping. Update license date. Remove unneeded dependency from pom. Don't start FpManager thread within its own constructor. toMillis() should handle -1 as an input. Fix comment in test base superclass. Change time units in test base from DAYS to MILLISECONDS. Change-Id: Id6a4edb1747ca1a683e5d37522872b781294532d Issue-ID: POLICY-908 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-21Merge "PropertyUtil: remove sleep when running junit test"Pamela Dragosh3-29/+79
2018-06-21Merge "Delete SpecPropertyConfiguration class"Pamela Dragosh2-644/+0
2018-06-21Merge "IntegrityMonitory - remove latch for non-test code"Pamela Dragosh3-67/+93
2018-06-21Merge "IntegrityAudit - remove latches from non-test code"Pamela Dragosh3-117/+115
2018-06-21PropertyUtil: remove sleep when running junit testJim Hahn3-29/+79
Update licenses. Remove uneeded dependencies. Make "timer" field private. Make LazyHolder protected. Add comment to TestListener. Combine copyright lines. Change-Id: I77c198c9bc6c224fa93ef74d0c56aa73b187e169 Issue-ID: POLICY-908 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-20IntegrityAudit - remove latches from non-test codeJim Hahn3-117/+115
Change-Id: I5d5cc7d581f78d5551e2fe7447720403bb63ada2 Issue-ID: POLICY-908 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-20IntegrityMonitory - remove latch for non-test codeJim Hahn3-67/+93
Change-Id: I95ebcf8aabfa01eb6453a4ba5dd88d11c8f025c9 Issue-ID: POLICY-908 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-06-20Merge "Add CurrentTime utilities"Pamela Dragosh7-0/+566
2018-06-20Delete SpecPropertyConfiguration classJim Hahn2-644/+0
Change-Id: Ie97d2c396ec6df1e03287a7ecb866bc8acf6cfbc Issue-ID: POLICY-907 Signed-off-by: Jim Hahn <jrh3@att.com>