aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-10-05Merge "Remove constraints"1.3.0Jorge Hernandez1-2/+1
2018-10-05Remove constraintsPamela Dragosh1-2/+1
Sonar is flagging the null checks. Issue-ID: POLICY-1130 Change-Id: I4ab94b3db79d4089f20afaf3f80f3c925541084a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-10-03Support Throwables in expectException()Jim Hahn2-18/+39
Also fixed some bugs in the junit tests. Renamed expectException() to assertThrows(). Added test cases. Change-Id: I13dff0007e35c2d2521a4ca40bb65e6820416ed1 Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-10-02Add expectException to policy-commonJim Hahn2-0/+128
Also fixed new checkstyle error. Change-Id: I2d2c2518f3f7da1a0ace8c32e10b4151d941bb6f Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-10-01Fix minor sonarPamela Dragosh7-173/+215
These are mainly duplicate strings. But also combined if statements and fixing some debug messages missing arguments or format specifiers. Some duplicates I left alone as it seemed unreadable to change them. Also moving variables to their correct place (before constructors). Issue-ID: POLICY-1130 Change-Id: I8018c676b22fe8fec635f129fa37921ad1004569 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-29Fix RestManager test issueJim Hahn3-2/+26
Apparently drools-pdp code depends on Dmaap topic factories throwing IllegalArgumentException instead of IllegalStateException (which is what the other topic factories throw) when an unknown topic name is requested. Therefore, the change to make them consistent has been backed out. Change-Id: Ia3d7e26a61027977eb626c9ddad6369982eae002 Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-28Add junit coverage to rest of policy-endpoint busJim Hahn33-648/+1637
Also extracted out common code from tests. Fix checkstyle issues. Be consistent in returning IllegalStateException when topic is not found by any Topic Factory. Added/updated some comments. Use better name for "validate" argument. Renamed test() to testDestroy(). Added NoopTopicPropertyBuilder. Renamed BusTopicTestBase to TopicTestBase. Change-Id: Id4c7ab9f2b5572dc5195b0da116e285c5e9b6f06 Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-28Merge "Add coverage for policy-endpoints bus"Jorge Hernandez9-11/+1280
2018-09-27Add coverage for policy-endpoints busJim Hahn9-11/+1280
Added license. Fix checkstyle warnings. Change-Id: I2279b8b80b3dc175583353ced3d71c3a5cc4f975 Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-27Merge "Added more coverage to policy-endpoints internal"Pamela Dragosh6-0/+873
2018-09-27Added more coverage to policy-endpoints internalJim Hahn6-0/+873
Fixed checkstyle error. Change-Id: Ie6a85633bab098a30ccb2c1c309e1640aa1c8131 Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-27Merge "Use powermock version from parent pom"Pamela Dragosh5-37/+1
2018-09-26Add junit coverage to policy-commonJim Hahn10-9/+1170
Added coverage tests for policy-endpoints. Fixed new checkstyle warnings. Use powermock version from parent pom. Replaced literals with constants in new tests. Moved test superclass higher up the class hierarchy so it can be re-used. Removed powermock version. Change-Id: I7d3d45132cd0973f4d02d3af320a1d53a1234e4d Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-26Use powermock version from parent pomJim Hahn5-37/+1
Change-Id: I84fd562e7050508a75b4192ba162a09acd938986 Issue-ID: POLICY-1148 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-21Fix policy/common checkstyle issuesPamela Dragosh28-334/+446
The root pom.xml had a syntax error in a declaration. The suppressions xml was not being found by the sub-modules. It was better to create a copy in each of the sub-modules where we will not be fixing abbreviations or the interface declarations in own java file. Added specific checkstyle files for each submodule. One interesting note for the InheritDoc tag. It seems that the mvn compile has a bug that interprets these as missing a period after the tag. Even though the parent interface has it correctly. It was easier to just remove it than duplicate. There are new JIRA's for that work to be done in Dublin. Fixed some spacing in pom's. Issue-ID: POLICY-1131 Change-Id: I5f845958ccefd50a3b7290662da43c994870f1f7 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-21new sonar issues in policy/commonJim Hahn2-29/+56
Only throw one type of exception in Serializer. Try to increase test coverage in Serializer. Change-Id: I170de0ab727041aa42731c08d6cc454731d29a20 Issue-ID: POLICY-1130 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-19tweaks from testing in auth classesJorge Hernandez3-4/+3
Change-Id: Idb1346ca645ffcc55808e25c8957e01d27a48a75 Signed-off-by: Jorge Hernandez <jh1730@att.com> Issue-ID: POLICY-1043
2018-09-19error getting aaf configuration flagJorge Hernandez2-2/+2
Change-Id: I98c3a3f4abef0f46a4cccf8e79ed58f65f328b2c Signed-off-by: Jorge Hernandez <jh1730@att.com> Issue-ID: POLICY-1043 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-09-19Merge "Fixes for oparent upgrade"Jorge Hernandez2-5/+5
2018-09-18Fixes for oparent upgradePamela Dragosh2-5/+5
Small code fix to support jetty upgrade within oparent 1.2.1 from 9.3.* to 9.4.* Issue-ID: POLICY-1126 Change-Id: Id2df5579d05acc738d5edfd055f42628b545dd5a Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-18Add comments and removed redundant code in FiltersJorge Hernandez2-9/+14
Change-Id: I57db9a90550e89ccf23f23de608eedb5d0b7f4ff Signed-off-by: Jorge Hernandez <jh1730@att.com> Issue-ID: POLICY-1043 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-09-18Support for Authorization Generic FiltersJorge Hernandez8-1/+283
These will aid applications using there own authorization system at their desired granularity. Change-Id: Iba7fca8742127bcec177b93452f111d28c7f8ec7 Signed-off-by: Jorge Hernandez <jh1730@att.com> Issue-ID: POLICY-1043
2018-09-18Remove override of parent aaf versionPamela Dragosh1-1/+0
Policy/parent now declare the aaf dependency. This change will use that change. Issue-ID: POLICY-1119 Change-Id: I41d4b6406c76c6f016eeae4871b66acfcba7329e Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-17temporarily set aaf version to snapshotJorge Hernandez4-7/+24
With the latest released version of AAF, encountered problems when testing AAF. This seems to be resolved when migrating to the not-released yet, 2.1.2-SNAPSHOT. Checking further into AAF jira's it seems that some necessary fixes have gone into 2.1.2-SNAPSHOT (see for example AAF-460). The assumption is that 2.1.2-SNAPSHOT will be soon released by AAF team, and then we should appropriately change this version. In addition, there has been enhancements to allow policy apps to configure additional filters. These will be used initially by specific "rest" servers to provide additional authorization capabilities. Change-Id: I48e279738de20bd68e3f05323ad9b6cffdafc83e Signed-off-by: Jorge Hernandez <jh1730@att.com> Issue-ID: POLICY-1044 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2018-09-14add more junit coverage to new Serializer classJim Hahn3-78/+410
Removed calls to superclass methods so that appropriate exceptions are thrown. Better comments for new tests. Removed @Ignore from tests. Removed tabs from pom. Change-Id: I97fa63951eed4c2ac5ce0a267d8da5134a2a1c71 Issue-ID: POLICY-1106 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-13add utility class to test serializable classesJim Hahn2-0/+184
Closed the ByteArrayXxxStreams. Closed byte output stream, even if exception in object stream. Change-Id: I3f779a5c0e6df3ac3496abe60a46e0696b4e261c Issue-ID: POLICY-1106 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-09-12Upgrade dmaap from policy/parentPamela Dragosh1-2/+0
Need the following gerrit review to come in first: https://gerrit.onap.org/r/#/c/66183/ This will now inherit from policy/parent the latest dmaap version to be used across all policy projects. Issue-ID: POLICY-1116 Change-Id: If76895e54d56d153621947da01ca6de2151ead25 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-09-07Remove changing of access on par fieldsliamfallon15-59/+330
Parameter handling refactored to remove changing of access on fields in parameters, new implementation requires getters to be defined for all fields. Note: This change causes a knock on into distribution Change-Id: I172f5d9310caf92d6ea825ff93292019c00a47c3 Issue-ID: POLICY-1095 Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-09-04Merge "Remove unused property"Jorge Hernandez1-1/+0
2018-09-04Remove unused propertyPamela Dragosh1-1/+0
Now that we moved to policy/parent, this property isn't necessary in this repo. Found this as I was looking into mariadb security issues for both drools-pdp and engine. Issue-ID: POLICY-1059 Change-Id: If06e00608fe7f76314c233e806fca5d9150734ae Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-30Add support for http PUTmmis6-45/+112
Added support for http PUT for use by the policy forwarder in policy/distribution Issue-ID: POLICY-926 Change-Id: Ifa5c2e8be0582797936b95b772ad236f35c10f24 Signed-off-by: mmis <michael.morris@ericsson.com>
2018-08-29Merge "Improvements to Parameter Srvice"Pamela Dragosh20-44/+300
2018-08-28Merge "Adding usage of openpojo in policy common"Pamela Dragosh4-130/+200
2018-08-28Adding usage of openpojo in policy commonramverma4-130/+200
* Changing TestHealthCheckReport to use openpojo for testing the HealthCheckReport class. * Adding a custom Tester implementation called ToStringTester as a utility to test toString() method of classes using openpojo. Change-Id: I491a23c471d50454b4d5591c6c09c6758e2c0624 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-28Improvements to Parameter Srviceliamfallon20-44/+300
Add proper handling for optional parameters Add setName() to the parameter group interface to force definition of that method Add some convenience metnods to parameter service Issue-ID: POLICY-1035 Change-Id: Iaa9226f45215b00aff9b78ab5fc120c24a0af46d Signed-off-by: liamfallon <liam.fallon@ericsson.com>
2018-08-23Make checkstyle warnings failPamela Dragosh3-1/+49
For this repo, we add an suppression filter for some abbreviation names. It is far too cumbersome to rename these checkstyle issues at this time. We will do so post-Casablanca release. We copy the oparent checkstyle pom settings and set to fail on any warnings. Change-Id: Icfbd005819a3289acd30796693be85c2ea460212 Issue-ID: POLICY-881 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-22Adding common utility classes to policy/commonramverma4-0/+329
* Adding HealthCheckReport class to policy/common for wider use among all policy modules. * Adding utility class called ParameterValidationUtils for providing common validation methods to all policy modules. For now, it has only 3 validation methods but we all can add more in future. Change-Id: I363fe116ba74f25299fd71211be73505b3164f72 Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-20Use builder for http and jersey clientKrishnajinka8-122/+218
Sonar issue with more than 7 params in a method. Use builder object instead of params. Rework2 for fixing review comments. Add modifications copyright Issue-ID: POLICY-1017 Change-Id: Ib0fa692f8da770dcba06158d6e6cafbed2969c27 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-15Fix checkstyle comments etc.Pamela Dragosh22-165/+225
Adding javadoc comments, renaming variables names, fixed whitespace and 120 length. Also some variables were made final since they were declared further from usage. Splitting out Asserts. Still remaining are the abbreviations. Issue-ID: POLICY-881 Change-Id: I31ce5a9eea02578bce023c0c607a19108bb726fa Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-14Merge "Fixes for checkstyle issues"Jorge Hernandez17-52/+80
2018-08-14Fixes for checkstyle issuesPamela Dragosh17-52/+80
More fixes for spacing, adding comments, adding period at the end, and move code closer to usage. Issue-ID: POLICY-881 Change-Id: Ife99eaf627a221e87d65d24dfd145b0ee4e06d21 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-14Modify topic factory to use builder paramKrishnajinka6-369/+257
Fix sonar issue with method build using more than 7 params Use BusTopicParams to send parameters into methods Issue-ID: POLICY-1017 Change-Id: I194284da63cb95f91ce2e8a8c21a526a5ab9f6f3 Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
2018-08-13Fix checkstyle in utilsPamela Dragosh28-999/+1069
Cleared all the checkstyle in these 2 submodules. Issue-ID: POLICY-881 Change-Id: I248e1894aebf549d5a4f8669a6466ec227d40b55 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-13Remove simple checkstylePamela Dragosh38-505/+526
Mostly concentrated on the period at the end of summary. But I did clear a few others for longer than 120 characters and placement of methods next to each other. Possibly a few others. I did not clear everything, but will submit a few more reviews to get the others. Issue-ID: POLICY-881 Change-Id: I692a5349d686d52fee4040757cdc2ed8b5cc221b Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2018-08-10Merge "get time from correct timer object"Pamela Dragosh1-1/+1
2018-08-10get time from correct timer objectJim Hahn1-1/+1
Change-Id: Ie060e45d2cda368ffbb5908b41594d7795bae40b Issue-ID: POLICY-1045 Signed-off-by: Jim Hahn <jrh3@att.com>
2018-08-09Merge "Fix bug in common-paramter validation service"Pamela Dragosh8-7/+70
2018-08-09Merge "generic jetty filter and cadi support"Pamela Dragosh7-65/+155
2018-08-09Fix bug in common-paramter validation serviceramverma8-7/+70
In GroupValidationResult & GroupMapValidationResult, the setResult method was not setting the actual status that it has recieved from the nested group rather it was setting its own status again. Due to which the validation status of overall ParameterGroup was coming as CLEAN even if a nested child has reported it as INVALID. Changed the expected validation result texts for TestValidation accordingly. Change-Id: I5943decce39574089ca74f9bbccbfbe66d8d542c Issue-ID: POLICY-1035 Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
2018-08-08generic jetty filter and cadi supportJorge Hernandez7-65/+155
Change-Id: I363e44e85e1d89c6254218629010d5c3e1507e0a Issue-ID: POLICY-1043 Signed-off-by: Jorge Hernandez <jh1730@att.com>