summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-11-06Fix bug when IntegrityMonitor runs subsystem lateTemoc Rodriguez1-37/+34
Changes to dependencyCheck to correctly take into account subsystemTest on the first pass through dependencies. Allows for status of repo to remain failed in the case that it fails. Issue-ID: POLICY-431 Change-Id: I23ce43ce41c546edad73ec8055e513ccc61933b0 Signed-off-by: Temoc Rodriguez <cr056n@att.com>
2017-10-27Tweak testTransactionv1.1.0Kevin McKiou1-8/+4
Remove startTransaction from testTransaction since it does nothing functionally and causes exceptions which are logged. Issue-ID: POLICY-369 Change-Id: Idd064b49e1d68832d14039870414626ca56c779b Signed-off-by: Kevin McKiou <km097d@att.com>
2017-09-21Merge "Redundant code removal and hadrcoded strings"Jorge Hernandez6-300/+289
2017-09-21Redundant code removal and hadrcoded stringsBharat saraswal6-300/+289
Issue-Id:POLICY-252 Change-Id: I839811ba15d0c478c83c03818087d3153b77ddb1 Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
2017-09-21Upgrade to release oparent version.Pamela Dragosh1-1/+1
Following independent release and versioning process guidelines. Issue-ID: POLICY-225 Change-Id: I3dad2abc5040255c9271c45eae99394dfd4208b5 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-20Redundant code removal and hadrcoded stringsBharat saraswal1-481/+488
Issue-Id:POLICY-252 Change-Id: Ibf8b6790cbf9f65f1d3b3fc4476f686ff8981a10 Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
2017-09-19Remove sonar critical for public staticPamela Dragosh4-19/+59
I think that making these private and using accessor functions we can remove the sonar critical for them. Issue-ID: POLICY-237 Change-Id: I4edbf909935fe17b0ef087b5cd0e384d78d104d6 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-14Fix sonar critical for passwordPamela Dragosh9-134/+158
Focused on hard coded passwords. I believe they are only used for JUnit tests so I moved them into a file for use. If they still show up on sonar then I will move into a properties file and/or mark as not going to fix. Issue-ID: POLICY-237 Change-Id: I6fa561714091043a2ea5e2edfb0441c2dfc8b044 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-14Changed logger to slf4jMagnusen, Drew (dm741q)10-608/+881
Changed all instances of Sys.out or PolicyLogger to slf4j. Issue-ID: POLICY-178 Change-Id: Ia91af1deb18a9b5c466f6f8a6c546c17c54e14ad Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2017-09-14Logging exceptions to clear sonar criticalPamela Dragosh2-10/+3
Just logging the exceptions anyway and remove e.printstack since that goes to stdout/stderr. Issue-ID: POLICY-195 Change-Id: I60616bd6ce633e2fcae266bb37eb735c6e6bb4c4 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-12Fix sonar critical associated with loggingPamela Dragosh6-74/+39
Addressing the following sonar critical: Use a logger to log this exception Either log or rethrow this exception It does not hurt to simply do these as well as clean out lines of code that dump to Sys.out via e.printStackTrace. Issue-ID: POLICY-195 Change-Id: Ibc328094a0653b7baa04778298e4a69955105ea3 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-11Merge "Clean up unused imports and duplicate version"Jorge Hernandez7-15/+0
2017-09-08Cleanup project's name in SonarJessica Wagantall1-1/+1
The name parameter in the root pom.xml should match the project name in gerrit to reflect consistency in Sonar. Change-Id: Iff23fa13f8b3500aa107447896eed07bfd0d5847 Issue-id: CIMAN-65 Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
2017-09-08Clean up unused imports and duplicate versionPamela Dragosh7-15/+0
Seems oparent sets the version resulting in Eclipse generating warnings for the pom. Also cleaned up unused imports. Issue-ID: POLICY-216 Change-Id: I634025f67aa8847d1c2b6c76b0c8c09336886594 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-09-06Added license header to exception classMagnusen, Drew (dm741q)1-0/+20
Included license header in IntegrityAuditException class since it was accidentally omitted when class was originally created. Issue-ID: POLICY-96 Change-Id: Idcb24e8c7fc6b5a17dc96b51c227be3e24be2bda Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2017-08-24Tweak Common Module JUnitsKevin McKiou9-32/+49
Patch 1: Tweaks Integrity-Audit JUnits to allow at least some estimate of code coverage. It was not possible to enable all the tests as there are threading issues when run in the JUnit environment. Consequently, this is about 2/3 of the actual code coverage. The estimate coverage is about 46% Patch 2: Changes a persistence unit in DBDAOTest. Patch 3: Adds tweaks to IntegrityMonitor JUnits. The estimated state management code coverage is 70%. Patch 4: Removed an IntegrityAudit test that failed which reduced the estimated coverage to 45% Issue-ID: POLICY-108 Change-Id: I693e56083c3ed66e020e82d5ac906ce29224bd58 Signed-off-by: Kevin McKiou <km097d@att.com>
2017-08-15Merge "Resolve major/critical issues in integrity-monitor"Jorge Hernandez16-122/+210
2017-08-15Resolve major/critical issues in integrity-monitorMagnusen, Drew (dm741q)16-122/+210
Resolved major and critical sonar issues in integrity-monitor module. Issue-ID: [POLICY-96] Change-Id: If1da196134a73535668d42f429d647fc819ecaee Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2017-08-14fix resource path bug from package renamingJorge Hernandez1-1/+1
Change-Id: I599fd087c803d062ed6fe1145bf0526fdd29d723 Issue-ID: POLICY-71 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2017-08-14Remove eclipse checkstyle warningsPamela Dragosh1-0/+28
Add this should remove Eclipse warnings: Plugin execution not covered by lifecycle configuration: org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (execution: check-style, phase: process-sources) Issue-Id: POLICY-166 Change-Id: I6e83f05e4d034475d04d85e9b9fbf5f11a1969c7 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-08-11Sonar cleanup for integrity-auditMagnusen, Drew (dm741q)11-36/+67
Modified classes in integrity-audit module to resolve major sonar issues. Issue-ID: [POLICY-96] Change-Id: I5ef0abb8d2a3ea1ae93edc00363c4d2bea1747e2 Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2017-08-08Merge "[POLICY-96] Resolved sonar blockers in im/ia."Pamela Dragosh2-40/+95
2017-08-07Merge "[POLICY-149]policy-common integration with oparent"Jorge Hernandez2-74/+13
2017-08-04[POLICY-96] Resolved sonar blockers in im/ia.Magnusen, Drew (dm741q)2-40/+95
Resolved 7 sonar blockers in the integrity monitor and integrity audit projects. Change-Id: I7bba7619d3b71f7aebcc2642d07a64876ee7aea0 Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2017-08-04[POLICY-149]policy-common integration with oparentGuo Ruijing2-74/+13
Change-Id: I63ae06a4ed4d9f327a75da021d710da6616465c8 Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
2017-08-04[POLICY-98] Code cleanup for sonar issues.Magnusen, Drew (dm741q)15-161/+87
Modified code in ECOMP-Logging to resolve critical/major sonar issues. Not all issues were resolved as some guidance needs to be provided for specific cases. Restored config/policyLogger.properties file. It was modified by a junit test. Change-Id: I49fee98b2497d9d503d81bbbacbb1b416e1058a7 Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2017-08-01Merge "[POLICY-134] Fixed bug in PolicyLogger."Pamela Dragosh1-9/+1
2017-08-01[POLICY-134] Fixed bug in PolicyLogger.Magnusen, Drew (dm741q)1-9/+1
PolicyLogger.info(Object arg0) calls itself recursively until it eventually causes a stack overflow error. Fix is to call debugLogger.info(MessageCodes, String) from within PolicyLogger.info(Object). Additionally, PolicyLogger.info(String arg0) was removed as debugLogger.info(MessageCodes, String) can be called directly. Change-Id: Id141027b544efa06b79f54a6726843b2a47481b9 Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2017-07-31[POLICY-71] forgot one onap-stagingPamela Dragosh1-1/+1
Change-Id: If1edee2823e1edc83781b2e757364b62cb9b6d36 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-07-31[POLICY-71] revert serverIDsPamela Dragosh1-6/+6
Change-Id: I9a9b2ba08d4570c1782914fbc087e9c0d6328ed2 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-07-31[POLICY-71] adding back site-managerPamela Dragosh1-1/+1
The error for merging is permissions issue. Helpdesk #43714 Change-Id: Ifc641b630b023defc56da42aa3359ad330361395 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-07-31[POLICY-71] temp remove of site-managerPamela Dragosh1-1/+1
Change-Id: I2f5190eadbdd73683895f84f5a492bae536b6533 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-07-31[POLICY-71] replace openecomp for policy-commonGuo Ruijing80-296/+298
Change-Id: I3241f5d1f0234043b4dff718eda1ffdc48052276 Signed-off-by: Guo Ruijing <ruijing.guo@intel.com> Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-07-26[POLICY-81] Modified site-manager pom.xml to prevent superfluous warnings ↵Magnusen, Drew (dm741q)1-0/+7
during maven build. The addition of a <configuration> stub was added to the site-manager pom.xml. The stub excludes the org.eclipse.persitence:javax.persistence artifact from the uber-jar created by the maven-shade-plugin. The artifact was a duplicate and maven was throwing an excessive amount of warnings. Change-Id: I1eaeeb569f67aea5578af68d277f44577a20b379 Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2017-07-25[POLICY-81] Code cleanup to eliminate the presence of warning messages in ↵Magnusen, Drew (dm741q)29-138/+53
Eclipse. Change-Id: Id98fdf0241487d56707ac91cde47975c91225f3c Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
2017-07-25Merge "[POLICY-8] clean commons from sonar blockers"Pamela Dragosh2-11/+26
2017-07-24[POLICY-105] Modifications to RefreshStateAuditKevin McKiou3-11/+26
Made the refreshStateAudit configurable and changed the default interval to 10 minutes from 1 minute. Added a check to fpCheck to check the state of the dependent before setting the opstate to disabled. Added a refresh to the forwardprogressentity object in stateAudit() so that we are not reading stale timestamp data. Change-Id: I394feca083fc1fb356d11b9f6886e566c31f248a Signed-off-by: Kevin McKiou <km097d@att.com>
2017-07-24[POLICY-8] clean commons from sonar blockersJorge Hernandez2-11/+26
Change-Id: Ibcc238b21d6ff860a3df80e8bd570a14f5367b5d Signed-off-by: Jorge Hernandez <jh1730@att.com>
2017-06-09[POLICY-8 POLICY-9] cleaning logging issuesJorge Hernandez3-88/+51
A bit of a messy area to clean up without redoing. This is an attempt to clean warnings and being a little more friendly to the callers. policy-9: sonar blocker with dereferencing null pointers in flex logger. policy-8: clean up other warnings from eclipse and sonar. Change-Id: I7aa175673c22490909ae6b40a911a03931961ae3 Signed-off-by: Jorge Hernandez <jh1730@att.com>
2017-05-09Batch submitRalph Straubs3-6/+580
[ECOMPD2TD-000] Update version.properties for iter 41 [US866186 1707] Adding methods to IntegrityMonitor to support state audit. [US866186 1710] Made more progress on teh stateAudit method of IntegritryMontor. Completed all except the addition of properties. [US866186 1710] Addition of IntegrityMonitorProperties.STATE_AUDIT_INTERVAL_MS and logic to stateAudit to determine whether or not to run [US866186 1710] Created a JUnit for getAllForwardProgressEntity() method and debugged and fixed it. [US866186 1710] Making progress on the testStateAudit() JUnit. Was able to create forward progress entries and manually change the lastUpdated date on an entry using a persistence update query. [US866186 1710] First cut of stateAudit JUnit test. Still need to test more cases, but I got it working so far. [US866186 1710] Completed the JUnit for stateAudit. Added 5 new scenarios. Conflicts: version.properties Change-Id: I7b5622a27021cf01b5d916b75824d8e51b5252eb Signed-off-by: Ralph Straubs <rs8887@att.com>
2017-05-03[POLICY-10] remove external repoPamela Dragosh1-3/+3
Change-Id: I9aa00159579aa49c7b9e20415f3f76bdec8b4e27 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-04-28Change name to show Policy Engine for sonar.Pamela Dragosh1-1/+1
Change-Id: I03e282c1dc5f002cae2b862239f72afad23af0e6 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-04-20Batch submitRalph Straubs18-241/+593
[ECOMPD2TD-1073 1707] Removal of extra flush statements and addition of rollbacks in catch blocks instead of commits. [ECOMPD2TD-1073 1707] Adding some needed synchronized statements to IntegrityMonitor. [ECOMPD2TD-1159] - Loggers should be Serializable By making loggers Serializable, they can be included in Drools persistent data. 'EelfLogger' and 'SystemOutLogger' can do this trivially, but 'Logger4J' needed some additional work, because it has a non-serializable field 'log'. [ECOMPD2TD-000] Fix versioning of org.openecomp.policy.* dependencies [US866186 1707] First cut of stateCheck mod and non-working JUnit [US866186 1707] Completed the coding for the task TA1998344 which adds a check of forward progress for dependencies. [US866186 1707] Completed updates to IntegrityMonitor.stateCheck and IntegrityMonitorTest which includes addition of a JUnit for stateCheck and control of the order of JUnit execution. [US865296] ECOMP Policy Logging Compliance, add TargetEntity and TargetServiceName, remove unit from ElapsedTime [US865296] ECOMP Policy Logging Compliance, set audit log statuscode to 'COMPLETE' instead of N/A [US865296] ECOMP Policy Logging Compliance, remove time unit (seconds and milliseconds) from ElapsedTime for logging compliance [US866186 1707] Cleaned up IntegrityAudit JUnit tests. [US866186 1707] IntegrityMonitor JUnit clean up [US866186 1707] Re-added missing classes that were erroneously deleted. [US865296] - add get/setters and inits for required log fields Change-Id: I76ef4606ed6832ed48eaca68e72839a05c8bc3a8 Signed-off-by: Ralph Straubs <rs8887@att.com>
2017-04-12Allow push on custom repoAnaël Closson1-4/+7
Current configuration doesn't give the possibility to fully change where the artifacts should be pushed. This blocks the possibility to push artifacts to a custom repository outside of the LF Change-Id: I0a0f02ec72c06ffe3d41d25538072c0db0e99317 Signed-off-by: Anaël Closson <ac2550@intl.att.com>
2017-04-10javadoc detailsPamela Dragosh1-2/+35
Change-Id: Ib9e96b7d388fbe6c2ce2564953fda735fb65042d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-03-30update to ONAPPamela Dragosh2-2/+2
Change-Id: I193359ec88e361e3aee8316bca720f3ad5e80acb Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-03-10upgrade version.propertiesPamela Dragosh1-1/+1
Change-Id: Id7ce741e0217a36bb7b8bc65c0af4b2e9657857d Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-03-10upgrading to 1.1.0-SNAPSHOTPamela Dragosh5-5/+5
Change-Id: I33d11e370801ff9d0f21339ccf953d29c872ff09 Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
2017-03-10Merge "weird version"Pamela Dragosh1-5/+0
2017-03-10weird versionPamela Dragosh1-5/+0
Change-Id: I822d994cbedb196e9e5e03e94039f044ab9489ca Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>