Fix managed noop topic source

NOOP topic sources configured via TopicParameterGroup are left
unmanaged.  Removed a new override method, as it did not pass
the "managed" flag down, while the method that already existed
in the superclass already works correctly.

Also restored "null" lists to TopicParameterGroup so-as not
to break the behavior of its validate() method.

Change-Id: Id392a3263c3bd1c8f278461715b441719817c47c
Issue-ID: POLICY-1953
Signed-off-by: Jim Hahn <jrh3@att.com>

1 files changed, 13 insertions, 0 deletions

diff --git a/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/TopicEndpointProxyTest.java b/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/TopicEndpointProxyTest.java
index 22ddecd1..fa432265 100644
--- a/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/TopicEndpointProxyTest.java
+++ b/policy-endpoints/src/test/java/org/onap/policy/common/endpoints/event/comm/TopicEndpointProxyTest.java
@@ -22,10 +22,12 @@ package org.onap.policy.common.endpoints.event.comm;
 
 import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
 import static org.assertj.core.api.Assertions.assertThatIllegalStateException;
+import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertSame;
 import static org.junit.Assert.assertTrue;
 
+import java.util.LinkedList;
 import java.util.List;
 import java.util.Properties;
 import org.junit.After;
@@ -60,6 +62,9 @@ public class TopicEndpointProxyTest {
      * Constructor.
      */
     public TopicEndpointProxyTest() {
+        group.setTopicSinks(new LinkedList<>());
+        group.setTopicSources(new LinkedList<>());
+
         NoopTopicPropertyBuilder noopSourceBuilder =
             new NoopTopicPropertyBuilder(PolicyEndPointProperties.PROPERTY_NOOP_SOURCE_TOPICS)
                 .makeTopic(NOOP_SOURCE_TOPIC);
@@ -224,6 +229,14 @@ public class TopicEndpointProxyTest {
     }
 
     @Test
+    public void addTopicsTopicParameterGroupNull() {
+        TopicEndpoint manager = new TopicEndpointProxy();
+
+        List<Topic>  topics = manager.addTopics(new TopicParameterGroup());
+        assertEquals(0, topics.size());
+    }
+
+    @Test
     public void lockSinks_lockSources_locked() {
         TopicEndpoint manager = new TopicEndpointProxy();
         manager.lock();