Fix checkstyle comments etc.

Adding javadoc comments, renaming variables names,
fixed whitespace and 120 length. Also some variables
were made final since they were declared further from
usage. Splitting out Asserts.

Still remaining are the abbreviations.

Issue-ID: POLICY-881
Change-Id: I31ce5a9eea02578bce023c0c607a19108bb726fa
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

7 files changed, 48 insertions, 28 deletions

diff --git a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusConsumer.java b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusConsumer.java
index 034ac66e..ecc90139 100644
--- a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusConsumer.java
+++ b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusConsumer.java
@@ -429,6 +429,13 @@ public interface BusConsumer {
 
         private final Properties props;
 
+        /**
+         * Constructor.
+         * 
+         * @param busTopicParams topic paramters
+         * 
+         * @throws MalformedURLException must provide a valid URL
+         */
         public DmaapDmeConsumerWrapper(BusTopicParams busTopicParams) throws MalformedURLException {
 
 
diff --git a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusPublisher.java b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusPublisher.java
index 05e92638..2d1d8257 100644
--- a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusPublisher.java
+++ b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusPublisher.java
@@ -73,6 +73,11 @@ public interface BusPublisher {
         @JsonIgnore
         protected volatile CambriaBatchingPublisher publisher;
 
+        /**
+         * Constructor.
+         * 
+         * @param busTopicParams topic parameters
+         */
         public CambriaPublisherWrapper(BusTopicParams busTopicParams) {
 
             PublisherBuilder builder = new CambriaClientBuilders.PublisherBuilder();
@@ -292,6 +297,12 @@ public interface BusPublisher {
     }
 
     public static class DmaapDmePublisherWrapper extends DmaapPublisherWrapper {
+        
+        /**
+         * Constructor.
+         * 
+         * @param busTopicParams topic parameters
+         */
         public DmaapDmePublisherWrapper(BusTopicParams busTopicParams) {
 
             super(ProtocolTypeConstants.DME2, busTopicParams.getServers(),busTopicParams.getTopic(),
diff --git a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicBase.java b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicBase.java
index 3e112f90..3e4f48e7 100644
--- a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicBase.java
+++ b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicBase.java
@@ -20,8 +20,6 @@
 
 package org.onap.policy.common.endpoints.event.comm.bus.internal;
 
-import java.util.List;
-
 import org.onap.policy.common.endpoints.event.comm.bus.ApiKeyEnabled;
 
 /**
diff --git a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicParams.java b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicParams.java
index 347ae42c..b133f1c7 100644
--- a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicParams.java
+++ b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/BusTopicParams.java
@@ -213,112 +213,113 @@ public class BusTopicParams {
     }
 
     public static class TopicParamsBuilder {
-        BusTopicParams m = new BusTopicParams();
+        
+        BusTopicParams params = new BusTopicParams();
 
         private TopicParamsBuilder() {
         }
 
         public TopicParamsBuilder servers(List<String> servers) {
-            this.m.servers = servers;
+            this.params.servers = servers;
             return this;
         }
 
         public TopicParamsBuilder topic(String topic) {
-            this.m.topic = topic;
+            this.params.topic = topic;
             return this;
         }
 
         public TopicParamsBuilder apiKey(String apiKey) {
-            this.m.apiKey = apiKey;
+            this.params.apiKey = apiKey;
             return this;
         }
 
         public TopicParamsBuilder apiSecret(String apiSecret) {
-            this.m.apiSecret = apiSecret;
+            this.params.apiSecret = apiSecret;
             return this;
         }
 
         public TopicParamsBuilder consumerGroup(String consumerGroup) {
-            this.m.consumerGroup = consumerGroup;
+            this.params.consumerGroup = consumerGroup;
             return this;
         }
 
         public TopicParamsBuilder consumerInstance(String consumerInstance) {
-            this.m.consumerInstance = consumerInstance;
+            this.params.consumerInstance = consumerInstance;
             return this;
         }
 
         public TopicParamsBuilder fetchTimeout(int fetchTimeout) {
-            this.m.fetchTimeout = fetchTimeout;
+            this.params.fetchTimeout = fetchTimeout;
             return this;
         }
 
         public TopicParamsBuilder fetchLimit(int fetchLimit) {
-            this.m.fetchLimit = fetchLimit;
+            this.params.fetchLimit = fetchLimit;
             return this;
         }
 
         public TopicParamsBuilder useHttps(boolean useHttps) {
-            this.m.useHttps = useHttps;
+            this.params.useHttps = useHttps;
             return this;
         }
 
         public TopicParamsBuilder allowSelfSignedCerts(boolean allowSelfSignedCerts) {
-            this.m.allowSelfSignedCerts = allowSelfSignedCerts;
+            this.params.allowSelfSignedCerts = allowSelfSignedCerts;
             return this;
         }
 
         public TopicParamsBuilder userName(String userName) {
-            this.m.userName = userName;
+            this.params.userName = userName;
             return this;
         }
 
         public TopicParamsBuilder password(String password) {
-            this.m.password = password;
+            this.params.password = password;
             return this;
         }
 
         public TopicParamsBuilder environment(String environment) {
-            this.m.environment = environment;
+            this.params.environment = environment;
             return this;
         }
 
         public TopicParamsBuilder aftEnvironment(String aftEnvironment) {
-            this.m.aftEnvironment = aftEnvironment;
+            this.params.aftEnvironment = aftEnvironment;
             return this;
         }
 
         public TopicParamsBuilder partner(String partner) {
-            this.m.partner = partner;
+            this.params.partner = partner;
             return this;
         }
 
         public TopicParamsBuilder latitude(String latitude) {
-            this.m.latitude = latitude;
+            this.params.latitude = latitude;
             return this;
         }
 
         public TopicParamsBuilder longitude(String longitude) {
-            this.m.longitude = longitude;
+            this.params.longitude = longitude;
             return this;
         }
 
         public TopicParamsBuilder additionalProps(Map<String, String> additionalProps) {
-            this.m.additionalProps = additionalProps;
+            this.params.additionalProps = additionalProps;
             return this;
         }
 
         public TopicParamsBuilder partitionId(String partitionId) {
-            this.m.partitionId = partitionId;
+            this.params.partitionId = partitionId;
             return this;
         }
 
         public BusTopicParams build() {
-            return m;
+            return params;
         }
 
         public TopicParamsBuilder managed(boolean managed) {
-            this.m.managed = managed;
+            this.params.managed = managed;
             return this;
         }
     }
diff --git a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineDmaapTopicSink.java b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineDmaapTopicSink.java
index 5c18fb3f..eb431229 100644
--- a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineDmaapTopicSink.java
+++ b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/InlineDmaapTopicSink.java
@@ -21,7 +21,6 @@
 
 package org.onap.policy.common.endpoints.event.comm.bus.internal;
 
-import java.util.List;
 import java.util.Map;
 
 import org.onap.policy.common.endpoints.event.comm.Topic;
diff --git a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/SingleThreadedBusTopicSource.java b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/SingleThreadedBusTopicSource.java
index e4b335c3..f9dd4852 100644
--- a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/SingleThreadedBusTopicSource.java
+++ b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/SingleThreadedBusTopicSource.java
@@ -78,9 +78,11 @@ public abstract class SingleThreadedBusTopicSource extends BusTopicBase
 
 
     /**
-     * 
+     * Constructor.
      *
-     * @param busTopicParams@throws IllegalArgumentException An invalid parameter passed in
+     * @param busTopicParams topic parameters
+     * 
+     * @throws IllegalArgumentException An invalid parameter passed in
      */
     public SingleThreadedBusTopicSource(BusTopicParams busTopicParams) {
 
diff --git a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/SingleThreadedDmaapTopicSource.java b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/SingleThreadedDmaapTopicSource.java
index 0fcb86b4..45c0b6fc 100644
--- a/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/SingleThreadedDmaapTopicSource.java
+++ b/policy-endpoints/src/main/java/org/onap/policy/common/endpoints/event/comm/bus/internal/SingleThreadedDmaapTopicSource.java
@@ -51,8 +51,10 @@ public class SingleThreadedDmaapTopicSource extends SingleThreadedBusTopicSource
 
 
     /**
+     * Constructor.
+     * 
+     * @param busTopicParams Parameters object containing all the required inputs
      * 
-     * @param busTopicParams Parameters object containing all the required inputs     *
      * @throws IllegalArgumentException An invalid parameter passed in
      */
     public SingleThreadedDmaapTopicSource(BusTopicParams busTopicParams) {