Fix remaining sonar issues in Integrity Audit

Renamed enums to upper case - this might disrupt other repos, though
it should be minimal.
Renamed constants in a junit test.

Change-Id: Ifd864bb61eec3d9b3c7a0321fe3841696046f6f6
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>

1 files changed, 5 insertions, 4 deletions

diff --git a/integrity-audit/src/main/java/org/onap/policy/common/ia/IntegrityAudit.java b/integrity-audit/src/main/java/org/onap/policy/common/ia/IntegrityAudit.java
index 61bf947e..41aea118 100644
--- a/integrity-audit/src/main/java/org/onap/policy/common/ia/IntegrityAudit.java
+++ b/integrity-audit/src/main/java/org/onap/policy/common/ia/IntegrityAudit.java
@@ -105,7 +105,7 @@ public class IntegrityAudit {
      */
     public static boolean isNodeTypeEnum(String nt) {
         for (NodeTypeEnum n : NodeTypeEnum.values()) {
-            if (n.toString().equals(nt)) {
+            if (n.toString().equalsIgnoreCase(nt)) {
                 return true;
             }
         }
@@ -171,11 +171,12 @@ public class IntegrityAudit {
         } else {
             nodeType = nodeType.trim();
             if (!isNodeTypeEnum(nodeType)) {
-                String nodetypes = "nodeType must be one of[";
+                badparams.append("nodeType must be one of[");
                 for (NodeTypeEnum n : NodeTypeEnum.values()) {
-                    nodetypes = nodetypes.concat(n.toString() + " ");
+                    badparams.append(n.toString());
+                    badparams.append(' ');
                 }
-                badparams.append(nodetypes + "] ");
+                badparams.append("] ");
                 return true;
             }
         }